[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372736#comment-15372736 ] Hudson commented on LENS-1019: -- UNSTABLE: Integrated in Lens-Commit #1291 (See [https://builds.apache.org/job/Lens-Commit/1291/]) LENS-1177: Adding restart tests and testcases for LENS-1019 and (rajatgupta59: rev 0dfdaa9ecdd3f75cd8d8300e055822a99322cc2e) * lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java * lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java * lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java * lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java * lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java * lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java * lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15372711#comment-15372711 ] Hudson commented on LENS-1019: -- SUCCESS: Integrated in Lens-Commit-Java8 #202 (See [https://builds.apache.org/job/Lens-Commit-Java8/202/]) LENS-1177: Adding restart tests and testcases for LENS-1019 and (rajatgupta59: rev 0dfdaa9ecdd3f75cd8d8300e055822a99322cc2e) * lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java * lens-regression/src/main/java/org/apache/lens/regression/core/constants/QueryInventory.java * lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java * lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java * lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java * lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java * lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15327199#comment-15327199 ] Hudson commented on LENS-1019: -- UNSTABLE: Integrated in Lens-Commit-Java8 #179 (See [https://builds.apache.org/job/Lens-Commit-Java8/179/]) LENS-1143: Fix test cases to incorporate LENS-1019 changes (rajatgupta59: rev 68c5267f0868b77e24101fdd493d5d733c27871f) * lens-server/src/test/java/org/apache/lens/server/query/TestDuplicateQueries.java * lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java * lens-dist/src/deb/control/ui-control/control > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15288775#comment-15288775 ] Hudson commented on LENS-1019: -- FAILURE: Integrated in Lens-Commit #1250 (See [https://builds.apache.org/job/Lens-Commit/1250/]) LENS-1143: Fix test cases to incorporate LENS-1019(Same session handle (rajatgupta59: rev 18999b9742920774fbb297d3600e9c8ba85a9e06) * lens-server/src/test/resources/lens-site.xml * lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java * lens-ml-lib/src/test/resources/lens-site.xml * lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281540#comment-15281540 ] Hudson commented on LENS-1019: -- UNSTABLE: Integrated in Lens-Commit-Java8 #158 (See [https://builds.apache.org/job/Lens-Commit-Java8/158/]) LENS-1019: Return same handle for repeated query from same user (puneet.gupta: rev 797899c31aab81947a871d449adf9c00aba8ae3c) * lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java * lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java * lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java * lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java * lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java * lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java * src/site/apt/admin/config.apt * lens-server/src/main/resources/lensserver-default.xml > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281529#comment-15281529 ] Hudson commented on LENS-1019: -- SUCCESS: Integrated in Lens-Commit #1245 (See [https://builds.apache.org/job/Lens-Commit/1245/]) LENS-1019: Return same handle for repeated query from same user (puneet.gupta: rev 797899c31aab81947a871d449adf9c00aba8ae3c) * lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java * lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java * lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java * lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java * lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java * src/site/apt/admin/config.apt * lens-server/src/main/resources/lensserver-default.xml * lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281489#comment-15281489 ] Puneet Gupta commented on LENS-1019: Committed. Thanks [~lavkesh] > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281445#comment-15281445 ] Hadoop QA commented on LENS-1019: - Applied patch: [LENS-1019.patch|https://issues.apache.org/jira/secure/attachment/12803627/LENS-1019.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/439/ > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281426#comment-15281426 ] Hadoop QA commented on LENS-1019: - Applied patch: [LENS-1019.patch|https://issues.apache.org/jira/secure/attachment/12803627/LENS-1019.patch] and ran command: mvn clean install -fae. Result: Success. Build Job: https://builds.apache.org/job/PreCommit-Lens-Build/437/ > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.patch > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15281399#comment-15281399 ] Lavkesh Lahngir commented on LENS-1019: --- Review request: https://reviews.apache.org/r/47007/ > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement > Components: server >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > Fix For: 2.6 > > Attachments: LENS-1019.diff > > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272272#comment-15272272 ] Lavkesh Lahngir commented on LENS-1019: --- 1. There is no need to check for sync queries, because they are very short lived. Or there will be a timeout of a fixe duration which will cancel the query which are not completed. 2. We have to check if the user provided conf is the same for the previous query. QueryContext class has a lensconf which is updated with all the configurations. So the user-conf is merged in the lensConf. There is no separate way to get the user-conf. We can store the user-conf in QueryContext or if we want to optimise, we could just store a md5-hash of the conf. > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement >Reporter: Lavkesh Lahngir >Assignee: Lavkesh Lahngir > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (LENS-1019) Return same handle for repeated query from same user
[ https://issues.apache.org/jira/browse/LENS-1019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257742#comment-15257742 ] Amareshwari Sriramadasu commented on LENS-1019: --- [~lavkesh], Added you to Lens contributors. Feel free assign the issue to yourself. > Return same handle for repeated query from same user > > > Key: LENS-1019 > URL: https://issues.apache.org/jira/browse/LENS-1019 > Project: Apache Lens > Issue Type: Improvement >Reporter: Lavkesh Lahngir > > If query is repeated from user - with same query, same name, same conf on the > same session > and earlier is still queued or running, then return the same handle. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
