Fwd: Opt in for JMX server?

2020-11-16 Thread Gary Gregory
Hi All,

I am starting to think that registering JMX MBeans after setting a config
from the Core's logger context should be opt in and not done always.

This would make startup (a little?) faster and "safer" since opening up JMX
could be considered a security issue.

At least we have a global opt out through a system property...

Gary


Re: Fwd: Opt in for JMX server?

2020-11-16 Thread Carter Kozak
Sounds like a great idea to me. At work we use a different framework to report 
metrics and generally disable jmx everywhere that allows us to do so.

-ck

On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote:
> Hi All,
> 
> I am starting to think that registering JMX MBeans after setting a config
> from the Core's logger context should be opt in and not done always.
> 
> This would make startup (a little?) faster and "safer" since opening up JMX
> could be considered a security issue.
> 
> At least we have a global opt out through a system property...
> 
> Gary
> 


Jenkins build failure in JSON template module

2020-11-16 Thread Gary Gregory
Hi All,

The Jenkins build is failing in the JSON template module.

Gary


Re: Opt in for JMX server?

2020-11-16 Thread Ralph Goers
I believe that will be a requirement in Master since JMX isn’t included in the 
base module.

Ralph

> On Nov 16, 2020, at 7:44 AM, Carter Kozak  wrote:
> 
> Sounds like a great idea to me. At work we use a different framework to 
> report metrics and generally disable jmx everywhere that allows us to do so.
> 
> -ck
> 
> On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote:
>> Hi All,
>> 
>> I am starting to think that registering JMX MBeans after setting a config
>> from the Core's logger context should be opt in and not done always.
>> 
>> This would make startup (a little?) faster and "safer" since opening up JMX
>> could be considered a security issue.
>> 
>> At least we have a global opt out through a system property...
>> 
>> Gary
>> 




Re: Opt in for JMX server?

2020-11-16 Thread Gary Gregory
So we might as well do it in 2.x and set expectations for the future 3.x
IMO.

Gary

On Mon, Nov 16, 2020, 10:26 Ralph Goers  wrote:

> I believe that will be a requirement in Master since JMX isn’t included in
> the base module.
>
> Ralph
>
> > On Nov 16, 2020, at 7:44 AM, Carter Kozak  wrote:
> >
> > Sounds like a great idea to me. At work we use a different framework to
> report metrics and generally disable jmx everywhere that allows us to do so.
> >
> > -ck
> >
> > On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote:
> >> Hi All,
> >>
> >> I am starting to think that registering JMX MBeans after setting a
> config
> >> from the Core's logger context should be opt in and not done always.
> >>
> >> This would make startup (a little?) faster and "safer" since opening up
> JMX
> >> could be considered a security issue.
> >>
> >> At least we have a global opt out through a system property...
> >>
> >> Gary
> >>
>
>
>


Re: Jenkins build failure in JSON template module

2020-11-16 Thread Volkan Yazıcı
Hey Gary,

Thanks for the heads-up. I am indeed aware of the break in the build,
though still couldn't spare time to take a look. I hope to put it into
working state some time tomorrow.

Kind regards.

On Mon, Nov 16, 2020 at 4:19 PM Gary Gregory  wrote:

> Hi All,
>
> The Jenkins build is failing in the JSON template module.
>
> Gary
>


Re: Opt in for JMX server?

2020-11-16 Thread Remko Popma
+1 Explicit enabling is better.

On Tue, Nov 17, 2020 at 12:39 AM Gary Gregory 
wrote:

> So we might as well do it in 2.x and set expectations for the future 3.x
> IMO.
>
> Gary
>
> On Mon, Nov 16, 2020, 10:26 Ralph Goers 
> wrote:
>
> > I believe that will be a requirement in Master since JMX isn’t included
> in
> > the base module.
> >
> > Ralph
> >
> > > On Nov 16, 2020, at 7:44 AM, Carter Kozak  wrote:
> > >
> > > Sounds like a great idea to me. At work we use a different framework to
> > report metrics and generally disable jmx everywhere that allows us to do
> so.
> > >
> > > -ck
> > >
> > > On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote:
> > >> Hi All,
> > >>
> > >> I am starting to think that registering JMX MBeans after setting a
> > config
> > >> from the Core's logger context should be opt in and not done always.
> > >>
> > >> This would make startup (a little?) faster and "safer" since opening
> up
> > JMX
> > >> could be considered a security issue.
> > >>
> > >> At least we have a global opt out through a system property...
> > >>
> > >> Gary
> > >>
> >
> >
> >
>


Re: Opt in for JMX server?

2020-11-16 Thread Matt Sicker
I’m on board with the idea too. Using JMX securely takes additional setup
with certificates and other configuration anyways.

On Mon, Nov 16, 2020 at 16:11 Remko Popma  wrote:

> +1 Explicit enabling is better.
>
> On Tue, Nov 17, 2020 at 12:39 AM Gary Gregory 
> wrote:
>
> > So we might as well do it in 2.x and set expectations for the future 3.x
> > IMO.
> >
> > Gary
> >
> > On Mon, Nov 16, 2020, 10:26 Ralph Goers 
> > wrote:
> >
> > > I believe that will be a requirement in Master since JMX isn’t included
> > in
> > > the base module.
> > >
> > > Ralph
> > >
> > > > On Nov 16, 2020, at 7:44 AM, Carter Kozak  wrote:
> > > >
> > > > Sounds like a great idea to me. At work we use a different framework
> to
> > > report metrics and generally disable jmx everywhere that allows us to
> do
> > so.
> > > >
> > > > -ck
> > > >
> > > > On Mon, Nov 16, 2020, at 09:39, Gary Gregory wrote:
> > > >> Hi All,
> > > >>
> > > >> I am starting to think that registering JMX MBeans after setting a
> > > config
> > > >> from the Core's logger context should be opt in and not done always.
> > > >>
> > > >> This would make startup (a little?) faster and "safer" since opening
> > up
> > > JMX
> > > >> could be considered a security issue.
> > > >>
> > > >> At least we have a global opt out through a system property...
> > > >>
> > > >> Gary
> > > >>
> > >
> > >
> > >
> >
>