Re: [VOTE] Release Apache Log4j Tools 0.3.0
Adding my +1. With that, the release passes with 3 binding +1 votes from me, Piotr, and Matt. (I will address Gary's Windows-related issues either in the mailing list or in Slack.) On Tue, Mar 14, 2023 at 10:08 PM Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: > https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required. >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
We may also tweak the lineEndings parameter based on a profile ( https://github.com/diffplug/spotless/tree/main/plugin-gradle#line-endings-and-encodings-invisible-stuff ) (instead of dropping the whole plugin) Benoit Le jeu. 16 mars 2023 à 10:48, Piotr P. Karwasz a écrit : > Hi Ralph, > > On Wed, 15 Mar 2023 at 23:59, Ralph Goers > wrote: > > > > Just require the build to run on a Unix-like variant. Nobody is going to > give a crap that the tools don’t build on Windows. > > At least Gary does. > > On the other hand nobody gives a crap that Spotless does not work on > the source distribution. we could move it to a profile (activated by > the presence of a `.git` folder?). > > Piotr >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Hi Ralph, On Wed, 15 Mar 2023 at 23:59, Ralph Goers wrote: > > Just require the build to run on a Unix-like variant. Nobody is going to give > a crap that the tools don’t build on Windows. At least Gary does. On the other hand nobody gives a crap that Spotless does not work on the source distribution. we could move it to a profile (activated by the presence of a `.git` folder?). Piotr
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Just require the build to run on a Unix-like variant. Nobody is going to give a crap that the tools don’t build on Windows. Ralph > On Mar 15, 2023, at 3:16 PM, Piotr P. Karwasz wrote: > > Hi Gary, > > On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: >> [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- >> [INFO] Index file does not exist. Fallback to an empty index >> [INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be >> clean, 0 were already clean, 0 were skipped because caching determined they >> were already clean > > CRLF, CRLF, CRLF... (or lack of) > > By default Spotless respects Git's EOL settings (.gitattributes and > autocrlf). By default Git replaces LF with CRLF when checking out a > Java file. Therefore Spotless expects to find CRLF line endings on > Windows, but finds LF. > > I don't know what is the correct solution. We are in 2023, but still > many things depend on the default line endings of the OS (like files > generated by Maven). Maybe we should simplify the problem and: > > * disable line endings conversion in Git, > * set all the line endings to LF (nobody uses notepad.exe to read Java files). > > Piotr
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Latest version of Notepad probably supports line feed endings these days as it is. > On Mar 15, 2023, at 5:16 PM, Piotr P. Karwasz wrote: > > Hi Gary, > > On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: >> [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- >> [INFO] Index file does not exist. Fallback to an empty index >> [INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be >> clean, 0 were already clean, 0 were skipped because caching determined they >> were already clean > > CRLF, CRLF, CRLF... (or lack of) > > By default Spotless respects Git's EOL settings (.gitattributes and > autocrlf). By default Git replaces LF with CRLF when checking out a > Java file. Therefore Spotless expects to find CRLF line endings on > Windows, but finds LF. > > I don't know what is the correct solution. We are in 2023, but still > many things depend on the default line endings of the OS (like files > generated by Maven). Maybe we should simplify the problem and: > > * disable line endings conversion in Git, > * set all the line endings to LF (nobody uses notepad.exe to read Java files). > > Piotr
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Hi Gary, On Wed, 15 Mar 2023 at 22:58, Gary D. Gregory wrote: > [INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog --- > [INFO] Index file does not exist. Fallback to an empty index > [INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be > clean, 0 were already clean, 0 were skipped because caching determined they > were already clean CRLF, CRLF, CRLF... (or lack of) By default Spotless respects Git's EOL settings (.gitattributes and autocrlf). By default Git replaces LF with CRLF when checking out a Java file. Therefore Spotless expects to find CRLF line endings on Windows, but finds LF. I don't know what is the correct solution. We are in 2023, but still many things depend on the default line endings of the OS (like files generated by Maven). Maybe we should simplify the problem and: * disable line endings conversion in Git, * set all the line endings to LF (nobody uses notepad.exe to read Java files). Piotr
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Based on the src zip download:
(Please see my notes below for 1 improvement to the sha file)
mvn clean verify
Gives me:
[INFO] --- spotless:2.35.0:check (default-spotless) @ log4j-changelog ---
[INFO] Index file does not exist. Fallback to an empty index
[INFO] Spotless.Java is keeping 24 files clean - 24 needs changes to be clean,
0 were already clean, 0 were skipped because caching determined they were
already clean
[INFO]
[INFO] Reactor Summary for log4j-tools-bom 0.3.0:
[INFO]
[INFO] log4j-tools-bom SUCCESS [ 3.313 s]
[INFO] log4j-tools-parent . SUCCESS [ 8.199 s]
[INFO] log4j-changelog FAILURE [ 13.450 s]
[INFO] log4j-changelog-maven-plugin ... SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 25.218 s
[INFO] Finished at: 2023-03-15T17:57:20-04:00
[INFO]
[ERROR] Failed to execute goal
com.diffplug.spotless:spotless-maven-plugin:2.35.0:check (default-spotless) on
project log4j-changelog: The following files had format violations:
[ERROR] src\main\java\org\apache\logging\log4j\changelog\ChangelogEntry.java
[ERROR] @@ -1,206 +1,206 @@
[ERROR] -/*\n
[ERROR] - * Licensed to the Apache Software Foundation (ASF) under one
or more\n
[ERROR] - * contributor license agreements. See the NOTICE file
distributed with\n
[ERROR] - * this work for additional information regarding copyright
ownership.\n
[ERROR] - * The ASF licenses this file to You under the Apache license,
Version 2.0\n
[ERROR] - * (the "License"); you may not use this file except in
compliance with\n
[ERROR] - * the License. You may obtain a copy of the License at\n
[ERROR] - *\n
[ERROR] - * http://www.apache.org/licenses/LICENSE-2.0\n
[ERROR] - *\n
[ERROR] - * Unless required by applicable law or agreed to in writing,
software\n
[ERROR] - * distributed under the License is distributed on an "AS IS"
BASIS,\n
[ERROR] - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express or implied.\n
[ERROR] - * See the license for the specific language governing
permissions and\n
[ERROR] - * limitations under the license.\n
[ERROR] - */\n
[ERROR] -package org.apache.logging.log4j.changelog;\n
[ERROR] -\n
[ERROR] -import java.nio.file.Path;\n
[ERROR] -import java.util.List;\n
[ERROR] -import java.util.Locale;\n
[ERROR] -import java.util.stream.Collectors;\n
[ERROR] -\n
[ERROR] -import org.apache.logging.log4j.changelog.util.StringUtils;\n
[ERROR] -import org.apache.logging.log4j.changelog.util.XmlReader;\n
[ERROR] -import org.apache.logging.log4j.changelog.util.XmlWriter;\n
[ERROR] -\n
[ERROR] -import edu.umd.cs.findbugs.annotations.Nullable;\n
[ERROR] -import org.w3c.dom.Element;\n
[ERROR] -\n
[ERROR] -public final class ChangelogEntry {\n
[ERROR] -\n
[ERROR] -public final Type type;\n
[ERROR] -\n
[ERROR] -public final List issues;\n
[ERROR] -\n
[ERROR] -public final List authors;\n
[ERROR] -\n
[ERROR] -public final Description description;\n
[ERROR] -\n
[ERROR] -public enum Type {\n
[ERROR] -\n
[ERROR] -ADDED,\n
[ERROR] -\n
[ERROR] -CHANGED,\n
[ERROR] -\n
[ERROR] -DEPRECATED,\n
[ERROR] -\n
[ERROR] ... (364 more lines that didn't fit)
[ERROR] Violations also present in 23 other files.
[ERROR] Run 'mvn spotless:apply' to fix these violations.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn -rf :log4j-changelog
Using:
Apache Maven 3.9.0 (9b58d2bad23a66be161c4664ef21ce219c2c8584)
Maven home: C:\java\apache-maven-3.9.0
Java version: 17.0.6, vendor: Eclipse Adoptium, runtime: C:\Program
Files\Eclipse Adoptium\jdk-17.0.6.10-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
FYI:
$ cat apache-log4j-tools-0.3.0-src.zip.sha512
Re: [VOTE] Release Apache Log4j Tools 0.3.0
On 2023/03/15 21:46:10 "Gary D. Gregory" wrote: > IMO, VOTE emails should contain a link to the appropriate KEYS file. FTR: https://downloads.apache.org/logging/KEYS Gary > > Gary > > On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voting. > > > > This release contains the following minor enhancements: > > > > * Upgrade the compiler version to Java 17, yet still target Java 8 > > * Support multiple and formatting-agnostic template files (#44) > > * The changelog release models passed to the index template file > > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > > (#37) > > > > Source repository: https://github.com/apache/logging-log4j-tools > > Tag: rel/0.3.0-rc.1 > > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > > CI run: > > https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > > Nexus repository: > > https://repository.apache.org/content/repositories/orgapachelogging-1100 > > Signing key: > > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > > > Please download, test, and cast your votes on the Log4j developers list. > > > > [ ] +1, release the artifacts > > [ ] -1, don't release, because... > > > > The vote will remain open for 24 hours (or more if required). All > > votes are welcome and we encourage everyone to test the release, but > > only the Logging Services PMC votes are officially counted. At least 3 > > +1 votes and more positive than negative votes are required. > > >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
IMO, VOTE emails should contain a link to the appropriate KEYS file. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required. >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
There are still 0.2.0 files in /dev/logging/log4j ! Delete please. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required. >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Arg, I downloaded the wrong files. Ralph and all RMs: Please delete files post release from /dev/logging/log4j Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required. >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Hi All, I do not think we should clutter things up by publishing two sets of SHA files (256 & 512), SHA-512 only is plenty IMO. Gary On 2023/03/14 21:08:39 Volkan Yazıcı wrote: > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required. >
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Took me a few tries to find the right JDK to use (17), but everything checks out fine. +1 > On Mar 14, 2023, at 4:08 PM, Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) > > Source repository: https://github.com/apache/logging-log4j-tools > Tag: rel/0.3.0-rc.1 > Commit: 243017d3f60410780dd6d15b8b677bc5b018d1cf > CI run: https://github.com/apache/logging-log4j-tools/actions/runs/4420103110 > Artifacts: https://dist.apache.org/repos/dist/dev/logging/log4j/ > Nexus repository: > https://repository.apache.org/content/repositories/orgapachelogging-1100 > Signing key: > https://keyserver.ubuntu.com/pks/lookup?search=077e8893a6dcc33dd4a4d5b256e73ba9a0b592d0=on=index > > Please download, test, and cast your votes on the Log4j developers list. > > [ ] +1, release the artifacts > [ ] -1, don't release, because... > > The vote will remain open for 24 hours (or more if required). All > votes are welcome and we encourage everyone to test the release, but > only the Logging Services PMC votes are officially counted. At least 3 > +1 votes and more positive than negative votes are required.
Re: [VOTE] Release Apache Log4j Tools 0.3.0
Hi Volkan, On Tue, 14 Mar 2023 at 22:08, Volkan Yazıcı wrote: > > The Apache Log4j Tools 0.3.0 release is now available for voting. > > This release contains the following minor enhancements: > > * Upgrade the compiler version to Java 17, yet still target Java 8 > * Support multiple and formatting-agnostic template files (#44) > * The changelog release models passed to the index template file > (`.index.adoc.ftl`) is enriched with `changelogEntryCount` fields > (#37) The artifact's hashes are the same as those generated locally: +1
