Re: Welcome Luca Cavanna as Lucene committer

[Mikhail Khludnev]

Welcome, Luca.

On Wed, Oct 5, 2022 at 8:04 PM Adrien Grand  wrote:

> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
> --
> Adrien
>


-- 
Sincerely yours
Mikhail Khludnev

Re: Welcome Luca Cavanna as Lucene committer

[Gus Heck]

Welcome :)

On Wed, Oct 5, 2022 at 5:38 PM Michael McCandless 
wrote:

> Welcome Luca!
>
> Mike
>
> On Wed, Oct 5, 2022 at 4:37 PM Tomás Fernández Löbbe <
> tomasflo...@gmail.com> wrote:
>
>> Congratulations Luca!!
>>
>> On Wed, Oct 5, 2022 at 2:19 PM Vigya Sharma  wrote:
>>
>>> Congratulations Luca! And welcome...
>>>
>>> Vigya
>>>
>>> On Wed, Oct 5, 2022 at 3:36 PM Uwe Schindler  wrote:
>>>
 Welcome Luca. This was long overdue. 

 Am 5. Oktober 2022 19:03:43 MESZ schrieb Adrien Grand <
 jpou...@gmail.com>:
>
> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
> --
> Adrien
>
 --
 Uwe Schindler
 Achterdiek 19, 28357 Bremen
 
 https://www.thetaphi.de

>>>
>>>
>>> --
>>> - Vigya
>>>
>> --
> Mike McCandless
>
> http://blog.mikemccandless.com
>


-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)

Re: Welcome Luca Cavanna as Lucene committer

[Michael McCandless]

Welcome Luca!

Mike

On Wed, Oct 5, 2022 at 4:37 PM Tomás Fernández Löbbe 
wrote:

> Congratulations Luca!!
>
> On Wed, Oct 5, 2022 at 2:19 PM Vigya Sharma  wrote:
>
>> Congratulations Luca! And welcome...
>>
>> Vigya
>>
>> On Wed, Oct 5, 2022 at 3:36 PM Uwe Schindler  wrote:
>>
>>> Welcome Luca. This was long overdue. 
>>>
>>> Am 5. Oktober 2022 19:03:43 MESZ schrieb Adrien Grand >> >:

 I'm pleased to announce that Luca Cavanna has accepted the PMC's
 invitation to become a committer.

 Luca, the tradition is that new committers introduce themselves with a
 brief bio.

 Congratulations and welcome!

 --
 Adrien

>>> --
>>> Uwe Schindler
>>> Achterdiek 19, 28357 Bremen
>>> 
>>> https://www.thetaphi.de
>>>
>>
>>
>> --
>> - Vigya
>>
> --
Mike McCandless

http://blog.mikemccandless.com

Re: Welcome Luca Cavanna as Lucene committer

[Tomás Fernández Löbbe]

Congratulations Luca!!

On Wed, Oct 5, 2022 at 2:19 PM Vigya Sharma  wrote:

> Congratulations Luca! And welcome...
>
> Vigya
>
> On Wed, Oct 5, 2022 at 3:36 PM Uwe Schindler  wrote:
>
>> Welcome Luca. This was long overdue. 
>>
>> Am 5. Oktober 2022 19:03:43 MESZ schrieb Adrien Grand > >:
>>>
>>> I'm pleased to announce that Luca Cavanna has accepted the PMC's
>>> invitation to become a committer.
>>>
>>> Luca, the tradition is that new committers introduce themselves with a
>>> brief bio.
>>>
>>> Congratulations and welcome!
>>>
>>> --
>>> Adrien
>>>
>> --
>> Uwe Schindler
>> Achterdiek 19, 28357 Bremen
>> 
>> https://www.thetaphi.de
>>
>
>
> --
> - Vigya
>

Re: Welcome Luca Cavanna as Lucene committer

[Vigya Sharma]

Congratulations Luca! And welcome...

Vigya

On Wed, Oct 5, 2022 at 3:36 PM Uwe Schindler  wrote:

> Welcome Luca. This was long overdue. 
>
> Am 5. Oktober 2022 19:03:43 MESZ schrieb Adrien Grand :
>>
>> I'm pleased to announce that Luca Cavanna has accepted the PMC's
>> invitation to become a committer.
>>
>> Luca, the tradition is that new committers introduce themselves with a
>> brief bio.
>>
>> Congratulations and welcome!
>>
>> --
>> Adrien
>>
> --
> Uwe Schindler
> Achterdiek 19, 28357 Bremen
> https://www.thetaphi.de
>


-- 
- Vigya

Re: Welcome Luca Cavanna as Lucene committer

[Uwe Schindler]

Welcome Luca. This was long overdue. 

Am 5. Oktober 2022 19:03:43 MESZ schrieb Adrien Grand :
>I'm pleased to announce that Luca Cavanna has accepted the PMC's
>invitation to become a committer.
>
>Luca, the tradition is that new committers introduce themselves with a
>brief bio.
>
>Congratulations and welcome!
>
>-- 
>Adrien

--
Uwe Schindler
Achterdiek 19, 28357 Bremen
https://www.thetaphi.de

Re: Welcome Luca Cavanna as Lucene committer

[Patrick Zhai]

Welcome!

On Wed, Oct 5, 2022, 13:54 Martin Gainty  wrote:

> welcome Luca!
> --
> *From:* David Smiley 
> *Sent:* Wednesday, October 5, 2022 2:34 PM
> *To:* dev@lucene.apache.org 
> *Cc:* cavannal...@gmail.com 
> *Subject:* Re: Welcome Luca Cavanna as Lucene committer
>
> Welcome Luca!
>
> On Wed, Oct 5, 2022 at 12:04 PM Adrien Grand  wrote:
>
> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
>
> --
> Adrien
>
> --
> Sent from Gmail Mobile
>

Re: Welcome Luca Cavanna as Lucene committer

[Martin Gainty]

welcome Luca!

From: David Smiley 
Sent: Wednesday, October 5, 2022 2:34 PM
To: dev@lucene.apache.org 
Cc: cavannal...@gmail.com 
Subject: Re: Welcome Luca Cavanna as Lucene committer

Welcome Luca!

On Wed, Oct 5, 2022 at 12:04 PM Adrien Grand 
mailto:jpou...@gmail.com>> wrote:
I'm pleased to announce that Luca Cavanna has accepted the PMC's
invitation to become a committer.

Luca, the tradition is that new committers introduce themselves with a
brief bio.

Congratulations and welcome!


--
Adrien
--
Sent from Gmail Mobile

Re: Welcome Luca Cavanna as Lucene committer

[David Smiley]

Welcome Luca!

On Wed, Oct 5, 2022 at 12:04 PM Adrien Grand  wrote:

> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
>
> --
> Adrien
>
-- 
Sent from Gmail Mobile

Re: Welcome Luca Cavanna as Lucene committer

[Namgyu Kim]

Congratulations and welcome, Luca! :D

On Thu, Oct 6, 2022 at 2:04 AM Adrien Grand  wrote:

> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
> --
> Adrien
>

Re: Welcome Luca Cavanna as Lucene committer

[Alan Woodward]

Congratulations Luca!

> On 5 Oct 2022, at 18:03, Adrien Grand  wrote:
> 
> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
> 
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
> 
> Congratulations and welcome!
> 
> -- 
> Adrien


-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Welcome Luca Cavanna as Lucene committer

[Julie Tibshirani]

Congratulations Luca!!!

On Wed, Oct 5, 2022 at 10:14 AM Dawid Weiss  wrote:

>
> Oh, long overdue - congratulations and welcome, Luca.
>
> Dawid
>
> On Wed, Oct 5, 2022 at 7:04 PM Adrien Grand  wrote:
>
>> I'm pleased to announce that Luca Cavanna has accepted the PMC's
>> invitation to become a committer.
>>
>> Luca, the tradition is that new committers introduce themselves with a
>> brief bio.
>>
>> Congratulations and welcome!
>>
>> --
>> Adrien
>>
>

Re: Welcome Luca Cavanna as Lucene committer

[Dawid Weiss]

Oh, long overdue - congratulations and welcome, Luca.

Dawid

On Wed, Oct 5, 2022 at 7:04 PM Adrien Grand  wrote:

> I'm pleased to announce that Luca Cavanna has accepted the PMC's
> invitation to become a committer.
>
> Luca, the tradition is that new committers introduce themselves with a
> brief bio.
>
> Congratulations and welcome!
>
> --
> Adrien
>

Welcome Luca Cavanna as Lucene committer

[Adrien Grand]

I'm pleased to announce that Luca Cavanna has accepted the PMC's
invitation to become a committer.

Luca, the tradition is that new committers introduce themselves with a
brief bio.

Congratulations and welcome!

-- 
Adrien

Re: Code coverage check for PRs

[Gus Heck]

One thing codecov gives is a sense of what the coverage was previously
without having to go hunt down past builds in jenkins. It is a coverage
focused view essentially. It just uses the coverage data the build already
calculates. It used to have some nifty graphical visualizations but those
seem to have disappeared or become hard to find.

On Wed, Oct 5, 2022 at 9:24 AM Robert Muir  wrote:

> I would recommend a search for "github actions jacoco" to review
> what's common out there.
>
> If we change 'gradle test' to 'gradle coverage' in our existing
> PR-test action, the next step is to just not throw away the reports,
> but make them available. See
>
> https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts
> for some documentation on this.
>
> Seems common for PR workflows to have the action "comment on the PR"
> with coverage information. Not sure if we want that as it could result
> in a ton of comments.
>
> Finally, the current "gradle coverage" builds a separate coverage
> report for each lucene module, I think. So we may want to think about
> adding support to "merge" the jacoco data across all the modules and
> build one monster report for all of lucene, too. This would just be
> some work with the gradle build: but I think it would make the
> information a lot easier to digest. This is already happening with the
> "jenkins coverage build" which presents one monster report, but I
> think it may be something on the jenkins side doing it?
>
> https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastBuild/jacoco/
>
>
> On Wed, Oct 5, 2022 at 8:58 AM Patrick Zhai  wrote:
> >
> > Make sense to me, I'll try to look into it!
> >
> > On Tue, Oct 4, 2022, 16:50 Robert Muir  wrote:
> >>
> >> We already have code coverage integrated into the build. See the
> >> documentation on how to generate the reports:
> >> https://github.com/apache/lucene/blob/main/help/tests.txt
> >>
> >> I think we should stick with jacoco and not some commercial stuff for
> >> measuring coverage. Jacoco works great. We just have to put the
> >> reports or stats somewhere useful.
> >>
> >> On Tue, Oct 4, 2022 at 5:45 PM Patrick Zhai  wrote:
> >> >
> >> > Hi Robert, thank you for commenting, yeah the functionality I want to
> add is actually the line by line code coverage stats for the new/changed
> line that are in the patch so that we don't need to wonder about "whether
> that line is covered by the test?". But I'm against using the code coverage
> as any kind of hard criteria, like coverage must be kept at a certain % or
> all the new lines must be covered, that will drive people crazy. I think
> that should be just treated as a helpful thing to check when
> reviewing/creating the PR.
> >> >
> >> > I searched a little on google and found this:
> https://about.codecov.io/, it's free for open source and seems to have
> the functionality we need. Let me know if anyone has ideas about this, or
> otherwise I can try it a little bit with my own repo first and then try to
> add it to lucene.
> >> >
> >> > Best
> >> > Patrick
> >> >
> >> >
> >> >
> >> > On Tue, Oct 4, 2022, 06:36 Robert Muir  wrote:
> >> >>
> >> >> btw, you can look at the current reports created by jenkins here:
> >> >>
> https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastBuild/jacoco/
> >> >>
> >> >> On Tue, Oct 4, 2022 at 6:51 AM Robert Muir  wrote:
> >> >> >
> >> >> > we can run the tests with coverage option and produce coverage
> graph
> >> >> > from the github actions, but need to look at the docs to see where
> to
> >> >> > put it so it will be available.
> >> >> >
> >> >> > I want us to be careful about the word "check" as I'm adamantly
> >> >> > against any such automated check (e.g. coverage > N%) in the logic.
> >> >> > Coverage report is just a tool to help us and the moment we do
> stupid
> >> >> > shit like that, is the moment people start gaming it just to make
> the
> >> >> > build pass.
> >> >> >
> >> >> > On Mon, Oct 3, 2022 at 10:57 PM Patrick Zhai 
> wrote:
> >> >> > >
> >> >> > > Hi folks,
> >> >> > > I'm not sure whether people have already discussed this but I'm
> wondering whether we want to add a workflow that pulls out the code
> coverage whenever a PR was created? It should be easier for both the
> reviewers and the contributors to figure out what can be improved, or at
> least figure out a part that is probably not covered by the tests?
> >> >> > >
> >> >> > > Best
> >> >> > > Patrick
> >> >>
> >> >> -
> >> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >> >> For additional commands, e-mail: dev-h...@lucene.apache.org
> >> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>
>
> 

Re: Code coverage check for PRs

[Robert Muir]

I would recommend a search for "github actions jacoco" to review
what's common out there.

If we change 'gradle test' to 'gradle coverage' in our existing
PR-test action, the next step is to just not throw away the reports,
but make them available. See
https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts
for some documentation on this.

Seems common for PR workflows to have the action "comment on the PR"
with coverage information. Not sure if we want that as it could result
in a ton of comments.

Finally, the current "gradle coverage" builds a separate coverage
report for each lucene module, I think. So we may want to think about
adding support to "merge" the jacoco data across all the modules and
build one monster report for all of lucene, too. This would just be
some work with the gradle build: but I think it would make the
information a lot easier to digest. This is already happening with the
"jenkins coverage build" which presents one monster report, but I
think it may be something on the jenkins side doing it?
https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastBuild/jacoco/


On Wed, Oct 5, 2022 at 8:58 AM Patrick Zhai  wrote:
>
> Make sense to me, I'll try to look into it!
>
> On Tue, Oct 4, 2022, 16:50 Robert Muir  wrote:
>>
>> We already have code coverage integrated into the build. See the
>> documentation on how to generate the reports:
>> https://github.com/apache/lucene/blob/main/help/tests.txt
>>
>> I think we should stick with jacoco and not some commercial stuff for
>> measuring coverage. Jacoco works great. We just have to put the
>> reports or stats somewhere useful.
>>
>> On Tue, Oct 4, 2022 at 5:45 PM Patrick Zhai  wrote:
>> >
>> > Hi Robert, thank you for commenting, yeah the functionality I want to add 
>> > is actually the line by line code coverage stats for the new/changed line 
>> > that are in the patch so that we don't need to wonder about "whether that 
>> > line is covered by the test?". But I'm against using the code coverage as 
>> > any kind of hard criteria, like coverage must be kept at a certain % or 
>> > all the new lines must be covered, that will drive people crazy. I think 
>> > that should be just treated as a helpful thing to check when 
>> > reviewing/creating the PR.
>> >
>> > I searched a little on google and found this: https://about.codecov.io/, 
>> > it's free for open source and seems to have the functionality we need. Let 
>> > me know if anyone has ideas about this, or otherwise I can try it a little 
>> > bit with my own repo first and then try to add it to lucene.
>> >
>> > Best
>> > Patrick
>> >
>> >
>> >
>> > On Tue, Oct 4, 2022, 06:36 Robert Muir  wrote:
>> >>
>> >> btw, you can look at the current reports created by jenkins here:
>> >> https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastBuild/jacoco/
>> >>
>> >> On Tue, Oct 4, 2022 at 6:51 AM Robert Muir  wrote:
>> >> >
>> >> > we can run the tests with coverage option and produce coverage graph
>> >> > from the github actions, but need to look at the docs to see where to
>> >> > put it so it will be available.
>> >> >
>> >> > I want us to be careful about the word "check" as I'm adamantly
>> >> > against any such automated check (e.g. coverage > N%) in the logic.
>> >> > Coverage report is just a tool to help us and the moment we do stupid
>> >> > shit like that, is the moment people start gaming it just to make the
>> >> > build pass.
>> >> >
>> >> > On Mon, Oct 3, 2022 at 10:57 PM Patrick Zhai  wrote:
>> >> > >
>> >> > > Hi folks,
>> >> > > I'm not sure whether people have already discussed this but I'm 
>> >> > > wondering whether we want to add a workflow that pulls out the code 
>> >> > > coverage whenever a PR was created? It should be easier for both the 
>> >> > > reviewers and the contributors to figure out what can be improved, or 
>> >> > > at least figure out a part that is probably not covered by the tests?
>> >> > >
>> >> > > Best
>> >> > > Patrick
>> >>
>> >> -
>> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> >> For additional commands, e-mail: dev-h...@lucene.apache.org
>> >>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Re: Code coverage check for PRs

[Patrick Zhai]

Make sense to me, I'll try to look into it!

On Tue, Oct 4, 2022, 16:50 Robert Muir  wrote:

> We already have code coverage integrated into the build. See the
> documentation on how to generate the reports:
> https://github.com/apache/lucene/blob/main/help/tests.txt
>
> I think we should stick with jacoco and not some commercial stuff for
> measuring coverage. Jacoco works great. We just have to put the
> reports or stats somewhere useful.
>
> On Tue, Oct 4, 2022 at 5:45 PM Patrick Zhai  wrote:
> >
> > Hi Robert, thank you for commenting, yeah the functionality I want to
> add is actually the line by line code coverage stats for the new/changed
> line that are in the patch so that we don't need to wonder about "whether
> that line is covered by the test?". But I'm against using the code coverage
> as any kind of hard criteria, like coverage must be kept at a certain % or
> all the new lines must be covered, that will drive people crazy. I think
> that should be just treated as a helpful thing to check when
> reviewing/creating the PR.
> >
> > I searched a little on google and found this: https://about.codecov.io/,
> it's free for open source and seems to have the functionality we need. Let
> me know if anyone has ideas about this, or otherwise I can try it a little
> bit with my own repo first and then try to add it to lucene.
> >
> > Best
> > Patrick
> >
> >
> >
> > On Tue, Oct 4, 2022, 06:36 Robert Muir  wrote:
> >>
> >> btw, you can look at the current reports created by jenkins here:
> >>
> https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastBuild/jacoco/
> >>
> >> On Tue, Oct 4, 2022 at 6:51 AM Robert Muir  wrote:
> >> >
> >> > we can run the tests with coverage option and produce coverage graph
> >> > from the github actions, but need to look at the docs to see where to
> >> > put it so it will be available.
> >> >
> >> > I want us to be careful about the word "check" as I'm adamantly
> >> > against any such automated check (e.g. coverage > N%) in the logic.
> >> > Coverage report is just a tool to help us and the moment we do stupid
> >> > shit like that, is the moment people start gaming it just to make the
> >> > build pass.
> >> >
> >> > On Mon, Oct 3, 2022 at 10:57 PM Patrick Zhai 
> wrote:
> >> > >
> >> > > Hi folks,
> >> > > I'm not sure whether people have already discussed this but I'm
> wondering whether we want to add a workflow that pulls out the code
> coverage whenever a PR was created? It should be easier for both the
> reviewers and the contributors to figure out what can be improved, or at
> least figure out a part that is probably not covered by the tests?
> >> > >
> >> > > Best
> >> > > Patrick
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> >> For additional commands, e-mail: dev-h...@lucene.apache.org
> >>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>