Re: Test framework can't find SPI implementations from module sandbox

[Michael Sokolov]

did you add to the sandbox META-INF file? It looks like maybe sandbox is
not included in the scope of the test, but you didn't say which test it
was. Is the test also in the sandbox module?

On Mon, Nov 20, 2023 at 6:56 PM Dongyu Xu  wrote:

> Hi devs,
>
> I tried to plug in my experimental PostingsFormat implementation to all
> the existing unit tests. I've registered it under META-INF.services as well
> as in the moudle-info.java. However, the test still fails like the
> following.
>
> java.lang.IllegalArgumentException: An SPI class of type
> org.apache.lucene.codecs.PostingsFormat with name 'Lucene99RandomAccess'
> does not exist.  You need to add the corresponding JAR file supporting this
> SPI to your classpath.  The current classpath supports the following names:
> [Lucene99, MockRandom, RAMOnly, LuceneFixedGap, LuceneVarGapFixedInterval,
> LuceneVarGapDocFreqInterval, TestBloomFilteredLucenePostings, Asserting,
> UniformSplitRot13, STUniformSplitRot13, BlockTreeOrds, BloomFilter, Direct,
> FST50, UniformSplit, SharedTermsUniformSplit, Lucene50, Lucene84, Lucene90]
>
> It fails to recognize the one of the existing PostingsFormat, IDVersion
> ,
> from sandbox, too.
>
> Is this a known issue?
>
> Tony X
>
>
>
>
>

Re: Lucene 9.9.0 Release

[Patrick Zhai]

+1, thank you Chris!

On Tue, Nov 21, 2023, 06:49 Benjamin Trent  wrote:

> +1 9.9 will be a stellar release!
>
> Thank you Chris!
>
> On Tue, Nov 21, 2023 at 7:31 AM Adrien Grand  wrote:
>
>> +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a
>> RM, Chris.
>>
>> It would be good to try and fix the PKLookup regression that was
>> introduced since 9.8:
>> http://people.apache.org/~mikemccand/lucenebench/PKLookup.html. Is it
>> just about getting #12699 
>> merged?
>>
>> Separately, I have a PR that does a small change to the file format of
>> postings and skip lists. It's certainly not a blocker for 9.9, but it would
>> be convenient to get it into 9.9 since we already changed file formats for
>> the switch from PFOR to FOR. Does someone have time to take a look?
>> #12810 
>>
>> On Tue, Nov 21, 2023 at 11:16 AM Michael McCandless <
>> luc...@mikemccandless.com> wrote:
>>
>>> +1
>>>
>>> Thank you for volunteering as RC Chris!
>>>
>>> Mike McCandless
>>>
>>> http://blog.mikemccandless.com
>>>
>>>
>>> On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty
>>>  wrote:
>>>
 Hi,

 It's been a while since the 9.8.0 release and we’ve accumulated quite a
 few changes. I’d like to propose that we release 9.9.0.

 If there's no objections, I volunteer to be the release manager and
 will cut the feature branch a week from now, 12:00 28th Nov UTC.

 -Chris.
 -
 To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
 For additional commands, e-mail: dev-h...@lucene.apache.org


>>
>> --
>> Adrien
>>
>

Re: Lucene 9.9.0 Release

[Benjamin Trent]

+1 9.9 will be a stellar release!

Thank you Chris!

On Tue, Nov 21, 2023 at 7:31 AM Adrien Grand  wrote:

> +1 9.9 has plenty of great changes indeed! Thanks for volunteering as a
> RM, Chris.
>
> It would be good to try and fix the PKLookup regression that was
> introduced since 9.8:
> http://people.apache.org/~mikemccand/lucenebench/PKLookup.html. Is it
> just about getting #12699 
> merged?
>
> Separately, I have a PR that does a small change to the file format of
> postings and skip lists. It's certainly not a blocker for 9.9, but it would
> be convenient to get it into 9.9 since we already changed file formats for
> the switch from PFOR to FOR. Does someone have time to take a look? #12810
> 
>
> On Tue, Nov 21, 2023 at 11:16 AM Michael McCandless <
> luc...@mikemccandless.com> wrote:
>
>> +1
>>
>> Thank you for volunteering as RC Chris!
>>
>> Mike McCandless
>>
>> http://blog.mikemccandless.com
>>
>>
>> On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty
>>  wrote:
>>
>>> Hi,
>>>
>>> It's been a while since the 9.8.0 release and we’ve accumulated quite a
>>> few changes. I’d like to propose that we release 9.9.0.
>>>
>>> If there's no objections, I volunteer to be the release manager and will
>>> cut the feature branch a week from now, 12:00 28th Nov UTC.
>>>
>>> -Chris.
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>>
>>>
>
> --
> Adrien
>

Re: Lucene 9.9.0 Release

[Adrien Grand]

+1 9.9 has plenty of great changes indeed! Thanks for volunteering as a RM,
Chris.

It would be good to try and fix the PKLookup regression that was introduced
since 9.8: http://people.apache.org/~mikemccand/lucenebench/PKLookup.html.
Is it just about getting #12699
 merged?

Separately, I have a PR that does a small change to the file format of
postings and skip lists. It's certainly not a blocker for 9.9, but it would
be convenient to get it into 9.9 since we already changed file formats for
the switch from PFOR to FOR. Does someone have time to take a look? #12810


On Tue, Nov 21, 2023 at 11:16 AM Michael McCandless <
luc...@mikemccandless.com> wrote:

> +1
>
> Thank you for volunteering as RC Chris!
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty
>  wrote:
>
>> Hi,
>>
>> It's been a while since the 9.8.0 release and we’ve accumulated quite a
>> few changes. I’d like to propose that we release 9.9.0.
>>
>> If there's no objections, I volunteer to be the release manager and will
>> cut the feature branch a week from now, 12:00 28th Nov UTC.
>>
>> -Chris.
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
>> For additional commands, e-mail: dev-h...@lucene.apache.org
>>
>>

-- 
Adrien

Re: Lucene 9.9.0 Release

[Michael McCandless]

+1

Thank you for volunteering as RC Chris!

Mike McCandless

http://blog.mikemccandless.com


On Tue, Nov 21, 2023 at 4:52 AM Chris Hegarty
 wrote:

> Hi,
>
> It's been a while since the 9.8.0 release and we’ve accumulated quite a
> few changes. I’d like to propose that we release 9.9.0.
>
> If there's no objections, I volunteer to be the release manager and will
> cut the feature branch a week from now, 12:00 28th Nov UTC.
>
> -Chris.
> -
> To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
> For additional commands, e-mail: dev-h...@lucene.apache.org
>
>

Lucene 9.9.0 Release

[Chris Hegarty]

Hi,

It's been a while since the 9.8.0 release and we’ve accumulated quite a few 
changes. I’d like to propose that we release 9.9.0.

If there's no objections, I volunteer to be the release manager and will cut 
the feature branch a week from now, 12:00 28th Nov UTC.

-Chris.
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org