[jira] [Created] (SOLR-8755) Add test cases for org.apache.solr.parser.TokenMgrError
Benoit Vanalderweireldt created SOLR-8755: - Summary: Add test cases for org.apache.solr.parser.TokenMgrError Key: SOLR-8755 URL: https://issues.apache.org/jira/browse/SOLR-8755 Project: Solr Issue Type: Test Affects Versions: master Reporter: Benoit Vanalderweireldt Priority: Trivial Fix For: master Add test cases for org.apache.solr.parser.TokenMgrError -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7516) Improve javadocs for JavaBinCodec, ObjectResolver and enforce the single-usage policy
[ https://issues.apache.org/jira/browse/SOLR-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170842#comment-15170842 ] Benoit Vanalderweireldt commented on SOLR-7516: --- I'm looking at your patch and will add test cases and comments then will push it for you. > Improve javadocs for JavaBinCodec, ObjectResolver and enforce the > single-usage policy > - > > Key: SOLR-7516 > URL: https://issues.apache.org/jira/browse/SOLR-7516 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Shalin Shekhar Mangar >Priority: Minor > Labels: difficulty-easy, newdev > Fix For: 5.2, master > > Attachments: SOLR-7516.patch > > > The Javadocs of this class can use some improvements. It doesn't adequately > describe the purpose of the ObjectResolver. Also, since it says that this > object should be used only once for marshalling or unmarshalling operation, > we should enforce it in code via asserts and/or exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-8754) Adding test cases for org.apache.solr.util.hll.NumberUtilTest
Benoit Vanalderweireldt created SOLR-8754: - Summary: Adding test cases for org.apache.solr.util.hll.NumberUtilTest Key: SOLR-8754 URL: https://issues.apache.org/jira/browse/SOLR-8754 Project: Solr Issue Type: Improvement Components: Tests Reporter: Benoit Vanalderweireldt Priority: Trivial Added test cases for org.apache.solr.util.hll.NumberUtilTest : - NumberUtil.log2 - NumberUtil.toHex - NumberUtil.fromHex -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-7516) Improve javadocs for JavaBinCodec, ObjectResolver and enforce the single-usage policy
[ https://issues.apache.org/jira/browse/SOLR-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170705#comment-15170705 ] Benoit Vanalderweireldt edited comment on SOLR-7516 at 2/27/16 7:50 PM: I would love to step in and improve the ObjectResolver (javadoc + assertion errors) was (Author: b.vanalderweireldt): I would love to step in and improve the ObjectResolver > Improve javadocs for JavaBinCodec, ObjectResolver and enforce the > single-usage policy > - > > Key: SOLR-7516 > URL: https://issues.apache.org/jira/browse/SOLR-7516 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Shalin Shekhar Mangar >Priority: Minor > Labels: difficulty-easy, newdev > Fix For: 5.2, master > > Attachments: SOLR-7516.patch > > > The Javadocs of this class can use some improvements. It doesn't adequately > describe the purpose of the ObjectResolver. Also, since it says that this > object should be used only once for marshalling or unmarshalling operation, > we should enforce it in code via asserts and/or exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-7516) Improve javadocs for JavaBinCodec, ObjectResolver and enforce the single-usage policy
[ https://issues.apache.org/jira/browse/SOLR-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15170705#comment-15170705 ] Benoit Vanalderweireldt commented on SOLR-7516: --- I would love to step in and improve the ObjectResolver > Improve javadocs for JavaBinCodec, ObjectResolver and enforce the > single-usage policy > - > > Key: SOLR-7516 > URL: https://issues.apache.org/jira/browse/SOLR-7516 > Project: Solr > Issue Type: Improvement > Components: search >Reporter: Shalin Shekhar Mangar >Priority: Minor > Labels: difficulty-easy, newdev > Fix For: 5.2, master > > Attachments: SOLR-7516.patch > > > The Javadocs of this class can use some improvements. It doesn't adequately > describe the purpose of the ObjectResolver. Also, since it says that this > object should be used only once for marshalling or unmarshalling operation, > we should enforce it in code via asserts and/or exceptions. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-4042) NullPointerException for query type 'query' without '{! ...}' syntax
[
https://issues.apache.org/jira/browse/SOLR-4042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15166722#comment-15166722
]
Benoit Vanalderweireldt commented on SOLR-4042:
---
I would think a syntax error is more appropriate.
First message for me here, i'm not sure about the process, but I'd love to
fix this one as a start.
> NullPointerException for query type 'query' without '{! ...}' syntax
>
>
> Key: SOLR-4042
> URL: https://issues.apache.org/jira/browse/SOLR-4042
> Project: Solr
> Issue Type: Bug
> Components: query parsers
>Affects Versions: 4.0, master
>Reporter: Joel Nothman
>Priority: Minor
>
> The 'query' query type, corresponding to NestedQParserPlugin, expects a query
> of form: "{! ... } ...". An empty q parameter, or a list of search terms
> causes a NullPointerException because NestedQParserPlugin.createParser
> receives a localParams == null, which is then used without checking in
> NestedQParserPlugin.QParser.parse().
> Correct behaviour is currently ambiguous: throw a syntax error? or execute
> the query with the default parser?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
