[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202165#comment-14202165 ] Cyrille Roy commented on SOLR-2927: --- the deadlock in our 4_2 branch occurs when doing infoRegistry.clear(); after closeSearcher(). I'll integrate taking this into account. Thanks again [~shalinmangar] for the great work and feedback. SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14202165#comment-14202165 ] Cyrille Roy edited comment on SOLR-2927 at 11/7/14 3:40 PM: the deadlock in our 4_2 branch occurs when doing infoRegistry.clear(); after closeSearcher(). I'll integrate the patch taking this into account. Thanks again [~shalinmangar] for the great work and feedback. was (Author: croy): the deadlock in our 4_2 branch occurs when doing infoRegistry.clear(); after closeSearcher(). I'll integrate taking this into account. Thanks again [~shalinmangar] for the great work and feedback. SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Attachment: (was: SOLR-2927.patch) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198385#comment-14198385 ] Cyrille Roy commented on SOLR-2927: --- I removed the initial patch I provided as [~shalinmangar] enriched it for branch_5X SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198625#comment-14198625 ] Cyrille Roy commented on SOLR-2927: --- [~shalinmangar] I have some questions regarding the patch you provided. 1. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the path I proposed in fact. I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198625#comment-14198625 ] Cyrille Roy edited comment on SOLR-2927 at 11/5/14 4:56 PM: [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the path I proposed in fact. I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks was (Author: croy): [~shalinmangar] I have some questions regarding the patch you provided. 1. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the path I proposed in fact. I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198625#comment-14198625 ] Cyrille Roy edited comment on SOLR-2927 at 11/5/14 4:57 PM: [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the patch I proposed in fact (without the JMX update) I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks was (Author: croy): [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the patch I proposed in fact (without the JMX update) I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198625#comment-14198625 ] Cyrille Roy edited comment on SOLR-2927 at 11/5/14 4:56 PM: [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the patch I proposed in fact (without the JMX update) I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks was (Author: croy): [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the path I proposed in fact. I think it might be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Comment: was deleted (was: [~shalinmangar] I have some questions regarding the patch you provided. I synced the trunk code and have some failures. I don't know how to check for trunk status other that rebuilding it (I did not find an url where we can check for trunk status) I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. This is the patch I proposed in fact (without the JMX update) I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198667#comment-14198667 ] Cyrille Roy commented on SOLR-2927: --- hi [~shalinmangar] I have some questions regarding the patch you provided. I backported the fix into branch_4_2 have some test failures. I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198667#comment-14198667 ] Cyrille Roy edited comment on SOLR-2927 at 11/5/14 5:14 PM: hi [~shalinmangar] I have some questions regarding the patch you provided. I backported the fix into branch_4_2 and have some test failures. I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks was (Author: croy): hi [~shalinmangar] I have some questions regarding the patch you provided. I backported the fix into branch_4_2 have some test failures. I updated the patch to have right after the closeHooks (line 1070) - ExecutorUtil.shutdown.AndAwaitTermination block - infoRegistry block With that, I have no more failures. I wonder if it would be better to wait for searcherExecutor shutdown sooner than later because this thread can keep on doing some work whereas we are supposed to close the core. Thanks SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14198750#comment-14198750 ] Cyrille Roy commented on SOLR-2927: --- [junit4:junit4] Tests with failures (first 10 out of 11): [junit4:junit4] - org.apache.solr.MinimalSchemaTest (suite) [junit4:junit4] - org.apache.solr.cloud.SyncSliceTest (suite) [junit4:junit4] - org.apache.solr.cloud.UnloadDistributedZkTest (suite) [junit4:junit4] - org.apache.solr.cloud.AliasIntegrationTest (suite) [junit4:junit4] - org.apache.solr.cloud.BasicDistributedZk2Test (suite) [junit4:junit4] - org.apache.solr.cloud.FullSolrCloudDistribCmdsTest (suite) [junit4:junit4] - org.apache.solr.cloud.CollectionsAPIDistributedZkTest (suite) [junit4:junit4] - org.apache.solr.cloud.ShardRoutingTest (suite) [junit4:junit4] - org.apache.solr.cloud.RecoveryZkTest (suite) [junit4:junit4] - org.apache.solr.handler.admin.ShowFileRequestHandlerTest (suite) [junit4:junit4] [junit4:junit4] [junit4:junit4] JVM J0: 2.84 .. 890.21 = 887.37s [junit4:junit4] JVM J1: 2.84 .. 767.84 = 765.00s [junit4:junit4] JVM J2: 2.84 .. 881.17 = 878.34s [junit4:junit4] JVM J3: 3.09 .. 768.09 = 765.01s [junit4:junit4] Execution time total: 14 minutes 50 seconds [junit4:junit4] Tests summary: 272 suites, 1148 tests, 11 suite-level errors, 14 ignored (2 assumptions) I have often this stack: [junit4:junit4] 2 69753 T293 oasc.JmxMonitoredMap$SolrDynamicMBean.getMBeanInfo WARNING Could not getStatistics on info bean org.apache.solr.search.SolrIndexSearcher org.apache.lucene.store.AlreadyClosedException: this IndexReader is closed this is a warning, but it is a class updated by the patch so mentioning it. SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196075#comment-14196075 ] Cyrille Roy commented on SOLR-2927: --- great, thanks [~shalinmangar]. I tested the fix I provided against solr-4.2 branch, maybe that's why I did not have the 2 extra leaking mbeans. SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk Attachments: SOLR-2927.patch, SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14196344#comment-14196344 ] Cyrille Roy commented on SOLR-2927: --- Thanks a lot [~shalinmangar] SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 5.0, Trunk Attachments: SOLR-2927.patch, SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[
https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195270#comment-14195270
]
Cyrille Roy commented on SOLR-2927:
---
hi [~shalinmangar],
this is great news.
I have some of the mbeans leaking in the attached mbean-jira-leaked.png that I
have attached.
Also, I have been able to fix the leak with the SOLR-2927.patch attached.
Do you still see the leaking mbeans after applying the patch ?
The issue is a race condition.
when opening a core, solr is preventing searchers from firing by starting a
thread that blocks in a single threaded executor at line 783:
searcherExecutor.submit(new Callable() {
@Override
public Object call() throws Exception {
latch.await();
return null;
}
});
Other events are queued using the thread executor line 864 when calling the
getSearcher(false, false, null, true) method
on exception, the latch is released, so searcher threads can fire and write
things in the mbean using the infoRegistry map.
} catch (Throwable e) {
latch.countDown();//release the latch, otherwise we block trying to do the
close. This should be fine, since counting down on a latch of 0 is still fine
//close down the searcher and any other resources, if it exists, as this is not
recoverable
close();
And indeed it is what is happening in close()
we clean the mbean at line 990
try {
infoRegistry.clear();
} catch (Throwable e) {
SolrException.log(log, e);
}
and then wait for searcher thread completion at line 1070
try {
ExecutorUtil.shutdownAndAwaitTermination(searcherExecutor);
} catch (Throwable e) {
SolrException.log(log, e);
}
putting this before the registry clean actually solves the issue.
SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
Key: SOLR-2927
URL: https://issues.apache.org/jira/browse/SOLR-2927
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 4.0-ALPHA
Environment: JDK1.6/CentOS
Reporter: tom liu
Assignee: Shalin Shekhar Mangar
Fix For: 4.9, Trunk
Attachments: SOLR-2927.patch, mbean-leak-jira.png
# SolrIndexSearcher's register method put the name of searcher, but
SolrCore's closeSearcher method remove name of currentSearcher on
infoRegistry.
# SolrIndexSearcher's register method put the name of cache, but
SolrIndexSearcher's close do not remove the name of cache.
so, there maybe lost some memory leak.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[
https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14195270#comment-14195270
]
Cyrille Roy edited comment on SOLR-2927 at 11/3/14 10:57 PM:
-
hi [~shalinmangar],
this is great news.
I have some of the mbeans leaking in the attached mbean-jira-leaked.png that I
have attached.
Also, I have been able to fix the leak with the SOLR-2927.patch attached.
Do you still see the leaking mbeans after applying the patch ?
The issue is a race condition.
when opening a core, solr is preventing searchers from firing by starting a
thread that blocks in a single threaded executor at line 783:
searcherExecutor.submit(new Callable() {
@Override
public Object call() throws Exception {
latch.await();
return null;
}
});
Other events are queued using the thread executor line 864 when calling the
getSearcher(false, false, null, true) method.
getSearcher calls registerSearcher which calls register which registers mbeans
using the getInfoRegistry().put(key, value) method
on exception, the latch is released, so searcher threads can fire and write
things in the mbean using the infoRegistry map.
} catch (Throwable e) {
latch.countDown();//release the latch, otherwise we block trying to do the
close. This should be fine, since counting down on a latch of 0 is still fine
//close down the searcher and any other resources, if it exists, as this is not
recoverable
close();
And indeed it is what is happening in close()
we clean the mbean at line 990
try {
infoRegistry.clear();
} catch (Throwable e) {
SolrException.log(log, e);
}
and then wait for searcher thread completion at line 1070
try {
ExecutorUtil.shutdownAndAwaitTermination(searcherExecutor);
} catch (Throwable e) {
SolrException.log(log, e);
}
putting this before the registry clean actually solves the issue.
was (Author: croy):
hi [~shalinmangar],
this is great news.
I have some of the mbeans leaking in the attached mbean-jira-leaked.png that I
have attached.
Also, I have been able to fix the leak with the SOLR-2927.patch attached.
Do you still see the leaking mbeans after applying the patch ?
The issue is a race condition.
when opening a core, solr is preventing searchers from firing by starting a
thread that blocks in a single threaded executor at line 783:
searcherExecutor.submit(new Callable() {
@Override
public Object call() throws Exception {
latch.await();
return null;
}
});
Other events are queued using the thread executor line 864 when calling the
getSearcher(false, false, null, true) method
on exception, the latch is released, so searcher threads can fire and write
things in the mbean using the infoRegistry map.
} catch (Throwable e) {
latch.countDown();//release the latch, otherwise we block trying to do the
close. This should be fine, since counting down on a latch of 0 is still fine
//close down the searcher and any other resources, if it exists, as this is not
recoverable
close();
And indeed it is what is happening in close()
we clean the mbean at line 990
try {
infoRegistry.clear();
} catch (Throwable e) {
SolrException.log(log, e);
}
and then wait for searcher thread completion at line 1070
try {
ExecutorUtil.shutdownAndAwaitTermination(searcherExecutor);
} catch (Throwable e) {
SolrException.log(log, e);
}
putting this before the registry clean actually solves the issue.
SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
Key: SOLR-2927
URL: https://issues.apache.org/jira/browse/SOLR-2927
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 4.0-ALPHA
Environment: JDK1.6/CentOS
Reporter: tom liu
Assignee: Shalin Shekhar Mangar
Fix For: 4.9, Trunk
Attachments: SOLR-2927.patch, mbean-leak-jira.png
# SolrIndexSearcher's register method put the name of searcher, but
SolrCore's closeSearcher method remove name of currentSearcher on
infoRegistry.
# SolrIndexSearcher's register method put the name of cache, but
SolrIndexSearcher's close do not remove the name of cache.
so, there maybe lost some memory leak.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188484#comment-14188484 ] Cyrille Roy edited comment on SOLR-2927 at 10/29/14 3:53 PM: - I have been able to reproduce this issue patching the code to throw an exception in SolrCore in branch 4_2 in constructor line 875 ... resourceLoader.inform(resourceLoader); //DO NOT COMMIT THIS: if(!metadata.equals(name)) throw new RuntimeException(test exception); ... you can then curl any core $curl http://localhost:xxx/solr/CORE_NAME/select?q=*:*; open a jconsole and you will see the leaking mbean named solr/CORE_NAME was (Author: croy): I have able to reproduce this issue patching the code to throw an exception in SolrCore in branch 4_2 in constructor line 875 ... resourceLoader.inform(resourceLoader); //DO NOT COMMIT THIS: if(!metadata.equals(name)) throw new RuntimeException(test exception); ... you can then curl any core $curl http://localhost:xxx/solr/CORE_NAME/select?q=*:*; open a jconsole and you will see the leaking mbean named solr/CORE_NAME SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188484#comment-14188484 ] Cyrille Roy commented on SOLR-2927: --- I have able to reproduce this issue patching the code to throw an exception in SolrCore in branch 4_2 in constructor line 875 ... resourceLoader.inform(resourceLoader); //DO NOT COMMIT THIS: if(!metadata.equals(name)) throw new RuntimeException(test exception); ... you can then curl any core $curl http://localhost:xxx/solr/CORE_NAME/select?q=*:*; open a jconsole and you will see the leaking mbean named solr/CORE_NAME SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Attachment: mbean-leak.png SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk Attachments: mbean-leak.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Attachment: (was: mbean-leak.png) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Attachment: mbean-leak-jira.png SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk Attachments: mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cyrille Roy updated SOLR-2927: -- Attachment: SOLR-2927.patch proposed patch: in SolrCore.close() start with waiting for searcherExecutor and then empty the infoRegistry which will unregister the mbean SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-2927) SolrIndexSearcher's register do not match close and SolrCore's closeSearcher
[ https://issues.apache.org/jira/browse/SOLR-2927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14188495#comment-14188495 ] Cyrille Roy edited comment on SOLR-2927 at 10/29/14 4:16 PM: - proposed patch: in SolrCore.close() start with waiting for searcherExecutor and then empty the infoRegistry which will unregister the mbean. Patch is built against trunk Please let me know if it is not the right version to build a patch. was (Author: croy): proposed patch: in SolrCore.close() start with waiting for searcherExecutor and then empty the infoRegistry which will unregister the mbean SolrIndexSearcher's register do not match close and SolrCore's closeSearcher Key: SOLR-2927 URL: https://issues.apache.org/jira/browse/SOLR-2927 Project: Solr Issue Type: Bug Components: search Affects Versions: 4.0-ALPHA Environment: JDK1.6/CentOS Reporter: tom liu Assignee: Shalin Shekhar Mangar Fix For: 4.9, Trunk Attachments: SOLR-2927.patch, mbean-leak-jira.png # SolrIndexSearcher's register method put the name of searcher, but SolrCore's closeSearcher method remove name of currentSearcher on infoRegistry. # SolrIndexSearcher's register method put the name of cache, but SolrIndexSearcher's close do not remove the name of cache. so, there maybe lost some memory leak. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
