[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13554274#comment-13554274 ] Danny Dvinov commented on SOLR-3039: Thank you, [~otis] and [~tomasflobbe], looked at Tomas' patch, and looks like it pretty much covers everything I was suggesting (and further improves the refactoring!). The only thing we won't be able to do out of the box is decide on whether or not a particular clause should be included/excluded while in splitIntoClauses (includeClause method from this suggested patch), but I suppose this is minor, and we could either override entire splitIntoClauses or just apply a minor patch to accomplish this. Thank you for looking into this! ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Closed] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Dvinov closed SOLR-3039. -- Resolution: Duplicate Fix Version/s: 4.1 ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 4.1, 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Issue Comment Deleted] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Dvinov updated SOLR-3039: --- Comment: was deleted (was: All comments are more than welcome btw!) ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13553382#comment-13553382 ] Danny Dvinov commented on SOLR-3039: Please feel free to make comments/suggestions! ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13483476#comment-13483476 ] Danny Dvinov commented on SOLR-3039: All comments are more than welcome btw! ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[ https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Danny Dvinov updated SOLR-3039: --- Component/s: (was: Schema and Analysis) query parsers Fix Version/s: (was: 4.1) 5.0 Labels: edismax parser parsing (was: edismax multi-token parser parsing phrase synonyms wildcard) Description: ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. (was: ExtendedDismaxQParser.parse does not currently allow for query pre-processing prior to its parsing routine. Provide a way for Solr implementations to pre-process the query whenever needed. This can be useful when query needs to be adjusted to account for things like expanding wildcarded terms within phrase queries, processing terms to allow multi-token synonym matches (in cases when no index-time synonym filtering is done), and whatever other cases that could benefit from altering the query prior to parsing.) Affects Version/s: (was: 4.0-ALPHA) 5.0 Summary: ExtendedDismaxQParser should allow for extension of parsing-related behavior (was: ExtendedDismaxQParser should allow pre-processing of the user query prior to parsing) ExtendedDismaxQParser should allow for extension of parsing-related behavior Key: SOLR-3039 URL: https://issues.apache.org/jira/browse/SOLR-3039 Project: Solr Issue Type: Improvement Components: query parsers Affects Versions: 5.0 Reporter: Danny Dvinov Priority: Minor Labels: edismax, parser, parsing Fix For: 5.0 Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch Original Estimate: 24h Remaining Estimate: 24h ExtendedDismaxQParser.parse does not currently allow for things like query pre-processing prior to its parsing, specifying the parser to be used, and whether particular clause should be included in the query being parsed. Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot be subclassed. By resolving this issue, we'll provide a way for Solr implementations to extend the parser and parsing related behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-3039) ExtendedDismaxQParser should allow for extension of parsing-related behavior
[
https://issues.apache.org/jira/browse/SOLR-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Danny Dvinov updated SOLR-3039:
---
Attachment: SOLR-3039.patch
Changes include:
- Making ExtendedDismaxQParser public to allow implementations that can extend
it (and pulling it out into a separate file, ExtendedDismaxQParser.java).
- Making ExtendedSolrQueryParser protected to allow to allow implementations
that can extend it.
- Introducing 3 protected methods on ExtendedDismaxQParser to allow
implementations that extend ExtendedDismaxQParser to override some of the
behavior:
1. ExtendedSolrQueryParser getQueryParser to allow specifying the parser used
to parse the query.
2. boolean includeClause(Clause clause) to allow overriding whether given
clause should be part of the {@link org.apache.lucene.search.Query} being
parsed.
3. String preProcessUserQuery(String queryString) to allow pre-processing the
query string prior to parsing.
ExtendedDismaxQParser should allow for extension of parsing-related behavior
Key: SOLR-3039
URL: https://issues.apache.org/jira/browse/SOLR-3039
Project: Solr
Issue Type: Improvement
Components: query parsers
Affects Versions: 5.0
Reporter: Danny Dvinov
Priority: Minor
Labels: edismax, parser, parsing
Fix For: 5.0
Attachments: SOLR-3039.patch, SOLR-3039.patch, SOLR-3039.patch,
SOLR-3039.patch
Original Estimate: 24h
Remaining Estimate: 24h
ExtendedDismaxQParser.parse does not currently allow for things like query
pre-processing prior to its parsing, specifying the parser to be used, and
whether particular clause should be included in the query being parsed.
Furthermore, ExtendedDismaxQParser and inner ExtendedSolrQueryParser cannot
be subclassed. By resolving this issue, we'll provide a way for Solr
implementations to extend the parser and parsing related behavior.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
