[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657890#comment-16657890 ] Kamuela Lau commented on SOLR-12785: Deleted old patches and added new ones to reflect the fact that Leaky Relu and TanH were added in SOLR-12780. A-patch adds tests without changing the implementation of default Activation implementations (via a network with exactly one input and one output node). B-patch changes implementation of default Activation implementations and adds tests for that. > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785-A.patch, SOLR-12785-B.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: SOLR-12785-B.patch > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785-A.patch, SOLR-12785-B.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: SOLR-12785-A.patch > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785-A.patch, SOLR-12785-B.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: (was: SOLR-12785.patch) > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: (was: test-no-activation-change.txt) > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646719#comment-16646719
]
Kamuela Lau edited comment on SOLR-12367 at 10/12/18 3:09 AM:
--
A similar ClassCastException may show up for other LTRScoringModels such as
NeuralNetworkModel (in particular, thinking of matrix/bias values for layers).
The ambiguous message for CCE will only change for LinearModel as of right now.
was (Author: kamulau):
A similar ClassCastException may show up for other LTRScoringModels (such as
entering an int/long in matrix, ), such as NeuralNetworkModel (in particular,
thinking of matrix/bias values for layers). The ambiguous message for CCE will
only change for LinearModel as of right now.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12780) Add support for Leaky ReLU and TanH activations in LTR contrib module
[ https://issues.apache.org/jira/browse/SOLR-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16647342#comment-16647342 ] Kamuela Lau commented on SOLR-12780: Thanks [~cpoerschke] for the comment and updated patch! I had no idea that Math.tanh exists in Java itself; intriguing indeed! I think that you are right; there are fewer Math.exp calls, and the use of Math.tanh is also more succinct and easier to understand. > Add support for Leaky ReLU and TanH activations in LTR contrib module > - > > Key: SOLR-12780 > URL: https://issues.apache.org/jira/browse/SOLR-12780 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Labels: ltr > Attachments: SOLR-12780.patch, SOLR-12780.patch > > > Add support for Leaky ReLU and TanH activation functions in > NeuralNetworkModel. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646719#comment-16646719
]
Kamuela Lau edited comment on SOLR-12367 at 10/11/18 4:26 PM:
--
A similar ClassCastException may show up for other LTRScoringModels (such as
entering an int/long in matrix, ), such as NeuralNetworkModel (in particular,
thinking of matrix/bias values for layers). The ambiguous message for CCE will
only change for LinearModel as of right now.
was (Author: kamulau):
A similar ClassCastException may show up for other LTRScoringModels (such as
entering an int/long in matrix, ), such as NeuralNetworkModel (in particular,
thinking of matrix/bias values for layers). Current patch will not change the
ambiguous message for NeuralNetworkModel...
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646719#comment-16646719
]
Kamuela Lau commented on SOLR-12367:
A similar ClassCastException may show up for other LTRScoringModels (such as
entering an int/long in matrix, ), such as NeuralNetworkModel (in particular,
thinking of matrix/bias values for layers). Current patch will not change the
ambiguous message for NeuralNetworkModel...
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16646707#comment-16646707 ] Kamuela Lau commented on SOLR-12785: If changes are accepted for additional activation functions (SOLR-12780), the test in the patch should be changed accordingly; if the tests (and edited implementation of default activation functions) is accepted here, the implementation of the activation functions in SOLR-12780 will have to change accordingly. > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642833#comment-16642833
]
Kamuela Lau edited comment on SOLR-12367 at 10/9/18 6:09 AM:
-
The new patch moved the "weights" params check to LinearModel, instead of
LTRScoringModel, as the weights param only exists for LinearModel, and is
modified so tests will pass
was (Author: kamulau):
The new patch moved the "weights" params check to LinearModel, instead of
LTRScoringModel, as the weights param only exists for LinearModel.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: SOLR-12367.patch
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: (was: SOLR-12367.patch)
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642833#comment-16642833
]
Kamuela Lau commented on SOLR-12367:
The new patch moved the "weights" params check to LinearModel, instead of
LTRScoringModel, as the weights param only exists for LinearModel.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: SOLR-12367.patch
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: (was: SOLR-12367.patch)
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: SOLR-12367.patch
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642809#comment-16642809
]
Kamuela Lau commented on SOLR-12367:
I have attached a new patch, which includes some minor refractoring from the
old patch, as well as a "fix" for the issue noted in the comments; there is now
a different error message for the case when an int/long is entered in weights
instead of a float/double.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: SOLR-12367.patch
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch, SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631637#comment-16631637
]
Kamuela Lau edited comment on SOLR-12367 at 9/28/18 9:54 AM:
-
I have attached a patch to address the issue in the description. The message
will now say "org.apache.solr.ltr.model.ModelException: Features cannot be
null; perhaps check for missing features". To reproduce, follow the same
procedure as described in the description.
For now, I have not dealt with the ClassCastException that shows up in the
comment (i.e. upload features, then execute above) for casting a Long to a
Double, however should this be deemed necessary, I can add that to the patch,
or create another issue for it.
This should also close 12676, and (maybe?) 12676.
Any comments would be appreciated.
was (Author: kamulau):
I have attached a patch to address the issue in the description. The message
will now say "org.apache.solr.ltr.model.ModelException: Features cannot be
null; perhaps check for missing features". To reproduce, follow the same
procedure as described in the description.
For now, I have not dealt with the ClassCastException that shows up in the
comment (i.e. upload features, then execute above) for casting a Long to a
Double, however should this be deemed necessary, I can add that to the patch,
or create another issue for it.
Any comments would be appreciated.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16631637#comment-16631637
]
Kamuela Lau commented on SOLR-12367:
I have attached a patch to address the issue in the description. The message
will now say "org.apache.solr.ltr.model.ModelException: Features cannot be
null; perhaps check for missing features". To reproduce, follow the same
procedure as described in the description.
For now, I have not dealt with the ClassCastException that shows up in the
comment (i.e. upload features, then execute above) for casting a Long to a
Double, however should this be deemed necessary, I can add that to the patch,
or create another issue for it.
Any comments would be appreciated.
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12367) When adding a model referencing a non-existent feature the error message is very ambiguous
[
https://issues.apache.org/jira/browse/SOLR-12367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamuela Lau updated SOLR-12367:
---
Attachment: SOLR-12367.patch
> When adding a model referencing a non-existent feature the error message is
> very ambiguous
> --
>
> Key: SOLR-12367
> URL: https://issues.apache.org/jira/browse/SOLR-12367
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: contrib - LTR
>Affects Versions: 7.3.1
>Reporter: Georg Sorst
>Priority: Minor
> Attachments: SOLR-12367.patch
>
>
> When adding a model that references a non-existent feature a very ambiguous
> error message is thrown, something like "Model type does not exist
> org.apache.solr.ltr.model.{{LinearModel}}".
>
> To reproduce, do not add any features and just add a model, for example by
> doing this:
>
> {{curl -XPUT 'http://localhost:8983/solr/gettingstarted/schema/model-store'
> --data-binary '}}
> {
> {{ "class": "org.apache.solr.ltr.model.LinearModel",}}
> {{ "name": "myModel",}}
> {{ "features": [ \{"name": "whatever" }],}}
> {{ "params": {"weights": {"whatever": 1.0
> {{}' -H 'Content-type:application/json'}}
>
> The resulting error message "Model type does not exist
> {{org.apache.solr.ltr.model.LinearModel" is extremely misleading and cost me
> a while to figure out the actual cause.}}
>
> A more suitable error message should probably indicate the name of the
> missing feature that the model is trying to reference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622973#comment-16622973 ] Kamuela Lau edited comment on SOLR-12785 at 9/21/18 2:38 AM: - A couple of comments regarding the patch: # I moved the default implementations to the Activation interface, and implemented in enums (this pattern is mentioned in "Effective Java", Item 3). I decided on the enum as activation is just a function; if another layer is created with the same activation as a previous layer, only one object will be created (i.e. if there are three layers with sigmoid activation, one object will be created, instead of three as it is now). Doing this also made it easier to test. If it is preferred that the implementations not be singletons or in an enum class, please let me know; any comments are appreciated. # I also attempted to write the test for the activation functions without changing current implementation of DefaultLayer.setActivation(), however in doing so, I felt that I had to construct a NeuralNetworkModel object (with one input, one output, weight 1 and bias 0). See test-no-activation-change.txt, which I have attached. Any comments or advice would be greatly appreciated! was (Author: kamulau): A couple of couple of comments regarding the patch: # I moved the default implementations to the Activation interface, and implemented in enums (this pattern is mentioned in "Effective Java", Item 3). I decided on the enum as activation is just a function; if another layer is created with the same activation as a previous layer, only one object will be created (i.e. if there are three layers with sigmoid activation, one object will be created, instead of three as it is now). Doing this also made it easier to test. If it is preferred that the implementations not be singletons or in an enum class, please let me know; any comments are appreciated. # I also attempted to write the test for the activation functions without changing current implementation of DefaultLayer.setActivation(), however in doing so, I felt that I had to construct a NeuralNetworkModel object (with one input, one output, weight 1 and bias 0). See test-no-activation-change.txt, which I have attached. Any comments or advice would be greatly appreciated! > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622973#comment-16622973 ] Kamuela Lau commented on SOLR-12785: A couple of couple of comments regarding the patch: # I moved the default implementations to the Activation interface, and implemented in enums (this pattern is mentioned in "Effective Java", Item 3). I decided on the enum as activation is just a function; if another layer is created with the same activation as a previous layer, only one object will be created (i.e. if there are three layers with sigmoid activation, one object will be created, instead of three as it is now). Doing this also made it easier to test. If it is preferred that the implementations not be singletons or in an enum class, please let me know; any comments are appreciated. # I also attempted to write the test for the activation functions without changing current implementation of DefaultLayer.setActivation(), however in doing so, I felt that I had to construct a NeuralNetworkModel object (with one input, one output, weight 1 and bias 0). See test-no-activation-change.txt, which I have attached. Any comments or advice would be greatly appreciated! > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: test-no-activation-change.txt > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch, test-no-activation-change.txt > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
[ https://issues.apache.org/jira/browse/SOLR-12785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12785: --- Attachment: SOLR-12785.patch > Add test for activation functions in NeuralNetworkModel > --- > > Key: SOLR-12785 > URL: https://issues.apache.org/jira/browse/SOLR-12785 > Project: Solr > Issue Type: Test > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Attachments: SOLR-12785.patch > > -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-12785) Add test for activation functions in NeuralNetworkModel
Kamuela Lau created SOLR-12785: -- Summary: Add test for activation functions in NeuralNetworkModel Key: SOLR-12785 URL: https://issues.apache.org/jira/browse/SOLR-12785 Project: Solr Issue Type: Test Security Level: Public (Default Security Level. Issues are Public) Components: contrib - LTR Reporter: Kamuela Lau -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Updated] (SOLR-12780) Add support for Leaky ReLU and TanH activations in LTR contrib module
[ https://issues.apache.org/jira/browse/SOLR-12780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kamuela Lau updated SOLR-12780: --- Attachment: SOLR-12780.patch > Add support for Leaky ReLU and TanH activations in LTR contrib module > - > > Key: SOLR-12780 > URL: https://issues.apache.org/jira/browse/SOLR-12780 > Project: Solr > Issue Type: New Feature > Security Level: Public(Default Security Level. Issues are Public) > Components: contrib - LTR >Reporter: Kamuela Lau >Priority: Minor > Labels: ltr > Attachments: SOLR-12780.patch > > > Add support for Leaky ReLU and TanH activation functions in > NeuralNetworkModel. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Created] (SOLR-12780) Add support for Leaky ReLU and TanH activations in LTR contrib module
Kamuela Lau created SOLR-12780: -- Summary: Add support for Leaky ReLU and TanH activations in LTR contrib module Key: SOLR-12780 URL: https://issues.apache.org/jira/browse/SOLR-12780 Project: Solr Issue Type: New Feature Security Level: Public (Default Security Level. Issues are Public) Components: contrib - LTR Reporter: Kamuela Lau Add support for Leaky ReLU and TanH activation functions in NeuralNetworkModel. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
