[jira] Updated: (LUCY-114) compile failure on OS X 10.6
[ https://issues.apache.org/jira/browse/LUCY-114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Karman updated LUCY-114: -- Attachment: align_signature.patch The inline patch came out garbled. Same patch attached. compile failure on OS X 10.6 Key: LUCY-114 URL: https://issues.apache.org/jira/browse/LUCY-114 Project: Lucy Issue Type: Bug Components: Core - Store Environment: Mac OS X 10.6 Reporter: Peter Karman Attachments: align_signature.patch I get this error when trying to compile under OS X: ../core/Lucy/Store/OutStream.c:125: error: conflicting types for 'lucy_OutStream_align' autogen/Lucy/Store/OutStream.h:55: error: previous declaration of 'lucy_OutStream_align' was here patch below: Index: core/Lucy/Store/OutStream.bp === --- core/Lucy/Store/OutStream.bp (revision 925442) +++ core/Lucy/Store/OutStream.bp (revision 925443) @@ -42,7 +42,7 @@ * * @return the new file position. */ -final i64_t +final int64_t Align(OutStream *self, int64_t modulus); /** Flush output buffer to target FileHandle. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (LUCY-115) nullable attribute not propagated
nullable attribute not propagated - Key: LUCY-115 URL: https://issues.apache.org/jira/browse/LUCY-115 Project: Lucy Issue Type: Bug Components: Clownfish Environment: OS X 10.6 Reporter: Peter Karman In Clownfish files (.bp) such as KinoSearch/Search/Compiler.bp, certain methods are defined as nullable but that nullable attribute is not being propagated to the _OVERRIDE generated code. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (LUCY-116) Build.PL opts not supported
Build.PL opts not supported --- Key: LUCY-116 URL: https://issues.apache.org/jira/browse/LUCY-116 Project: Lucy Issue Type: Bug Components: Perl bindings Environment: OS X 10.6 Reporter: Peter Karman The Build.PL docs claim that --config cc= should work but it does not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-116) Build.PL opts not supported
[ https://issues.apache.org/jira/browse/LUCY-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Karman updated LUCY-116: -- Attachment: get_cc.patch pass_cc.patch The attached patches implement the documented --config cc feature. Build.PL opts not supported --- Key: LUCY-116 URL: https://issues.apache.org/jira/browse/LUCY-116 Project: Lucy Issue Type: Bug Components: Perl bindings Environment: OS X 10.6 Reporter: Peter Karman Attachments: get_cc.patch, pass_cc.patch The Build.PL docs claim that --config cc= should work but it does not. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (LUCY-88) change Charmonizer to use the standard stdint.h integer types
change Charmonizer to use the standard stdint.h integer types - Key: LUCY-88 URL: https://issues.apache.org/jira/browse/LUCY-88 Project: Lucy Issue Type: Improvement Components: Charmonizer Reporter: Peter Karman Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-88) change Charmonizer to use the standard stdint.h integer types
[ https://issues.apache.org/jira/browse/LUCY-88?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Karman updated LUCY-88: - Attachment: stdint_h.patch this patch against r889879 adds stdint.h support change Charmonizer to use the standard stdint.h integer types - Key: LUCY-88 URL: https://issues.apache.org/jira/browse/LUCY-88 Project: Lucy Issue Type: Improvement Components: Charmonizer Reporter: Peter Karman Attachments: stdint_h.patch Charmonizer currently uses non-standard type names for specific integer sizes. It would be more portable and easier for first-timers to grok if we used the standard stdint.h types instead, generating a usable stdint.h on systems where it isn't available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (LUCY-72) use short names wherever CHAZ_USE_SHORT_NAMES is in effect
[
https://issues.apache.org/jira/browse/LUCY-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12782952#action_12782952
]
Peter Karman commented on LUCY-72:
--
Ah, this was my fault. I did this:
% grep -r -l ' append_conf' charmonizer | xargs perl -pi -e 's/ append_conf/
ModHand_append_conf/g'
instead of this:
% grep -r -l ' append_conf' charmonizer | grep -v .svn | xargs perl -pi -e 's/
append_conf/ ModHand_append_conf/g'
forgot the grep -v .svn that I used for my other global changes. So the .svn
dirs had the same s/// applied and so svn diff did not see a change.
My bad. Sorry.
use short names wherever CHAZ_USE_SHORT_NAMES is in effect
--
Key: LUCY-72
URL: https://issues.apache.org/jira/browse/LUCY-72
Project: Lucy
Issue Type: Task
Components: Charmonizer
Reporter: Peter Karman
Attachments: chaz_prefix-cleanup.patch, chaz_prefix-cleanup.patch
Function names in .c files always use short names
whenever the LUCY_USE_SHORT_NAMES macro is in effect -- e.g. we use
Sort_mergesort rather than lucy_Sort_mergesort.
Within Charmonizer, we should be consistent about using short names
everywhere the CHAZ_USE_SHORT_NAMES macro is in effect, but currently
there are lots of places that we don't -- e.g. we use chaz_Test_plan
rather than Test_plan within charmonizer/src/Charmonizer/Test.charm:
void
-chaz_Test_plan(TestBatch *batch)
+Test_plan(TestBatch *batch)
{
printf(1..%u\n, batch-num_tests);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-72) use short names wherever CHAZ_USE_SHORT_NAMES is in effect
[
https://issues.apache.org/jira/browse/LUCY-72?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Karman updated LUCY-72:
-
Attachment: chaz_prefix-cleanup.patch
This patch removes the chaz_ prefix wherever the SHORT_NAMES macro is in effect
and does some further clean up of the function names to add namespace prefixes
where they were missing. This patch is against r884395
use short names wherever CHAZ_USE_SHORT_NAMES is in effect
--
Key: LUCY-72
URL: https://issues.apache.org/jira/browse/LUCY-72
Project: Lucy
Issue Type: Task
Components: Charmonizer
Reporter: Peter Karman
Attachments: chaz_prefix-cleanup.patch
Function names in .c files always use short names
whenever the LUCY_USE_SHORT_NAMES macro is in effect -- e.g. we use
Sort_mergesort rather than lucy_Sort_mergesort.
Within Charmonizer, we should be consistent about using short names
everywhere the CHAZ_USE_SHORT_NAMES macro is in effect, but currently
there are lots of places that we don't -- e.g. we use chaz_Test_plan
rather than Test_plan within charmonizer/src/Charmonizer/Test.charm:
void
-chaz_Test_plan(TestBatch *batch)
+Test_plan(TestBatch *batch)
{
printf(1..%u\n, batch-num_tests);
}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (LUCY-70) Charmonizer static functions require S_ prefix like the rest of Lucy code
Charmonizer static functions require S_ prefix like the rest of Lucy code - Key: LUCY-70 URL: https://issues.apache.org/jira/browse/LUCY-70 Project: Lucy Issue Type: Task Components: Charmonizer Reporter: Peter Karman Priority: Minor The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (LUCY-70) Charmonizer static functions require S_ prefix like the rest of Lucy code
[ https://issues.apache.org/jira/browse/LUCY-70?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Karman updated LUCY-70: - Attachment: S_-prefix.patch Patch implements the S_ prefix for Charmonizer code. Charmonizer static functions require S_ prefix like the rest of Lucy code - Key: LUCY-70 URL: https://issues.apache.org/jira/browse/LUCY-70 Project: Lucy Issue Type: Task Components: Charmonizer Reporter: Peter Karman Priority: Minor Attachments: S_-prefix.patch The Charmonizer code predates the convention used elsewhere in Lucy of prefixing static functions with S_. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
