[GitHub] lucene-solr issue #286: [LUCENE-8075] Possible null pointer dereference in c...
Github user imgpulak commented on the issue: https://github.com/apache/lucene-solr/pull/286 @ jpountz @mikemccand I have updated as per your comment. Please review the same. Thanks ! --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155930642
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
@jpountz, @mikemccand any update here?
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155607967
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
@jpountz Any update here?
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155304417
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
Thanks. That works for me.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155300117
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
Hi @jpountz,
May I get the design documents of Lucene?
Thanks,
Pulak
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155296495
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
Okay. Now I understand. Thanks! Let me know what we are going to do. I will
make changes accordingly.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155292700
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
Okay. In that case shall we that piece of code? @jpountz
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #284: [LUCENE-8051] Typo in LevensHtein distance
Github user imgpulak commented on the issue: https://github.com/apache/lucene-solr/pull/284 @jpountz Thanks. I have updated under solr/ subfolder too. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
Github user imgpulak commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/286#discussion_r155178451
--- Diff:
lucene/core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java
---
@@ -106,37 +106,37 @@ public IntersectTermsEnum(FieldReader fr, Automaton
automaton, RunAutomaton runA
if (fr.index == null) {
fstReader = null;
--- End diff --
@jpountz Do we not need to make -
fstReader = null;
?
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #286: [LUCENE-8075] Possible null pointer dereferen...
GitHub user imgpulak opened a pull request: https://github.com/apache/lucene-solr/pull/286 [LUCENE-8075] Possible null pointer dereference in core/src/java/org/⦠â¦apache/lucene/codecs/blocktree/IntersectTermsEnum.java Fix it You can merge this pull request into a Git repository by running: $ git pull https://github.com/imgpulak/lucene-solr LUCENE-8075_2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/286.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #286 commit 132d377474e52bebeaaabe71543930684ea6fb95 Author: PG Date: 2017-12-06T06:47:05Z [LUCENE-8075] Possible null pointer dereference in core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java Fix it --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #285: Lucene 8075
Github user imgpulak closed the pull request at: https://github.com/apache/lucene-solr/pull/285 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #285: Lucene 8075
GitHub user imgpulak reopened a pull request: https://github.com/apache/lucene-solr/pull/285 Lucene 8075 You can merge this pull request into a Git repository by running: $ git pull https://github.com/imgpulak/lucene-solr LUCENE-8075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/285.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #285 commit fbabf5ed63a65fdd52723bdb585a789530d64e05 Author: PG Date: 2017-12-06T05:52:55Z [LUCENE-8051] Typo in LevensHtein distance Fixed a type: "Looking into an issue in elasticsearch I notices that the Levenshtein distance in lucene is called LevensteinDistance instead of LevenshteinDistance. The algorithm name contains an H and in the rest of the code the Levenshtein name is spelled correctly with an H." commit 6247cc1156d6ba330adf9d1ccee9852d990bf409 Author: PG Date: 2017-12-06T06:34:35Z [LUCENE-8075] Possible null pointer dereference in core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java Fix it. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr issue #285: Lucene 8075
Github user imgpulak commented on the issue: https://github.com/apache/lucene-solr/pull/285 This is mistake. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #285: Lucene 8075
Github user imgpulak closed the pull request at: https://github.com/apache/lucene-solr/pull/285 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #285: Lucene 8075
GitHub user imgpulak opened a pull request: https://github.com/apache/lucene-solr/pull/285 Lucene 8075 You can merge this pull request into a Git repository by running: $ git pull https://github.com/imgpulak/lucene-solr LUCENE-8075 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/285.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #285 commit fbabf5ed63a65fdd52723bdb585a789530d64e05 Author: PG Date: 2017-12-06T05:52:55Z [LUCENE-8051] Typo in LevensHtein distance Fixed a type: "Looking into an issue in elasticsearch I notices that the Levenshtein distance in lucene is called LevensteinDistance instead of LevenshteinDistance. The algorithm name contains an H and in the rest of the code the Levenshtein name is spelled correctly with an H." commit 6247cc1156d6ba330adf9d1ccee9852d990bf409 Author: PG Date: 2017-12-06T06:34:35Z [LUCENE-8075] Possible null pointer dereference in core/src/java/org/apache/lucene/codecs/blocktree/IntersectTermsEnum.java Fix it. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #284: [LUCENE-8051] Typo in LevensHtein distance
GitHub user imgpulak opened a pull request: https://github.com/apache/lucene-solr/pull/284 [LUCENE-8051] Typo in LevensHtein distance Fixed a type: "Looking into an issue in elasticsearch I notices that the Levenshtein distance in lucene is called LevensteinDistance instead of LevenshteinDistance. The algorithm name contains an H and in the rest of the code the Levenshtein name is spelled correctly with an H." You can merge this pull request into a Git repository by running: $ git pull https://github.com/imgpulak/lucene-solr LUCENE-8051 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/284.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #284 commit fbabf5ed63a65fdd52723bdb585a789530d64e05 Author: PG Date: 2017-12-06T05:52:55Z [LUCENE-8051] Typo in LevensHtein distance Fixed a type: "Looking into an issue in elasticsearch I notices that the Levenshtein distance in lucene is called LevensteinDistance instead of LevenshteinDistance. The algorithm name contains an H and in the rest of the code the Levenshtein name is spelled correctly with an H." --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
