[GitHub] lucene-solr pull request: [LUCENE-6057] clarified the Sort(Sortfie...

2014-11-14 Thread s4ke
Github user s4ke commented on the pull request:

https://github.com/apache/lucene-solr/pull/20#issuecomment-63032405
  
Michael McCandless fixed this in his own commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: [LUCENE-6057] clarified the Sort(Sortfie...

2014-11-14 Thread s4ke
Github user s4ke closed the pull request at:

https://github.com/apache/lucene-solr/pull/20


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: [LUCENE-6057] clarified the Sort(Sortfie...

2014-11-10 Thread s4ke
Github user s4ke commented on the pull request:

https://github.com/apache/lucene-solr/pull/20#issuecomment-62426181
  
corresponding JIRA issue: https://issues.apache.org/jira/browse/LUCENE-6057


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: clarified the Sort(Sortfield...) constru...

2014-11-05 Thread s4ke
Github user s4ke commented on the pull request:

https://github.com/apache/lucene-solr/pull/20#issuecomment-61812659
  
This is kind of important for users not familiar with the concept of how 
sorting works in Lucene and would have saved me a lot of time while coding if 
this comment was there at that time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: clarified the Sort(Sortfield...) constru...

2014-11-05 Thread s4ke
Github user s4ke commented on the pull request:

https://github.com/apache/lucene-solr/pull/20#issuecomment-61830995
  
Ok thanks. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: clarified the Sort(Sortfield...) constru...

2014-08-14 Thread s4ke
Github user s4ke commented on the pull request:

https://github.com/apache/lucene-solr/pull/20#issuecomment-52157922
  
so, this will not be accepted?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



lucene-solr pull request: clarified the Sort(Sortfield...) constructor

2014-01-16 Thread s4ke
GitHub user s4ke opened a pull request:

https://github.com/apache/lucene-solr/pull/20

clarified the Sort(Sortfield...) constructor

I found that the documentation in the Constructor and the setSort method 
were misleading, so I clarified them.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/s4ke/lucene-solr trunk

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/20.patch


commit b0090dd66530595dbd272220cefd96939e2c794d
Author: Martin Braun martinbraun...@aol.com
Date:   2014-01-16T16:51:36Z

clarified the Sort(Sortfield...) constructor




-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org