[jira] [Commented] (SOLR-10451) Remove contrib/ltr/lib from lib includes in the techproducts example config

2017-09-19 Thread SungJunyoung (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172756#comment-16172756
 ] 

SungJunyoung commented on SOLR-10451:
-

Kind of you. Thank you for your comment, I'll continue contributing :)

> Remove contrib/ltr/lib from lib includes in the techproducts example config
> ---
>
> Key: SOLR-10451
> URL: https://issues.apache.org/jira/browse/SOLR-10451
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Assignee: Jan Høydahl
>Priority: Minor
>  Labels: newdev
> Fix For: master (8.0), 7.1
>
> Attachments: SOLR-10451.patch
>
>
> As [~varunthacker] mentioned in SOLR-8542 there are actually no jars in the 
> {{contrib/ltr/lib}} folder.
> -So to avoid confusion, let's remove the {{contrib/ltr}} folder from the Solr 
> binary release (it currently contains just a boilerplate {{README.txt}} 
> file).-
> The {{ regex=".*\.jar" />}} line in 
> https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
>  can also be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[jira] [Commented] (SOLR-10451) Remove contrib/ltr/lib from lib includes in the techproducts example config

2017-09-18 Thread SungJunyoung (JIRA) 

[ 
https://issues.apache.org/jira/browse/SOLR-10451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16171086#comment-16171086
 ] 

SungJunyoung commented on SOLR-10451:
-

Is it right way to contribute to solr? Wanting to contribute, I made a 
pull-request with github. 

> Remove contrib/ltr/lib from lib includes in the techproducts example config
> ---
>
> Key: SOLR-10451
> URL: https://issues.apache.org/jira/browse/SOLR-10451
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Christine Poerschke
>Priority: Minor
>  Labels: newdev
> Attachments: SOLR-10451.patch
>
>
> As [~varunthacker] mentioned in SOLR-8542 there are actually no jars in the 
> {{contrib/ltr/lib}} folder.
> -So to avoid confusion, let's remove the {{contrib/ltr}} folder from the Solr 
> binary release (it currently contains just a boilerplate {{README.txt}} 
> file).-
> The {{ regex=".*\.jar" />}} line in 
> https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml
>  can also be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

[GitHub] lucene-solr pull request #249: SOLR-10451: Remove contrib/ltr/lib from lib i...

2017-09-18 Thread sungjunyoung 
GitHub user sungjunyoung opened a pull request:

https://github.com/apache/lucene-solr/pull/249

SOLR-10451: Remove contrib/ltr/lib from lib includes

 in the techproducts example config

I deleted line 84 : `` 
in [solrconfig.xml] 
file(https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sungjunyoung/lucene-solr SOLR-10451

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/249.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #249


commit 5f627025dcb08e3158823685917de1dfe98127b6
Author: sungjunyoung <wnsdud1...@gmail.com>
Date:   2017-09-19T03:47:58Z

SOLR-10451: Remove contrib/ltr/lib from lib includes in the techproducts 
example config

I deleted line84 : `` in

https://github.com/apache/lucene-solr/blob/master/solr/server/solr/configsets/sample_techproducts_configs/conf/solrconfig.xml




---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org