[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-28 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525982234
 
 
   
![image](https://user-images.githubusercontent.com/2353608/63902942-960f4e00-c9c0-11e9-8360-9a2e8e8caafb.png)
   
   See above, `ant precommit` is fixed now. Thanks again @janhoy @shalinmangar 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-28 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525952277
 
 
   @janhoy I need to make a few changes for precommit to pass. making now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-28 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525944739
 
 
   Ok. Will do. Thank you.
   
   On Wed, Aug 28, 2019 at 3:20 PM Jan Høydahl 
   wrote:
   
   > @MarcusSorealheis  Can you try to
   > address this precommit error:
   >
   > [java] ERROR: Orphan page:
   > 
/Users/janhoy/git/lucene-solr/solr/build/solr-ref-guide/content/major-changes-in-solr-9.adoc
   >
   > All new adoc pages need to be linked into the structure from somewhere.
   > You need to add it to the top of solr-upgrade-notes.adoc. Then simply run 
ant
   > precommit afterwards to verify that it is fixed.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   -- 
   Marcus Eagan
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-28 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525929484
 
 
   very big help @janhoy. That was awesome. L-ingGTM?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-27 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525563889
 
 
   @shalinmangar if you run the tests now they all work


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-27 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-525172840
 
 
   > org.apache.solr.cloud.TestConfigSetsAPI.testUploadWithScriptUpdateProcessor
   
   Will check now


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-19 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-522845003
 
 
   Feel free to take a look when you can @janhoy I think it looks pretty good 
and accounts for the changes to aid upgraders who may not have a user 
configured.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-19 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-522844564
 
 
   Tests pass: 
   ```2144 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.a.s.SolrTestCaseJ4 SecureRandom sanity checks: 
test.solr.allowed.securerandom=null & java.security.egd=file:/dev/./urandom
   2196 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Created dataDir: 
/private/var/folders/zd/mnb2vj0552d3jsxzlw_8s0xwgn/T/solr.security.TestSha256AuthenticationProvider_F56EB5E57E25DD6A-001/data-dir-1-001
   2302 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Using TrieFields (NUMERIC_POINTS_SYSPROP=false) 
w/NUMERIC_DOCVALUES_SYSPROP=false
   2349 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.e.j.u.log Logging initialized @2395ms to org.eclipse.jetty.util.log.Slf4jLog
   2358 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Randomized ssl (false) and clientAuth (false) via: 
@org.apache.solr.util.RandomizeSSL(reason="", value=0.0/0.0, ssl=0.0/0.0, 
clientAuth=0.0/0.0) w/ MAC_OS_X supressed clientAuth
   2400 INFO  
(TEST-TestSha256AuthenticationProvider.testBasicAuthDeleteFinalUser-seed#[F56EB5E57E25DD6A])
 [ ] o.a.s.SolrTestCaseJ4 ###Starting testBasicAuthDeleteFinalUser
   2432 INFO  
(TEST-TestSha256AuthenticationProvider.testBasicAuthDeleteFinalUser-seed#[F56EB5E57E25DD6A])
 [ ] o.a.s.SolrTestCaseJ4 ###Ending testBasicAuthDeleteFinalUser
   2458 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[F56EB5E57E25DD6A]-worker) [ ] 
o.a.s.SolrTestCaseJ4 --- 
Done waiting for tracked resources to be released
   
   Process finished with exit code 0```
   
   Feel free to take a look when you can @janhoy I think it looks pretty good.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-19 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-522842360
 
 
   `org.junit.AssumptionViolatedException: Test (or randomization for this 
seed) wants to use SSL, but SSL is known to fail on your JVM: OpenJDK 64-Bit 
Server VM / 11.0.1+13`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-19 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-522840559
 
 
   Weird error. Stack trace points to a randomized seed Null Pointer Exception: 
   
   ```
   2660 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[4304A0AA287F91BC]-worker) [ ] 
o.a.s.SolrTestCaseJ4 SecureRandom sanity checks: 
test.solr.allowed.securerandom=null & java.security.egd=file:/dev/./urandom
   2725 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[4304A0AA287F91BC]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Created dataDir: 
/private/var/folders/zd/mnb2vj0552d3jsxzlw_8s0xwgn/T/solr.security.TestSha256AuthenticationProvider_4304A0AA287F91BC-001/data-dir-1-001
   2842 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[4304A0AA287F91BC]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Using PointFields (NUMERIC_POINTS_SYSPROP=true) 
w/NUMERIC_DOCVALUES_SYSPROP=false
   2897 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[4304A0AA287F91BC]-worker) [ ] 
o.e.j.u.log Logging initialized @٢٩٥٣ms to org.eclipse.jetty.util.log.Slf4jLog
   2906 INFO  
(SUITE-TestSha256AuthenticationProvider-seed#[4304A0AA287F91BC]-worker) [ ] 
o.a.s.SolrTestCaseJ4 Randomized ssl (false) and clientAuth (false) via: 
@org.apache.solr.util.RandomizeSSL(reason="", value=0.0/0.0, ssl=0.0/0.0, 
clientAuth=0.0/0.0) w/ MAC_OS_X supressed clientAuth
   2954 INFO  
(TEST-TestSha256AuthenticationProvider.testBasicAuthDeleteFinalUser-seed#[4304A0AA287F91BC])
 [ ] o.a.s.SolrTestCaseJ4 ###Starting testBasicAuthDeleteFinalUser
   2987 INFO  
(TEST-TestSha256AuthenticationProvider.testBasicAuthDeleteFinalUser-seed#[4304A0AA287F91BC])
 [ ] o.a.s.SolrTestCaseJ4 ###Ending testBasicAuthDeleteFinalUser
   
   NOTE: reproduce with: ant test  -Dtestcase=TestSha256AuthenticationProvider 
-Dtests.method=testBasicAuthDeleteFinalUser -Dtests.seed=4304A0AA287F91BC 
-Dtests.slow=true -Dtests.badapples=true -Dtests.locale=ar-IL 
-Dtests.timezone=America/North_Dakota/New_Salem -Dtests.asserts=true 
-Dtests.file.encoding=UTF-8
   
   java.lang.NullPointerException
at 
__randomizedtesting.SeedInfo.seed([4304A0AA287F91BC:A3B766CE07092403]:0)
at 
java.base/java.util.AbstractCollection.containsAll(AbstractCollection.java:324)
at 
org.apache.solr.security.Sha256AuthenticationProvider.edit(Sha256AuthenticationProvider.java:140)
at 
org.apache.solr.security.BasicAuthPlugin.edit(BasicAuthPlugin.java:115)
at 
org.apache.solr.security.TestSha256AuthenticationProvider.testBasicAuthDeleteFinalUser(TestSha256AuthenticationProvider.java:96)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$11.evaluate(RandomizedRunner.java:1035)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
at 
com.carrotsearch.randomizedtesting.rules.SystemPropertiesRestoreRule$1.evaluate(SystemPropertiesRestoreRule.java:57)
at 
org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
at 
org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
at 
org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
at 
org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
at 
org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
at 
com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
at 
com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
at 
com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
at 
com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
at 

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-13 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-520925774
 
 
   > My comment about ERROR above was related to the special case where people 
initialize security.json without any users, like `"authentication": 
{"class":"solr.BasicAuthPlugin"}`. In this case today nothing will happen since 
blockUnknown=false, but when we change the default, the entire cluster is 
completely locked for everyone. So my question was whether to allow such a 
config at all, or to allow configs with no users only if blockUnknown is 
explicitly set to false.
   
   Makes perfect sense.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-12 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-520690325
 
 
   
https://github.com/apache/lucene-solr/pull/805/files#diff-38fe7b489da085cdd2a483bd5a185aa4R82


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-08-12 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-520690240
 
 
   @janhoy In the PRs most recent state, you can see that I am now throwing a 
`SolrException` in the case when the `blockUnknown` parameter is not set. This 
change will make upgrading less painful for the community.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin. [WIP]

2019-08-08 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin. [WIP]
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-519736169
 
 
   @janhoy I've appended Work In Progress to this PR's title because I'm facing 
a strange build error. It does not seem related:
   ``` [ecj-lint] --
[ecj-lint] 1. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 23)
[ecj-lint]  import javax.naming.NamingException;
[ecj-lint] 
[ecj-lint] The type javax.naming.NamingException is not accessible
[ecj-lint] --
[ecj-lint] 2. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 28)
[ecj-lint]  public class MockInitialContextFactory implements 
InitialContextFactory {
[ecj-lint]   ^
[ecj-lint] The type MockInitialContextFactory must implement the inherited 
abstract method InitialContextFactory.getInitialContext(Hashtable)
[ecj-lint] --
[ecj-lint] 3. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 30)
[ecj-lint]  private final javax.naming.Context context;
[ecj-lint]
[ecj-lint] The type javax.naming.Context is not accessible
[ecj-lint] --
[ecj-lint] 4. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 33)
[ecj-lint]  context = mock(javax.naming.Context.class);
[ecj-lint]  ^^^
[ecj-lint] context cannot be resolved to a variable
[ecj-lint] --
[ecj-lint] 5. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 33)
[ecj-lint]  context = mock(javax.naming.Context.class);
[ecj-lint] 
[ecj-lint] The type javax.naming.Context is not accessible
[ecj-lint] --
[ecj-lint] 6. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 36)
[ecj-lint]  when(context.lookup(anyString())).thenAnswer(invocation -> 
objects.get(invocation.getArgument(0)));
[ecj-lint]   ^^^
[ecj-lint] context cannot be resolved
[ecj-lint] --
[ecj-lint] 7. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 38)
[ecj-lint]  } catch (NamingException e) {
[ecj-lint]   ^^^
[ecj-lint] NamingException cannot be resolved to a type
[ecj-lint] --
[ecj-lint] 8. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 45)
[ecj-lint]  public javax.naming.Context getInitialContext(Hashtable env) {
[ecj-lint] 
[ecj-lint] The type javax.naming.Context is not accessible
[ecj-lint] --
[ecj-lint] 9. ERROR in 
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/MockInitialContextFactory.java
 (at line 46)
[ecj-lint]  return context;
[ecj-lint] ^^^
[ecj-lint] context cannot be resolved to a variable
[ecj-lint] --
[ecj-lint] 9 problems (9 errors)
   
   BUILD FAILED
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/build.xml:101: 
The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/build.xml:651:
 The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/common-build.xml:479:
 The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/lucene/common-build.xml:2015:
 The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/lucene/common-build.xml:2048:
 Compile failed; see the compiler error output for details.```
   
   I also[ saw similar errors on the lucene-dev mailing 

[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-07-23 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-514428925
 
 
   None of those files are changed in my PR


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-07-23 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-514426076
 
 
   Open JDK Java 11


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] [lucene-solr] MarcusSorealheis commented on issue #805: SOLR-13649 change the default behavior of the basic authentication plugin.

2019-07-23 Thread GitBox
MarcusSorealheis commented on issue #805: SOLR-13649 change the default 
behavior of the basic authentication plugin.
URL: https://github.com/apache/lucene-solr/pull/805#issuecomment-514425853
 
 
   I see this failure on `precommit` 
```/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/build.xml:117:
 The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/build.xml:346:
 The following error occurred while executing this line:
   
/Users/marcussorealheis/github.com/marcussorealheis/lucene-solr/solr/common-build.xml:536:
 Check for forbidden API calls failed while scanning class 
'org.apache.solr.update.StreamingSolrClients' (StreamingSolrClients.java): 
java.lang.ClassNotFoundException: 
org.apache.solr.update.ErrorReportingConcurrentUpdateSolrClient$Builder (while 
looking up details about referenced class 
'org.apache.solr.update.ErrorReportingConcurrentUpdateSolrClient$Builder')```


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org