[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512228939 > I ran luceneutil on this patch on my machine too and I'm getting similar results. It's a bit disappointing, I was expecting some gains though I'm rather happy that we can keep things easier to maintain by not having to sepcialize too much. Sorry for the time you spent on it but I think it's better to keep things the way they are today? No sweat, I understand. Makes sense to keep things straightforward! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512220733 luceneutil run: https://gist.github.com/atris/1b2c25021ca11138338aa73efde2aa38 wikimedium2m This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-512198512 @jpountz Updated the PR with lazy loading. Please let me know if it looks fine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-51216 Ah, yes, that makes sense. I did a couple of more runs with 10m docs and saw similar results. Will update the PR This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511874550 @jpountz Three Luceneutil runs with wikimedium2m: https://gist.github.com/atris/5057e3372b287873a4e840c5f4e65a0d https://gist.github.com/atris/76719423071662d5d25eed4bdb7bf4a3 https://gist.github.com/atris/dd7b7336147da138ac340670c81e5452 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511813095 @jpountz I have fixed your comments, please let me know if they look fine. luceneutil is running right now with 10k documents, will post results ASAP This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-511408229 Any thoughts on this one? I am hoping this will bring gains to our nightly benchmarks :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq
atris commented on issue #779: LUCENE-8762: Introduce Specialized Impacts For Doc + Freq URL: https://github.com/apache/lucene-solr/pull/779#issuecomment-510768788 cc: @jpountz This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
