[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-522487494 > I merged in master and will now merge in branch 8x. Apache Jira is not accessible for me at the moment so I'll update the issue later. Thanks @atris ! Thanks @jimczi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-522476144 > > Does this look merge ready now? > > I think so, yes Thanks, mind merging it, please? :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-522473505 @jimczi Thanks for approving. Does this look merge ready now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-522430190 Gentle ping :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-518110914 Rebased per master. Could we merge this, if no objections? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-515476696 @jpountz I ran recommit on the latest version again and rebased with master -- all came in clean This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-515390656 @jpountz Updated the same This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-515372993 @jpountz updated the same. ant precommit looks fine This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-515349726 Any comments on this one, please? Happy to iterate This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-513709757 I ran beaster 20 times on the new tests -- came clean. @iverase @jpountz Please let me know if there are any thoughts on this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512816491 @iverase I was hesitant to do that since MultiRangeQuery will take multiple points as inputs, so if we were to build the entire query in one go, that would require the user to pass in an array of arrays upfront. The builder approach, much like BooleanQuery, gives the user a friendly option to populate ranges and then build a query. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512723236 > This approach is ok when the number of ranges is low but I wonder if it would be worthy to order the ranges on an interval tree (similar to EdgeTree) so we can skip quickly ranges that do not match the inner nodes. Do you feel that can be done as a follow up PR, since this PR is large enough in itself, and the ordering can probably be built on top of this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges
atris commented on issue #794: LUCENE-8769: Introduce Range Query Type With Multiple Ranges URL: https://github.com/apache/lucene-solr/pull/794#issuecomment-512674354 cc @jpountz @iverase This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
