[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-531221868 Any further thoughts on this one? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-530324014 @mikemccand Thanks for the inputs, updated the PR. Please let me know your comments This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-529791380 Rebased with master. Any thoughts on this one? Seems like a useful change with no degradation in the happy path? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-527039867 Another set of runs on wikimedium all with concurrent searching enabled: Fuzzy1 47.29 (7.1%) 45.06 (11.1%) -4.7% ( -21% - 14%) OrHighNotMed 405.86 (3.4%) 392.55 (2.2%) -3.3% ( -8% -2%) OrNotHighHigh 386.16 (4.7%) 373.54 (4.1%) -3.3% ( -11% -5%) BrowseDayOfYearTaxoFacets 6003.62 (2.6%) 5808.73 (2.2%) -3.2% ( -7% -1%) Prefix3 176.87 (10.1%) 172.28 (8.9%) -2.6% ( -19% - 18%) BrowseMonthTaxoFacets 6190.97 (3.8%) 6044.46 (4.9%) -2.4% ( -10% -6%) MedPhrase 40.97 (5.1%) 40.06 (5.5%) -2.2% ( -12% -8%) OrNotHighMed 383.00 (3.3%) 374.82 (4.7%) -2.1% ( -9% -6%) AndHighLow 191.05 (3.4%) 187.88 (3.2%) -1.7% ( -7% -5%) OrHighNotLow 416.92 (4.4%) 411.50 (4.3%) -1.3% ( -9% -7%) AndHighMed 39.58 (2.2%) 39.17 (1.9%) -1.0% ( -5% -3%) Wildcard 24.72 (7.9%) 24.49 (6.6%) -0.9% ( -14% - 14%) HighPhrase 52.11 (5.6%) 51.63 (4.8%) -0.9% ( -10% - 10%) LowPhrase 13.43 (2.7%) 13.33 (2.5%) -0.8% ( -5% -4%) AndHighHigh 12.68 (3.9%) 12.58 (3.2%) -0.8% ( -7% -6%) HighTerm 717.09 (4.8%) 712.98 (5.2%) -0.6% ( -10% -9%) PKLookup 91.70 (2.8%) 91.27 (3.8%) -0.5% ( -6% -6%) IntNRQ 21.92 (17.9%) 21.83 (18.0%) -0.4% ( -30% - 43%) Respell 34.38 (3.3%) 34.24 (2.3%) -0.4% ( -5% -5%) HighTermDayOfYearSort 27.44 (3.2%) 27.33 (1.6%) -0.4% ( -5% -4%) OrHighNotHigh 463.40 (5.4%) 461.74 (4.3%) -0.4% ( -9% -9%) BrowseDateTaxoFacets0.69 (0.4%)0.69 (0.5%) -0.2% ( -1% -0%) BrowseMonthSSDVFacets2.63 (1.6%)2.63 (1.1%) -0.1% ( -2% -2%) MedTerm 885.64 (5.0%) 885.56 (3.6%) -0.0% ( -8% -8%) Fuzzy2 39.47 (7.1%) 39.47 (9.4%) -0.0% ( -15% - 17%) BrowseDayOfYearSSDVFacets2.41 (0.4%)2.41 (0.3%) -0.0% ( 0% -0%) HighSpanNear6.53 (1.0%)6.53 (1.3%) 0.0% ( -2% -2%) MedSloppyPhrase 31.76 (2.0%) 31.79 (1.6%) 0.1% ( -3% -3%) HighIntervalsOrdered6.10 (1.6%)6.11 (2.1%)0.1% ( -3% -3%) OrHighLow 177.27 (2.2%) 177.50 (2.5%) 0.1% ( -4% -5%) LowSloppyPhrase 30.62 (1.9%) 30.67 (1.7%) 0.2% ( -3% -3%) MedSpanNear7.63 (1.7%)7.64 (2.0%) 0.2% ( -3% -3%) LowSpanNear8.34 (1.3%)8.37 (1.8%) 0.3% ( -2% -3%) OrNotHighLow 308.14 (2.0%) 309.75 (4.9%) 0.5% ( -6% -7%) LowTerm 861.94 (4.6%) 870.93 (2.8%) 1.0% ( -6% -8%) HighSloppyPhrase5.58 (3.2%)5.64 (2.8%) 1.1% ( -4% -7%) OrHighMed 10.81 (2.4%) 10.95 (2.6%) 1.4% ( -3% -6%) OrHighHigh 10.28 (2.5%) 10.48 (3.2%) 1.9% ( -3% -7%) Seems there is no degradation? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
Re: [GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
OK; I guess I was confusing taskRepeatCount (within a JVM), but you can also have jvmCount On Tue, Aug 13, 2019 at 6:16 AM GitBox wrote: > > atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in > LRUQueryCache > URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-520776996 > > >> It should be enough to report the stats after the last iteration - it is > cumulative, so the previous ones just add noise? I agree QPS looks pretty > noisy, probably no real change. > >I dont think thats true, since each run is its own JVM? > > > > > This is an automated message from the Apache Git Service. > To respond to the message, please log on to GitHub and use the > URL above to go to the specific comment. > > For queries about this service, please contact Infrastructure at: > us...@infra.apache.org > > > With regards, > Apache Git Services > > - > To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org > For additional commands, e-mail: dev-h...@lucene.apache.org > - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-520776996 > It should be enough to report the stats after the last iteration - it is cumulative, so the previous ones just add noise? I agree QPS looks pretty noisy, probably no real change. I dont think thats true, since each run is its own JVM? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache
atris commented on issue #815: LUCENE-8213: Introduce Asynchronous Caching in LRUQueryCache URL: https://github.com/apache/lucene-solr/pull/815#issuecomment-518182664 I ran luceneutil for wikipedia 10M with the concurrent searching and latency calculation patch applied. https://gist.github.com/atris/e0fa10e79fb5ef62bd571406acf98433 There was no significant degradation to QPS, and the P999 and P100 latencies generally saw an improvement This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
