[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496878927 Hi @uschindler, this PR passed all tests & precommit. If the changes in `AnalysisSPILoader` look fine for you, I will commit it to the ASF repo's master branch. (Maybe I will merge it to the master, but not to 8x?) Let me know if you find anything wrong, or of course you can directly modify the branch like the previous time. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-496000812 Just a quick note: A few times I nearly committed the `__pycache__` directory, so I added this to the gitignore file. This does not work for python2. Please let me know if the python scripts could be run on python2 (depending on the system environments), I will fix the file again. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I occasionally see the python bytecode cache directory is created under `dev-tools/scripts`, though I've not figured out which ant task generates this... ``` diff --git a/.gitignore b/.gitignore index 4b947436dc..674ddd198f 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ pom.xml /nbproject /nb-build .pydevproject +__pycache__ ``` The entry above works for python3 only, because python3 creates the `__pycache__` directory and writes all bytecode files to there. Or, I usually add those lines to .gitignore of my python projects (this works for both of python2 and python3). ``` *.pyc *.pyo ``` Alternatively, I think we can completely disable the cache (don't write .pyc or .pyo files) by `-B` option. https://stackoverflow.com/questions/16869024/what-is-pycache This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I occasionally see the python bytecode cache directory is created under `dev-tools/scripts`, though I've not figured out which ant task generates this... ``` diff --git a/.gitignore b/.gitignore index 4b947436dc..674ddd198f 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ pom.xml /nbproject /nb-build .pydevproject +__pycache__ ``` The entry above works for python3 only, because python3 creates the `__pycache__` directory and writes all bytecode files to there. Or, I usually add those lines to my python projects (this works for both of python2 and python3). ``` *.pyc *.pyo ``` Alternatively, I think we can completely disable the cache (don't write .pyc or .pyo files) by `-B` option. https://stackoverflow.com/questions/16869024/what-is-pycache This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] [lucene-solr] mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names
mocobeta edited a comment on issue #654: LUCENE-8778: Define analyzer SPI names as static final fields and document the names URL: https://github.com/apache/lucene-solr/pull/654#issuecomment-495680743 It is not related to this issue, but I'd like to add this line to the gitignore file. I occasionally see the python bytecode cache directory is created under `dev-tools/scripts`, though I've not figured out which ant task generates this... ``` diff --git a/.gitignore b/.gitignore index 4b947436dc..674ddd198f 100644 --- a/.gitignore +++ b/.gitignore @@ -26,3 +26,4 @@ pom.xml /nbproject /nb-build .pydevproject +__pycache__ ``` Or, I usually add those lines to my python projects (this works for both of python2 and python3) ``` *.pyc *.pyo ``` Alternatively, I think we can completely disable the cache (don't write .pyc or .pyo files) by `-B` option. https://stackoverflow.com/questions/16869024/what-is-pycache This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
