[GitHub] lucene-solr pull request: select?collapse=... - fix NPE in Collaps...

2016-01-12 Thread cpoerschke
Github user cpoerschke closed the pull request at:

https://github.com/apache/lucene-solr/pull/94


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: select?collapse=... - fix NPE in Collaps...

2014-09-12 Thread cpoerschke
GitHub user cpoerschke opened a pull request:

https://github.com/apache/lucene-solr/pull/94

select?collapse=... - fix NPE in Collapsing(FieldValue|Score)Collector

https://issues.apache.org/jira/i#browse/SOLR-6510

Patch is against branch_4x where CollapsingQParserPlugin line 230's 
searcher.getAtomicReader().getSortedDocValues call could return null. On trunk 
the line 230 call has been replaced (by LUCENE-5666) and so the 
CollapsingQParserPlugin part of the patch is not required.

The TestCollapseQParserPlugin change could go to branch_4x only or 
branch_4x and trunk.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bloomberg/lucene-solr branch_4x-collapse-empty

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/94.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #94


commit 5e2968541221307a6ca7b397c61a040289421ac1
Author: Christine Poerschke cpoersc...@bloomberg.net
Date:   2014-09-05T17:00:38Z

solr: select?collapse=... - fix NPE in Collapsing(FieldValue|Score)Collector




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[GitHub] lucene-solr pull request: select?collapse=... - fix NPE in Collaps...

2014-09-12 Thread cpoerschke
Github user cpoerschke commented on the pull request:

https://github.com/apache/lucene-solr/pull/94#issuecomment-55431425
  
Actually, one of the latest test runs just failed with ... this codec 
cannot write docvalues ... codecs.lucene3x ...  and so perhaps the 
docValues=false/true randomisation in my testCollapseQueries change should be 
commented out for now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org