[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...
Github user mrkarthik closed the pull request at: https://github.com/apache/lucene-solr/pull/287 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...
Github user uschindler commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/287#discussion_r174281383 --- Diff: dev-tools/eclipse/dot.classpath.xsl --- @@ -54,7 +55,23 @@ - + --- End diff -- sure! --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/287#discussion_r174149233 --- Diff: dev-tools/eclipse/dot.classpath.xsl --- @@ -54,7 +55,23 @@ - + --- End diff -- Hi @uschindler can you please look at the final patch uploaded on the JIra instead. I took Karthik's patch and fixed the whitespace/tabs issues there --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...
Github user uschindler commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/287#discussion_r174147473 --- Diff: dev-tools/eclipse/dot.classpath.xsl --- @@ -54,7 +55,23 @@ - + --- End diff -- Could you fix the indent here. In Lucene we only allow whitespace, tabs are forbidden anywhere. This looks like it's mixed here (unfortunately I can't see it here) --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #287: SOLR-11331: Ability to Debug Solr With Eclips...
GitHub user mrkarthik opened a pull request: https://github.com/apache/lucene-solr/pull/287 SOLR-11331: Ability to Debug Solr With Eclipse IDE You can merge this pull request into a Git repository by running: $ git pull https://github.com/mrkarthik/lucene-solr jira/SOLR-11331 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/287.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #287 --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
