[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
Github user tirthmehta1994 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/483#discussion_r232522667
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java
---
@@ -187,12 +190,23 @@ public void finish() throws IOException {
log.info(getLogStringAndClearRspToLog());
}
+ if (deleteLog.isInfoEnabled()) {
--- End diff --
@vthacker it would be great if you could let me know of some updates here.
Thanks.
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
Github user tirthmehta1994 commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/483#discussion_r228394789 --- Diff: solr/server/resources/log4j2.xml --- @@ -67,6 +67,10 @@ + + --- End diff -- Yup, it should have been LogUpdateProcessorFactory itself, since the changes are planned in LogUpdateProcessorFactory class itself. I have made the changes accordingly. --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
Github user tirthmehta1994 commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/483#discussion_r228394242
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java
---
@@ -187,12 +190,23 @@ public void finish() throws IOException {
log.info(getLogStringAndClearRspToLog());
}
+ if (deleteLog.isInfoEnabled()) {
--- End diff --
Any request that contains a delete
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
Github user vthacker commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/483#discussion_r228304003
--- Diff:
solr/core/src/java/org/apache/solr/update/processor/LogUpdateProcessorFactory.java
---
@@ -187,12 +190,23 @@ public void finish() throws IOException {
log.info(getLogStringAndClearRspToLog());
}
+ if (deleteLog.isInfoEnabled()) {
--- End diff --
What if it's a mixed set of commands like this example :
http://lucene.apache.org/solr/guide/7_5/uploading-data-with-index-handlers.html#sending-json-update-commands
Is the goal here to log any request that contains a delete or log only
deletes to a separate file? The final condition check here will need to vary
based on that
---
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
Github user vthacker commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/483#discussion_r228301278 --- Diff: solr/server/resources/log4j2.xml --- @@ -67,6 +67,10 @@ + + --- End diff -- Is LogDeleteQueryProcessorFactory defined somewhere? Or should the class name be `LogUpdateProcessorFactory` ? --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] lucene-solr pull request #483: Log Delete Query Processor custom solr compon...
GitHub user tirthmehta1994 opened a pull request: https://github.com/apache/lucene-solr/pull/483 Log Delete Query Processor custom solr component Log Delete Query Processor custom solr component You can merge this pull request into a Git repository by running: $ git pull https://github.com/walmartlabs/lucene-solr logdeletequeryprocessor2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #483 commit 20720b7ffdc2deac9d31cd38afdec21cba3bc7fe Author: tirthmehta1994 Date: 2018-10-23T16:53:34Z Log Delete Query Processor custom solr component --- - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
