[GitHub] uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3
uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-459733827 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3
uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-459260156 Hi, > * Forbiddenapis (even with SuppressForbidden) kept saying that https://github.com/apache/hadoop/blob/branch-3.2/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/http/HttpServer2.java#L1500 was invalid due to https://github.com/apache/lucene-solr/blob/master/lucene/tools/forbiddenApis/servlet-api.txt#L18. I tried to add SuppressForbidden at the class, static class, method, and override methods to fix the issue, but the errors still came back. That's indeed strange. The reason here is that it overrides a method that is forbidden. So the only chance is to add @SuppressForbidden to the inner static class "RequestQuoter". I will do a check and maybe open bug in forbiddenapis. I will do some tries once I have time. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3
uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-458975651 @risdenk Thanks. That's exactly what I expected. Thanks for explanation. I am fine with that solution (because it's test only, so we don't deliver that to the end user for use in production). To me it's only important to clarify: If we want to go that route, it's important to have our own test classes BEFORE the hadoop imports on classpath. We have to make sure that this also applies for the Eclipse/NetBeans/... Development integrations! So I am fine with the approach, but we need to make the build system be informed about that. We also should not disable our source code and license checks on the forked Hadoop classes! If there are violations, we should maybe fix them at least in the code we imported. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[GitHub] uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3
uschindler commented on issue #553: SOLR-9515: Update to Hadoop 3 URL: https://github.com/apache/lucene-solr/pull/553#issuecomment-458626014 Hi, I don't fully understand why you need the clone of the HttpServer2.java source code. Isn't this included in hadoop anyways. Ot has this some special reason like replacing a shaded version inside hadoop. It's gppd that we have removed the mortbay jetty now from test dependencies, so I have the feeling this does something like this to prevent another version of jetyt to be included. So please explain! As long as Solr uses classpath instead of modules this won't bring any issues - if the classpath order for running tests is fine. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
