[jira] (SOLR-10080) Fix some issues reported by findbugs
[ https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847585#comment-15847585 ] Michael Braun commented on SOLR-10080: -- In BlobRepository the only use of that synchronized call I can see on first glance would be to prevent blobCreator.call from executing twice, but the same thing can be accomplished by using .computeIfAbsent. > Fix some issues reported by findbugs > - > > Key: SOLR-10080 > URL: https://issues.apache.org/jira/browse/SOLR-10080 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Priority: Minor > Attachments: SOLR-10080.patch > > > I ran a findbugs analysis on code and found a lot of issues. I found issues > in both lucene and solr, however, I am not sure whether Solr developers > should fix issues like this in the lucene code or not. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] (SOLR-10080) Fix some issues reported by findbugs
[ https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847548#comment-15847548 ] Erick Erickson commented on SOLR-10080: --- Pushkar: One technique people use for marking code that needs to be cleaned up is to add a //nocommit comment to it. The precommit step will flag all //nocommit entries and fail the build so it's a sure-fire way to make sure any lingering questions are cleaned up. Of course then when you're all ready to add it you have to run the 'ant precommit' step, but even if you don't the next Jenkins build will so... No big deal, just FYI... > Fix some issues reported by findbugs > - > > Key: SOLR-10080 > URL: https://issues.apache.org/jira/browse/SOLR-10080 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Priority: Minor > Attachments: SOLR-10080.patch > > > I ran a findbugs analysis on code and found a lot of issues. I found issues > in both lucene and solr, however, I am not sure whether Solr developers > should fix issues like this in the lucene code or not. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] (SOLR-10080) Fix some issues reported by findbugs
[ https://issues.apache.org/jira/browse/SOLR-10080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pushkar Raste updated SOLR-10080: - Attachment: SOLR-10080.patch I have fixed some of the issues reported by findbugs (and added some descriptive comments in some cases). In some cases when, I wasn't sure if code findbugs reported as issue was intentionally written like that or not. Once, I get feedback, I will polish the patch to remove unwanted comments (or remove code that I have just commented for now) > Fix some issues reported by findbugs > - > > Key: SOLR-10080 > URL: https://issues.apache.org/jira/browse/SOLR-10080 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Pushkar Raste >Priority: Minor > Attachments: SOLR-10080.patch > > > I ran a findbugs analysis on code and found a lot of issues. I found issues > in both lucene and solr, however, I am not sure whether Solr developers > should fix issues like this in the lucene code or not. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] (SOLR-10080) Fix some issues reported by findbugs
Pushkar Raste created SOLR-10080: Summary: Fix some issues reported by findbugs Key: SOLR-10080 URL: https://issues.apache.org/jira/browse/SOLR-10080 Project: Solr Issue Type: Bug Security Level: Public (Default Security Level. Issues are Public) Reporter: Pushkar Raste Priority: Minor I ran a findbugs analysis on code and found a lot of issues. I found issues in both lucene and solr, however, I am not sure whether Solr developers should fix issues like this in the lucene code or not. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
