[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13861449#comment-13861449 ] Fang Xu edited comment on SOLR-3583 at 1/6/14 11:23 AM: I resolved some failures of applying SOLR-2894. The I run this patch, still I got some failures. I fixed some. This one can be resolved, [javac] Compiling 7 source files to /solr-4.6.0/solr/build/solr-core/classes/java [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6 [javac] /home/fangxu/projects/solr-4.6.0/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java:1030: error: method convertPivotStatisticsBucketsToPercentiles in class FacetComponent cannot be applied to given types; [javac] fi.pivotFacets = convertPivotStatisticsBucketsToPercentiles(fi.pivotFacets, solrParams); [javac]^ [javac] required: SimpleOrderedMapListNamedListObject,SolrParams [javac] found: SimpleOrderedMapPivotFacetWrapper,SolrParams [javac] reason: actual argument SimpleOrderedMapPivotFacetWrapper cannot be converted to SimpleOrderedMapListNamedListObject by method invocation conversion [javac] Note: /home/fangxu/projects/solr-4.6.0/solr/core/src/java/org/apache/solr/request/SimpleFacets.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error [javac] 1 warning FacetInfo fi.pivotFacets has been updated to SimpleOrderedMapPivotFacetWrapper in solr 4.6.0. which can not be applied with the current SOLR-3583. Please correct me if im wrong. Thanks a lot. was (Author: solrup): I resolved some failures of applying SOLR-2894. The I run this patch, still I got some failures. I fixed some. This one can be resolved, [javac] Compiling 7 source files to /home/fangxu/projects/solr-4.6.0/solr/build/solr-core/classes/java [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.6 [javac] /home/fangxu/projects/solr-4.6.0/solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java:1030: error: method convertPivotStatisticsBucketsToPercentiles in class FacetComponent cannot be applied to given types; [javac] fi.pivotFacets = convertPivotStatisticsBucketsToPercentiles(fi.pivotFacets, solrParams); [javac]^ [javac] required: SimpleOrderedMapListNamedListObject,SolrParams [javac] found: SimpleOrderedMapPivotFacetWrapper,SolrParams [javac] reason: actual argument SimpleOrderedMapPivotFacetWrapper cannot be converted to SimpleOrderedMapListNamedListObject by method invocation conversion [javac] Note: /home/fangxu/projects/solr-4.6.0/solr/core/src/java/org/apache/solr/request/SimpleFacets.java uses or overrides a deprecated API. [javac] Note: Recompile with -Xlint:deprecation for details. [javac] Note: Some input files use unchecked or unsafe operations. [javac] Note: Recompile with -Xlint:unchecked for details. [javac] 1 error [javac] 1 warning FacetInfo fi.pivotFacets has been updated to SimpleOrderedMapPivotFacetWrapper in solr 4.6.0. which can not be applied with the current SOLR-3583. Please correct me if im wrong. Thanks a lot. Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.7 Attachments: SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13837557#comment-13837557 ] Mansoor Ahmed edited comment on SOLR-3583 at 12/3/13 2:58 PM: -- Hi [~andrew.muldowney], [~selah], Thank you for the fantastic work. Any plans to commit this patch? Also, there was a request earlier to add sum, mean and other stats to this. Any possibility this can be done? Thank you. Mansoor was (Author: mansoor44ahme...@gmail.com): Hi Andrew, Chirs, Thank you for the fantastic work. Any plans to commit this patch? Also, there was a request earlier to add sum, mean and other stats to this. Any possibility this can be done? Thank you. Mansoor Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.6 Attachments: SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[
https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697441#comment-13697441
]
Otis Gospodnetic edited comment on SOLR-3583 at 7/2/13 2:54 AM:
That's a meaty 81K patch and juicy new functionality that, if I'm reading this
right, actually works with SolrCloud?
Solr 4.4 is in the works and it would be nice to get this in.
[~andrew.muldowney] [~selah] - I see a few new classes there. Could you
please add ASL to them?
Could you please re-indent to match the rest of the code? I think the rest of
the code uses 2 spaces...
Maybe also change stuff like:
{code}
if(PivotFacetHelper.getStatistics(toAddsPivotInfoClone)!=null){
{code}
to
{code}
if (PivotFacetHelper.getStatistics(toAddsPivotInfoClone) != null ) {
{code}
This will make it easier to read/review. Thanks!
was (Author: otis):
That's a meaty 81K patch and juicy new functionality that, if I'm reading
this right, actually works with SolrCloud?
[~andrew.muldowney] [~selah] - I see a few new classes there. Could you
please add ASL to them?
Could you please re-indent to match the rest of the code? I think the rest of
the code uses 2 spaces...
Maybe also change stuff like:
{code}
if(PivotFacetHelper.getStatistics(toAddsPivotInfoClone)!=null){
{code}
to
{code}
if (PivotFacetHelper.getStatistics(toAddsPivotInfoClone) != null ) {
{code}
This will make it easier to read/review. Thanks!
Percentiles for facets, pivot facets, and distributed pivot facets
--
Key: SOLR-3583
URL: https://issues.apache.org/jira/browse/SOLR-3583
Project: Solr
Issue Type: Improvement
Reporter: Chris Russell
Priority: Minor
Labels: newbie, patch
Fix For: 4.4
Attachments: SOLR-3583.patch, SOLR-3583.patch, SOLR-3583.patch,
SOLR-3583.patch
Built on top of SOLR-2894, this patch adds percentiles and averages to
facets, pivot facets, and distributed pivot facets by making use of range
facet internals.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507718#comment-13507718 ] Chris Russell edited comment on SOLR-3583 at 12/3/12 6:52 PM: -- Think I may have introduced a performance issue re:faceting, unit tests taking a lot longer to run. Am investigating. Nevermind, I was accidentally also running the Lucene tests. was (Author: selah): Think I may have introduced a performance issue re:faceting, unit tests taking a lot longer to run. Am investigating. Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.1 Attachments: SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507673#comment-13507673 ] Chris Russell edited comment on SOLR-3583 at 11/30/12 9:44 PM: --- Updated to trunk 1404975 You must first apply the 12th Nov 2012 version of SOLR-2894 which I updated to apply to the same version of trunk. was (Author: selah): Updated to trunk 1404975 Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.1 Attachments: SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507673#comment-13507673 ] Chris Russell edited comment on SOLR-3583 at 11/30/12 9:46 PM: --- Updated to trunk 1404975 You must first apply the 12th Nov 2012 version of SOLR-2894 which I updated to apply to the same version of trunk. Based on some changes that I had to work around while updating to trunk, I feel that this will not work properly with facet.missing=true. I am working on correcting this. was (Author: selah): Updated to trunk 1404975 You must first apply the 12th Nov 2012 version of SOLR-2894 which I updated to apply to the same version of trunk. Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.1 Attachments: SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Comment Edited] (SOLR-3583) Percentiles for facets, pivot facets, and distributed pivot facets
[ https://issues.apache.org/jira/browse/SOLR-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13507673#comment-13507673 ] Chris Russell edited comment on SOLR-3583 at 11/30/12 9:47 PM: --- Updated to trunk 1404975 Disentangled from SOLR-2894. This patch no longer includes that patch. You must first apply the 12th Nov 2012 version of SOLR-2894 which I updated to apply to the same version of trunk before applying this patch. Based on some changes that I had to work around while updating to trunk, I feel that this will not work properly with facet.missing=true. I am working on correcting this. (Pivot facets changed somewhat significantly in the interim.) was (Author: selah): Updated to trunk 1404975 You must first apply the 12th Nov 2012 version of SOLR-2894 which I updated to apply to the same version of trunk. Based on some changes that I had to work around while updating to trunk, I feel that this will not work properly with facet.missing=true. I am working on correcting this. Percentiles for facets, pivot facets, and distributed pivot facets -- Key: SOLR-3583 URL: https://issues.apache.org/jira/browse/SOLR-3583 Project: Solr Issue Type: Improvement Reporter: Chris Russell Priority: Minor Labels: newbie, patch Fix For: 4.1 Attachments: SOLR-3583.patch, SOLR-3583.patch Built on top of SOLR-2894, this patch adds percentiles and averages to facets, pivot facets, and distributed pivot facets by making use of range facet internals. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
