[jira] [Comment Edited] (SOLR-7435) NPE in FieldCollapsingQParser

2015-09-08 Thread Brandon Chapman (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735003#comment-14735003
 ] 

Brandon Chapman edited comment on SOLR-7435 at 9/8/15 3:40 PM:
---

[~joel.bernstein], this also sometimes works sometimes gets an exception for me 
in Solr 4.10.3.

{code}



{code}
{code}
{
  "responseHeader": {
"status": 500,
"QTime": 89,
"params": {
  "facet": "true",
  "fl": "psid, bsin, groupId, sku, merchant",
  "indent": "true",
  "q": "type_s:parent",
  "_": "1441726236828",
  "facet.field": "bsin",
  "wt": "json",
  "fq": [
"{!collapse field=groupId  min=sourceRank cost=201}",
"{!collapse field=merchant cost=200}"
  ],
  "rows": "10"
}
  },
  "error": {
"trace": "java.lang.NullPointerException\n\tat 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingFieldValueCollector.finish(CollapsingQParserPlugin.java:632)\n\tat
 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingScoreCollector.finish(CollapsingQParserPlugin.java:525)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSetScore(SolrIndexSearcher.java:918)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:938)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1366)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:514)\n\tat
 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:484)\n\tat
 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:218)\n\tat
 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)\n\tat
 org.apache.solr.core.SolrCore.execute(SolrCore.java:1976)\n\tat 
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:777)\n\tat
 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:418)\n\tat
 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:207)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)\n\tat
 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)\n\tat
 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)\n\tat
 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)\n\tat
 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)\n\tat
 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)\n\tat 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)\n\tat
 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)\n\tat
 
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1002)\n\tat
 
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585)\n\tat
 
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)\n\tat
 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)\n\tat
 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)\n\tat
 java.lang.Thread.run(Thread.java:744)\n",
"code": 500
  }
}
{code}


was (Author: bchapman):
[~joel.bernstein], this also sometimes works sometimes gets an exception for me 
in Solr 4.10.3.

{code}


   
{code}
{code}
{
  "responseHeader": {
"status": 500,
"QTime": 89,
"params": {
  "facet": "true",
  "fl": "psid, bsin, groupId, sku, merchant",
  "indent": "true",
  "q": "type_s:parent",
  "_": "1441726236828",
  "facet.field": "bsin",
  "wt": "json",
  "fq": [
"{!collapse field=groupId  min=sourceRank cost=201}",
"{!collapse field=merchant cost=200}"
  ],
  "rows": "10"
}
  },
  "error": {
"trace": "java.lang.NullPointerException\n\tat 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingFieldValueCollector.finish(CollapsingQParserPlugin.java:632)\n\tat
 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingScoreCollector.finish(CollapsingQParserPlugin.java:525)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSetScore(SolrIndexSearcher.java:918)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:938)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1366)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:514)\n\tat
 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:484)\n\tat
 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:218)\n\tat
 

[jira] [Comment Edited] (SOLR-7435) NPE in FieldCollapsingQParser

2015-09-08 Thread Brandon Chapman (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14735003#comment-14735003
 ] 

Brandon Chapman edited comment on SOLR-7435 at 9/8/15 3:40 PM:
---

[~joel.bernstein], this also sometimes works sometimes gets an exception for me 
in Solr 4.10.3.

{code}


   
{code}
{code}
{
  "responseHeader": {
"status": 500,
"QTime": 89,
"params": {
  "facet": "true",
  "fl": "psid, bsin, groupId, sku, merchant",
  "indent": "true",
  "q": "type_s:parent",
  "_": "1441726236828",
  "facet.field": "bsin",
  "wt": "json",
  "fq": [
"{!collapse field=groupId  min=sourceRank cost=201}",
"{!collapse field=merchant cost=200}"
  ],
  "rows": "10"
}
  },
  "error": {
"trace": "java.lang.NullPointerException\n\tat 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingFieldValueCollector.finish(CollapsingQParserPlugin.java:632)\n\tat
 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingScoreCollector.finish(CollapsingQParserPlugin.java:525)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSetScore(SolrIndexSearcher.java:918)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:938)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1366)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:514)\n\tat
 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:484)\n\tat
 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:218)\n\tat
 
org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:135)\n\tat
 org.apache.solr.core.SolrCore.execute(SolrCore.java:1976)\n\tat 
org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:777)\n\tat
 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:418)\n\tat
 
org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:207)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)\n\tat
 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)\n\tat
 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)\n\tat
 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)\n\tat
 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168)\n\tat
 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)\n\tat
 
org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:929)\n\tat 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)\n\tat
 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)\n\tat
 
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1002)\n\tat
 
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585)\n\tat
 
org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310)\n\tat
 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)\n\tat
 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)\n\tat
 java.lang.Thread.run(Thread.java:744)\n",
"code": 500
  }
}
{code}


was (Author: bchapman):
[~joel.bernstein], this also sometimes works sometimes gets an exception for me 
in Solr 4.10.3.

{code}
{
  "responseHeader": {
"status": 500,
"QTime": 89,
"params": {
  "facet": "true",
  "fl": "psid, bsin, groupId, sku, merchant",
  "indent": "true",
  "q": "type_s:parent",
  "_": "1441726236828",
  "facet.field": "bsin",
  "wt": "json",
  "fq": [
"{!collapse field=groupId  min=sourceRank cost=201}",
"{!collapse field=merchant cost=200}"
  ],
  "rows": "10"
}
  },
  "error": {
"trace": "java.lang.NullPointerException\n\tat 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingFieldValueCollector.finish(CollapsingQParserPlugin.java:632)\n\tat
 
org.apache.solr.search.CollapsingQParserPlugin$CollapsingScoreCollector.finish(CollapsingQParserPlugin.java:525)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSetScore(SolrIndexSearcher.java:918)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocSet(SolrIndexSearcher.java:938)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1366)\n\tat
 
org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:514)\n\tat
 
org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:484)\n\tat
 
org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:218)\n\tat
 

[jira] [Comment Edited] (SOLR-7435) NPE in FieldCollapsingQParser

2015-05-04 Thread Markus Jelsma (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14526501#comment-14526501
 ] 

Markus Jelsma edited comment on SOLR-7435 at 5/4/15 2:58 PM:
-

Hi [~joel.bernstein], can you try the following unit test?

{code}
  @Test
  public void testSOLR7435() throws Exception {
for (int i = 0; i  15000; i++) {
  String[] doc = {id, String.valueOf(i) , a_i, 
String.valueOf(random().nextInt(1)), b_i, 
String.valueOf(random().nextInt(1))};
  assertU(adoc(doc));
}

assertU(commit());

ModifiableSolrParams params = new ModifiableSolrParams();
params.add(q, *:*);
params.add(fq, {!collapse field=a_i});
params.add(fq, {!collapse field=b_i});
assertQ(req(params, indent, on), *[count(//doc)=0]);
  }
{code}

It fails on my machine using: ant test  -Dtestcase=TestCollapseQParserPlugin 
-Dtests.method=testSOLR7435 -Dtests.seed=2B7D48BE88DE05E7 -Dtests.slow=true 
-Dtests.locale=en_ZA -Dtests.timezone=America/Araguaina -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII

edit: hmm, it sometimes failes.


was (Author: markus17):
Hi [~joel.bernstein], can you try the following unit test?

{code}
  @Test
  public void testSOLR7435() throws Exception {
for (int i = 0; i  15000; i++) {
  String[] doc = {id, String.valueOf(i) , a_i, 
String.valueOf(random().nextInt(1)), b_i, 
String.valueOf(random().nextInt(1))};
  assertU(adoc(doc));
}

assertU(commit());

ModifiableSolrParams params = new ModifiableSolrParams();
params.add(q, *:*);
params.add(fq, {!collapse field=a_i});
params.add(fq, {!collapse field=b_i});
assertQ(req(params, indent, on), *[count(//doc)=0]);
  }
{code}

It fails on my machine using: ant test  -Dtestcase=TestCollapseQParserPlugin 
-Dtests.method=testSOLR7435 -Dtests.seed=2B7D48BE88DE05E7 -Dtests.slow=true 
-Dtests.locale=en_ZA -Dtests.timezone=America/Araguaina -Dtests.asserts=true 
-Dtests.file.encoding=US-ASCII


 NPE in FieldCollapsingQParser
 -

 Key: SOLR-7435
 URL: https://issues.apache.org/jira/browse/SOLR-7435
 Project: Solr
  Issue Type: Bug
Affects Versions: 5.1
Reporter: Markus Jelsma
Priority: Minor
 Fix For: 5.2


 Not even sure it would work anyway, i tried to collapse on two distinct 
 fields, ending up with this:
 select?q=*:*fq={!collapse field=qst}fq={!collapse field=rdst}
 {code}
 584550 [qtp1121454968-20] ERROR org.apache.solr.servlet.SolrDispatchFilter  [ 
   suggests] – null:java.lang.NullPointerException
 at 
 org.apache.solr.search.CollapsingQParserPlugin$IntScoreCollector.finish(CollapsingQParserPlugin.java:743)
 at 
 org.apache.solr.search.CollapsingQParserPlugin$IntScoreCollector.finish(CollapsingQParserPlugin.java:780)
 at 
 org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:203)
 at 
 org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1660)
 at 
 org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1479)
 at 
 org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:556)
 at 
 org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:518)
 at 
 org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:222)
 at 
 org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143)
 at org.apache.solr.core.SolrCore.execute(SolrCore.java:1984)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:829)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:446)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:220)
 at 
 org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
 at 
 org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
 at 
 org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
 at 
 org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
 at 
 org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
 at 
 org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
 at 
 org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
 at 
 org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
 at 
 org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
 at 
 org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
 at 
 

[jira] [Comment Edited] (SOLR-7435) NPE in FieldCollapsingQParser

2015-04-22 Thread Joel Bernstein (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-7435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14507766#comment-14507766
 ] 

Joel Bernstein edited comment on SOLR-7435 at 4/22/15 7:57 PM:
---

Just tested out the following query:
{code}
http://localhost:8983/solr/sample/select?q=id:doc*wt=jsonindent=truefq={!collapse%20field=group_i}fq={!collapse%20field=group1_i}
{code}
On a very small index this worked for me. Then I optimized the index to see if 
the issue only occurred on a single segment and it still worked for me.

I haven't done any testing on this scenario before but in theory it should 
work. And you should be able to control the order of the collapses with the 
cost parameter.

The exception was coming from a collapse on an integer field using the score to 
select the group head. So that's what I tested with.

The specific numeric collapse support is new in 5.0 so it would not surprise me 
if there were some things that needed to be ironed out.


was (Author: joel.bernstein):
Just tested out the following query:

http://localhost:8983/solr/sample/select?q=id:doc*wt=jsonindent=truefq={!collapse%20field=group_i}fq={!collapse%20field=group1_i}

On a very small index this worked for me. Then I optimized the index to see if 
the issue only occurred on a single segment and it still worked for me.

I haven't done any testing on this scenario before but in theory it should 
work. And you should be able to control the order of the collapses with the 
cost parameter.

The exception was coming from a collapse on an integer field using the score to 
select the group head. So that's what I tested with.

The specific numeric collapse support is new in 5.0 so it would not surprise me 
if there were some things that needed to be ironed out.

 NPE in FieldCollapsingQParser
 -

 Key: SOLR-7435
 URL: https://issues.apache.org/jira/browse/SOLR-7435
 Project: Solr
  Issue Type: Bug
Affects Versions: 5.1
Reporter: Markus Jelsma
Priority: Minor
 Fix For: 5.2


 Not even sure it would work anyway, i tried to collapse on two distinct 
 fields, ending up with this:
 select?q=*:*fq={!collapse field=qst}fq={!collapse field=rdst}
 {code}
 584550 [qtp1121454968-20] ERROR org.apache.solr.servlet.SolrDispatchFilter  [ 
   suggests] – null:java.lang.NullPointerException
 at 
 org.apache.solr.search.CollapsingQParserPlugin$IntScoreCollector.finish(CollapsingQParserPlugin.java:743)
 at 
 org.apache.solr.search.CollapsingQParserPlugin$IntScoreCollector.finish(CollapsingQParserPlugin.java:780)
 at 
 org.apache.solr.search.SolrIndexSearcher.buildAndRunCollectorChain(SolrIndexSearcher.java:203)
 at 
 org.apache.solr.search.SolrIndexSearcher.getDocListNC(SolrIndexSearcher.java:1660)
 at 
 org.apache.solr.search.SolrIndexSearcher.getDocListC(SolrIndexSearcher.java:1479)
 at 
 org.apache.solr.search.SolrIndexSearcher.search(SolrIndexSearcher.java:556)
 at 
 org.apache.solr.handler.component.QueryComponent.process(QueryComponent.java:518)
 at 
 org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:222)
 at 
 org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:143)
 at org.apache.solr.core.SolrCore.execute(SolrCore.java:1984)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.execute(SolrDispatchFilter.java:829)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:446)
 at 
 org.apache.solr.servlet.SolrDispatchFilter.doFilter(SolrDispatchFilter.java:220)
 at 
 org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1419)
 at 
 org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:455)
 at 
 org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
 at 
 org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
 at 
 org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
 at 
 org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1075)
 at 
 org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:384)
 at 
 org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
 at 
 org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1009)
 at 
 org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
 at 
 org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
 at 
 org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
 at