[ https://issues.apache.org/jira/browse/SOLR-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445033#comment-16445033 ]
Shawn Heisey edited comment on SOLR-9613 at 4/20/18 12:13 AM: -------------------------------------------------------------- SOLR-11933 unchecked the clean checkbox by default for both import types. I don't think that was the right thing to do. [~msporleder]'s idea seems much better to me. I think we should re-open this issue and implement it. What does everyone think about this: If the user has actually clicked on the clean checkbox, set a flag that so that the checkbox will remain in the selected state even if the import type is changed. was (Author: elyograg): SOLR-11933 unchecked the clean checkbox by default for both import types. I don't think that was the right thing to do. [~msporleder]'s idea seems much better to me. I think we should re-open this issue and implement it. A better option would be to update the checkbox to the value appropriate for the type of import selected. What does everyone think about this: If the user has actually clicked on the clean checkbox, set a flag that so that the checkbox will remain in the selected state even if the import type is changed. > core or collection -> dataimport dangerous default > -------------------------------------------------- > > Key: SOLR-9613 > URL: https://issues.apache.org/jira/browse/SOLR-9613 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) > Components: Admin UI > Reporter: Matthew Sporleder > Assignee: Alexandre Rafalovitch > Priority: Major > Fix For: 7.3 > > > When browsing to dataimport in the web gui and selecting "delta-import" from > the drop down, the "full-import" checkbox selections stay checked, including > "clean", which is very dangerous for a delta-import, as it deletes most of > your data! > a js event to clear those checkboxes on selection from that dropdown would > save a lot of accidental anguish. > {code} > var foo = document.getElementById("command") > function bar() { document.getElementById("clean").checked = false; } > foo.onchange = function() { > if (foo.value == "delta-import") > { > bar(); > } > }; > {code} > or whatever -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org