[jira] [Comment Edited] (SOLR-9867) The Solr examples can not always be started after being stopped due to race with loading core.

2017-05-04 Thread Mikhail Khludnev (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15997496#comment-15997496
 ] 

Mikhail Khludnev edited comment on SOLR-9867 at 5/4/17 9:55 PM:


[^6x failure 0 docs.txt]
https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Linux/3438/consoleFull
{code}
   [junit4]   2> 2187212 INFO  (qtp33229559-24974) [] o.a.s.s.HttpSolrCall 
[admin] webapp=null path=/admin/cores 
params={name=techproducts=CREATE=techproducts=json} 
status=0 QTime=822
   [junit4]   1> SimplePostTool version 5.0.0
   [junit4]   1> Posting files to [base] url 
http://localhost:36619/solr/techproducts/update using content-type 
application/xml...
...
   [junit4]   1> 14 files indexed.
   [junit4]   1> COMMITting Solr index changes to 
http://localhost:36619/solr/techproducts/update...
   [junit4]   1> Time spent: 0:00:00.017
   [junit4]   2> 2187234 INFO  (qtp33229559-24974) [] o.a.s.c.S.Request 
[techproducts]  webapp=/solr path=/select params={q=*:*=javabin=2} 
hits=0 status=0 QTime=0
   [junit4]   2> 2187234 WARN  
(TEST-TestSolrCLIRunExample.testTechproductsExample-seed#[6C573D0F56B69777]) [  
  ] o.a.s.u.TestSolrCLIRunExample Going to wait for 1 second before re-trying 
query for techproduct example docs ...
   [junit4]   2> 2188237 INFO  (qtp33229559-24972) [] o.a.s.c.S.Request 
[techproducts]  webapp=/solr path=/select params={q=*:*=javabin=2} 
hits=0 status=0 QTime=0
   [junit4]   2> 2188237 INFO  
(TEST-TestSolrCLIRunExample.testTechproductsExample-seed#[6C573D0F56B69777]) [  
  ] o.a.s.SolrTestCaseJ4 ###Ending testTechproductsExample

Throwable #1: java.lang.AssertionError: expected 32 docs in the techproducts 
example but found 0,
{code}
Updates come in 17 ms and left no update activity log. What is it? 


was (Author: mkhludnev):
[^6x failure 0 docs.txt]
https://jenkins.thetaphi.de/job/Lucene-Solr-6.x-Linux/3438/consoleFull
{code}
   [junit4]   2> 2187212 INFO  (qtp33229559-24974) [] o.a.s.s.HttpSolrCall 
[admin] webapp=null path=/admin/cores 
params={name=techproducts=CREATE=techproducts=json} 
status=0 QTime=822
   [junit4]   1> SimplePostTool version 5.0.0
   [junit4]   1> Posting files to [base] url 
http://localhost:36619/solr/techproducts/update using content-type 
application/xml...
...
   [junit4]   1> 14 files indexed.
   [junit4]   1> COMMITting Solr index changes to 
http://localhost:36619/solr/techproducts/update...
   [junit4]   1> Time spent: 0:00:00.017
   [junit4]   2> 2187234 INFO  (qtp33229559-24974) [] o.a.s.c.S.Request 
[techproducts]  webapp=/solr path=/select params={q=*:*=javabin=2} 
hits=0 status=0 QTime=0
   [junit4]   2> 2187234 WARN  
(TEST-TestSolrCLIRunExample.testTechproductsExample-seed#[6C573D0F56B69777]) [  
  ] o.a.s.u.TestSolrCLIRunExample Going to wait for 1 second before re-trying 
query for techproduct example docs ...
   [junit4]   2> 2188237 INFO  (qtp33229559-24972) [] o.a.s.c.S.Request 
[techproducts]  webapp=/solr path=/select params={q=*:*=javabin=2} 
hits=0 status=0 QTime=0
   [junit4]   2> 2188237 INFO  
(TEST-TestSolrCLIRunExample.testTechproductsExample-seed#[6C573D0F56B69777]) [  
  ] o.a.s.SolrTestCaseJ4 ###Ending testTechproductsExample
{code}
Updates come in 17 ms and left no update activity log. What is it? 

> The Solr examples can not always be started after being stopped due to race 
> with loading core.
> --
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Mark Miller
>Assignee: Mikhail Khludnev
>Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: 6x failure 0 docs.txt, Lucene-Solr-master-MacOSX #3986 
> Console [Jenkins].htm, SDF init and doFilter in parallel.png, 
> SOLR-9867-createCoreContainer-fix.patch, SOLR-9867-ignore-whitespace.patch, 
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, 
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, SOLR-9867-test.patch, 
> stdout_90
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an 
> error when it tries to create the SolrCore (again, it already exists) and so 
> it deletes the cores instance dir which leads to tlog and index lock errors 
> in Solr.
> The reason it seems to be trying to create the core when it already exists is 
> that the run example tool uses a core status call to check existence and 
> because the core is loading, we don't consider it as existing. I added a 
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because 

[jira] [Comment Edited] (SOLR-9867) The Solr examples can not always be started after being stopped due to race with loading core.

2017-05-04 Thread Andrey Kudryavtsev (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996760#comment-15996760
 ] 

Andrey Kudryavtsev edited comment on SOLR-9867 at 5/4/17 2:01 PM:
--

But what if we, [you 
know|https://issues.apache.org/jira/secure/attachment/12866408/SOLR-9867.patch]

{code}
-  private void setupJvmMetrics()  {
+  private void setupJvmMetrics(CoreContainer cores)  {
 SolrMetricManager metricManager = cores.getMetricManager();
 final Set hiddenSysProps = cores.getConfig().getHiddenSysProps();
 try {
@@ -247,7 +247,7 @@ public class SolrDispatchFilter extends BaseSolrFilter {
*/
   protected CoreContainer createCoreContainer(Path solrHome, Properties 
extraProperties) {
 NodeConfig nodeConfig = loadNodeConfig(solrHome, extraProperties);
-cores = new CoreContainer(nodeConfig, extraProperties, true);
+CoreContainer cores = new CoreContainer(nodeConfig, extraProperties, true);
 cores.load();
 return cores;
   }
{code}


was (Author: werder):
But what if we, you know

{code}
-  private void setupJvmMetrics()  {
+  private void setupJvmMetrics(CoreContainer cores)  {
 SolrMetricManager metricManager = cores.getMetricManager();
 final Set hiddenSysProps = cores.getConfig().getHiddenSysProps();
 try {
@@ -247,7 +247,7 @@ public class SolrDispatchFilter extends BaseSolrFilter {
*/
   protected CoreContainer createCoreContainer(Path solrHome, Properties 
extraProperties) {
 NodeConfig nodeConfig = loadNodeConfig(solrHome, extraProperties);
-cores = new CoreContainer(nodeConfig, extraProperties, true);
+CoreContainer cores = new CoreContainer(nodeConfig, extraProperties, true);
 cores.load();
 return cores;
   }
{code}

> The Solr examples can not always be started after being stopped due to race 
> with loading core.
> --
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Mark Miller
>Assignee: Mikhail Khludnev
>Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: Lucene-Solr-master-MacOSX #3986 Console [Jenkins].htm, 
> SDF init and doFilter in parallel.png, 
> SOLR-9867-createCoreContainer-fix.patch, SOLR-9867-ignore-whitespace.patch, 
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, 
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867-test.patch, stdout_90
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an 
> error when it tries to create the SolrCore (again, it already exists) and so 
> it deletes the cores instance dir which leads to tlog and index lock errors 
> in Solr.
> The reason it seems to be trying to create the core when it already exists is 
> that the run example tool uses a core status call to check existence and 
> because the core is loading, we don't consider it as existing. I added a 
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because the core 
> was still loading. It appears CoreContainer#getCore  is supposed to be 
> blocking so you don't have this problem, but there must be an issue, because 
> it is not blocking.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-9867) The Solr examples can not always be started after being stopped due to race with loading core.

2017-05-03 Thread Erick Erickson (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995053#comment-15995053
 ] 

Erick Erickson edited comment on SOLR-9867 at 5/3/17 3:26 PM:
--

got the patch, I'm starting to give it a beast run. I notice that you also 
changed TestSolrCLIRunExample but I'm beasting SolrCloudExampleTest. Let me 
know if I should beast TestSolrCLIRunExample instead.


was (Author: erickerickson):
got the patch, I'm starting to give it a beast run.

> The Solr examples can not always be started after being stopped due to race 
> with loading core.
> --
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Mark Miller
>Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: SDF init and doFilter in parallel.png, 
> SOLR-9867-ignore-whitespace.patch, SOLR-9867.patch, SOLR-9867.patch, 
> SOLR-9867.patch, SOLR-9867.patch, SOLR-9867.patch, SOLR-9867-test.patch
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an 
> error when it tries to create the SolrCore (again, it already exists) and so 
> it deletes the cores instance dir which leads to tlog and index lock errors 
> in Solr.
> The reason it seems to be trying to create the core when it already exists is 
> that the run example tool uses a core status call to check existence and 
> because the core is loading, we don't consider it as existing. I added a 
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because the core 
> was still loading. It appears CoreContainer#getCore  is supposed to be 
> blocking so you don't have this problem, but there must be an issue, because 
> it is not blocking.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Comment Edited] (SOLR-9867) The Solr examples can not always be started after being stopped due to race with loading core.

2017-04-28 Thread Mikhail Khludnev (JIRA)

[ 
https://issues.apache.org/jira/browse/SOLR-9867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15989383#comment-15989383
 ] 

Mikhail Khludnev edited comment on SOLR-9867 at 4/28/17 9:17 PM:
-

[^SOLR-9867-test.patch] enabling existing test (Thank's to [~thelabdude], it's 
was an enormous effort, Tim!).
Ok. {{CoreAdminOperation.getCoreStatus(CoreContainer, String, boolean)}} is 
completely ignorant to {{CoreContainer.isCoreLoading(String)}}, I can explain 
this. It's ok. 


was (Author: mkhludnev):
[^SOLR-9867-test,patch] enabling existing test (Thank's to [~thelabdude], it's 
was an enormous effort, Tim!), I'm sorry for the comma.
Ok. {{CoreAdminOperation.getCoreStatus(CoreContainer, String, boolean)}} is 
completely ignorant to {{CoreContainer.isCoreLoading(String)}}, I can explain 
this. It's ok. 

> The Solr examples can not always be started after being stopped due to race 
> with loading core.
> --
>
> Key: SOLR-9867
> URL: https://issues.apache.org/jira/browse/SOLR-9867
> Project: Solr
>  Issue Type: Bug
>  Security Level: Public(Default Security Level. Issues are Public) 
>Reporter: Mark Miller
>Priority: Critical
> Fix For: 6.6, master (7.0)
>
> Attachments: SDF init and doFilter in parallel.png, SOLR-9867.patch, 
> SOLR-9867.patch, SOLR-9867-test.patch
>
>
> I'm having trouble when I start up the schemaless example after shutting down.
> I first tracked this down to the fact that the run example tool is getting an 
> error when it tries to create the SolrCore (again, it already exists) and so 
> it deletes the cores instance dir which leads to tlog and index lock errors 
> in Solr.
> The reason it seems to be trying to create the core when it already exists is 
> that the run example tool uses a core status call to check existence and 
> because the core is loading, we don't consider it as existing. I added a 
> check to look for core.properties.
> That seemed to let me start up, but my first requests failed because the core 
> was still loading. It appears CoreContainer#getCore  is supposed to be 
> blocking so you don't have this problem, but there must be an issue, because 
> it is not blocking.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org