[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793615#comment-13793615 ] ASF subversion and git services commented on LUCENE-5260: - Commit 1531667 from [~mikemccand] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531667 ] LUCENE-5260: don't use java7-only API > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > Fix For: 4.6, 5.0 > > Attachments: LUCENE-5260.patch, LUCENE-5260.patch > > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793609#comment-13793609 ] ASF subversion and git services commented on LUCENE-5260: - Commit 1531666 from [~mikemccand] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1531666 ] LUCENE-5260: cutover all suggesters to TermFreqPayloadIterator > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > Fix For: 4.6, 5.0 > > Attachments: LUCENE-5260.patch, LUCENE-5260.patch > > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793607#comment-13793607 ] ASF subversion and git services commented on LUCENE-5260: - Commit 1531664 from [~mikemccand] in branch 'dev/trunk' [ https://svn.apache.org/r1531664 ] LUCENE-5260: cutover all suggesters to TermFreqPayloadIterator > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > Attachments: LUCENE-5260.patch, LUCENE-5260.patch > > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13792662#comment-13792662 ] Michael McCandless commented on LUCENE-5260: Thanks Areek, patch looks great! I like the hasPayloads() up-front introspection. In UnsortedTermFreqIteratorWrapper.payload(), why do we set currentOrd as a side effect? Shouldn't next() already do that? Maybe, we should instead assert currentOrd == ords[curPos]? Also, can we break that sneaky currentOrd assignment in next into its own line before? > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > Attachments: LUCENE-5260.patch > > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13790075#comment-13790075 ] Areek Zillur commented on LUCENE-5260: -- Hey Michael, I was thinking about how to nicely replace TermFreqIterator. - I was thinking about having some kind of wrapper for TermFreqPayloadIterator that will nullify the payload field for the current TermFreqIterator consumers and a way for the wrapper to signal early on to the consumers that they dont need to deal with the payload at all. - Also It seems like there are a lot of implementations for TermFreqIterator (e.g BufferedTermFreqIteratorWrapper, SortedTermFreqIteratorWrapper); I will make sure all these implementation work with TermFreqPayloadIterator and its new wrapper (for mimicking TermFreqIterator). Any thoughts? I will try to come up with a rough patch soon. > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5260) Make older Suggesters more accepting of TermFreqPayloadIterator
[ https://issues.apache.org/jira/browse/LUCENE-5260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788165#comment-13788165 ] Michael McCandless commented on LUCENE-5260: +1 It seems like we should remove TermFreqIterator, and only keep TermFreqPayloadIterator. > Make older Suggesters more accepting of TermFreqPayloadIterator > --- > > Key: LUCENE-5260 > URL: https://issues.apache.org/jira/browse/LUCENE-5260 > Project: Lucene - Core > Issue Type: Improvement > Components: core/search >Reporter: Areek Zillur > > As discussed in https://issues.apache.org/jira/browse/LUCENE-5251, it would > be nice to make the older suggesters accepting of TermFreqPayloadIterator and > throw an exception if payload is found (if it cannot be used). > This will also allow us to nuke most of the other interfaces for > BytesRefIterator. -- This message was sent by Atlassian JIRA (v6.1#6144) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
