[jira] [Commented] (LUCENE-5390) Loosen assert in IW on pending event after close
[ https://issues.apache.org/jira/browse/LUCENE-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13866979#comment-13866979 ] Michael McCandless commented on LUCENE-5390: +1 Loosen assert in IW on pending event after close Key: LUCENE-5390 URL: https://issues.apache.org/jira/browse/LUCENE-5390 Project: Lucene - Core Issue Type: Task Affects Versions: 4.6, 5.0, 4.7, 4.6.1 Reporter: Simon Willnauer Priority: Minor Fix For: 5.0, 4.7, 4.6.1 Attachments: LUCENE-5390.patch Sometimes the assert in the IW is tripped due to pending merge events. Those events can always happen but they are meaningless since we close / rollback the IW anyway. I suggest we loosen the assert here to not fail if there are only pending merge events. noformat 1 tests failed. REGRESSION: org.apache.lucene.index.TestIndexWriterWithThreads.testRollbackAndCommitWithThreads Error Message: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Stack Trace: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Caused by: java.lang.RuntimeException: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at __randomizedtesting.SeedInfo.seed([98DFB1602D9F9A2A]:0) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:619) Caused by: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at org.apache.lucene.index.IndexWriter.rollback(IndexWriter.java:2026) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:575) /noformat -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5390) Loosen assert in IW on pending event after close
[ https://issues.apache.org/jira/browse/LUCENE-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867016#comment-13867016 ] ASF subversion and git services commented on LUCENE-5390: - Commit 1556942 from [~simonw] in branch 'dev/trunk' [ https://svn.apache.org/r1556942 ] LUCENE-5390: Loosen assert in IW on pending event after close Loosen assert in IW on pending event after close Key: LUCENE-5390 URL: https://issues.apache.org/jira/browse/LUCENE-5390 Project: Lucene - Core Issue Type: Task Affects Versions: 4.6, 5.0, 4.7, 4.6.1 Reporter: Simon Willnauer Priority: Minor Fix For: 5.0, 4.7, 4.6.1 Attachments: LUCENE-5390.patch Sometimes the assert in the IW is tripped due to pending merge events. Those events can always happen but they are meaningless since we close / rollback the IW anyway. I suggest we loosen the assert here to not fail if there are only pending merge events. noformat 1 tests failed. REGRESSION: org.apache.lucene.index.TestIndexWriterWithThreads.testRollbackAndCommitWithThreads Error Message: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Stack Trace: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Caused by: java.lang.RuntimeException: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at __randomizedtesting.SeedInfo.seed([98DFB1602D9F9A2A]:0) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:619) Caused by: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at org.apache.lucene.index.IndexWriter.rollback(IndexWriter.java:2026) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:575) /noformat -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5390) Loosen assert in IW on pending event after close
[ https://issues.apache.org/jira/browse/LUCENE-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867033#comment-13867033 ] ASF subversion and git services commented on LUCENE-5390: - Commit 1556947 from [~simonw] in branch 'dev/branches/branch_4x' [ https://svn.apache.org/r1556947 ] LUCENE-5390: Loosen assert in IW on pending event after close Loosen assert in IW on pending event after close Key: LUCENE-5390 URL: https://issues.apache.org/jira/browse/LUCENE-5390 Project: Lucene - Core Issue Type: Task Affects Versions: 4.6, 5.0, 4.7, 4.6.1 Reporter: Simon Willnauer Priority: Minor Fix For: 5.0, 4.7, 4.6.1 Attachments: LUCENE-5390.patch Sometimes the assert in the IW is tripped due to pending merge events. Those events can always happen but they are meaningless since we close / rollback the IW anyway. I suggest we loosen the assert here to not fail if there are only pending merge events. noformat 1 tests failed. REGRESSION: org.apache.lucene.index.TestIndexWriterWithThreads.testRollbackAndCommitWithThreads Error Message: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Stack Trace: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Caused by: java.lang.RuntimeException: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at __randomizedtesting.SeedInfo.seed([98DFB1602D9F9A2A]:0) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:619) Caused by: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at org.apache.lucene.index.IndexWriter.rollback(IndexWriter.java:2026) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:575) /noformat -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5390) Loosen assert in IW on pending event after close
[ https://issues.apache.org/jira/browse/LUCENE-5390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13867074#comment-13867074 ] ASF subversion and git services commented on LUCENE-5390: - Commit 1556956 from [~simonw] in branch 'dev/branches/lucene_solr_4_6' [ https://svn.apache.org/r1556956 ] LUCENE-5390: Loosen assert in IW on pending event after close Loosen assert in IW on pending event after close Key: LUCENE-5390 URL: https://issues.apache.org/jira/browse/LUCENE-5390 Project: Lucene - Core Issue Type: Task Affects Versions: 4.6, 5.0, 4.7, 4.6.1 Reporter: Simon Willnauer Priority: Minor Fix For: 5.0, 4.7, 4.6.1 Attachments: LUCENE-5390.patch Sometimes the assert in the IW is tripped due to pending merge events. Those events can always happen but they are meaningless since we close / rollback the IW anyway. I suggest we loosen the assert here to not fail if there are only pending merge events. noformat 1 tests failed. REGRESSION: org.apache.lucene.index.TestIndexWriterWithThreads.testRollbackAndCommitWithThreads Error Message: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Stack Trace: com.carrotsearch.randomizedtesting.UncaughtExceptionError: Captured an uncaught exception in thread: Thread[id=288, name=Thread-222, state=RUNNABLE, group=TGRP-TestIndexWriterWithThreads] Caused by: java.lang.RuntimeException: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at __randomizedtesting.SeedInfo.seed([98DFB1602D9F9A2A]:0) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:619) Caused by: java.lang.AssertionError: [org.apache.lucene.index.DocumentsWriter$MergePendingEvent@67ef293b] at org.apache.lucene.index.IndexWriter.rollback(IndexWriter.java:2026) at org.apache.lucene.index.TestIndexWriterWithThreads$1.run(TestIndexWriterWithThreads.java:575) /noformat -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
