[jira] [Commented] (LUCENE-5392) Documentation for modified token / analysis pipeline
[ https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13876565#comment-13876565 ] ASF subversion and git services commented on LUCENE-5392: - Commit 1559773 from [~gsingers] in branch 'dev/trunk' [ https://svn.apache.org/r1559773 ] LUCENE-5392: make ShingleAnalyzerWrapper.getWrappedAnalyzer() public final > Documentation for modified token / analysis pipeline > > > Key: LUCENE-5392 > URL: https://issues.apache.org/jira/browse/LUCENE-5392 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 5.0 >Reporter: Benson Margulies > Fix For: 5.0 > > > The changes to the tokenizer and analyzer need to be reflected in the package > overview for core analysis. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5392) Documentation for modified token / analysis pipeline
[ https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867921#comment-13867921 ] ASF subversion and git services commented on LUCENE-5392: - Commit 1557158 from [~rcmuir] in branch 'dev/trunk' [ https://svn.apache.org/r1557158 ] LUCENE-5392: add/improve analysis package docs to reflect API changes in trunk (closes #17) > Documentation for modified token / analysis pipeline > > > Key: LUCENE-5392 > URL: https://issues.apache.org/jira/browse/LUCENE-5392 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 5.0 >Reporter: Benson Margulies > > The changes to the tokenizer and analyzer need to be reflected in the package > overview for core analysis. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5392) Documentation for modified token / analysis pipeline
[
https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867917#comment-13867917
]
Robert Muir commented on LUCENE-5392:
-
I'm running the checks on this patch, it looks good.
A few bugs (the first is just a typo, the other two cross-module links need a
javadocs-hack)
{noformat}
{@link org.apache.lucene.analysis.CharFilters} -> {@link
org.apache.lucene.analysis.CharFilter}s,
{@link org.apache.lucene.analysis.standard.StandardAnalyzer} -> StandardAnalyzer
{@link org.apache.lucene.analysis.miscellaneous.PerFieldAnalyzerWrapper} -> PerFieldAnalyzerWrapper
{noformat}
I also added a short blurb to MIGRATE.txt in trunk to explain the change.
Currently it just points them at the package documentation for more details:
{noformat}
+
+## Removed Reader from Tokenizer constructor (LUCENE-5388)
+
+The constructor of Tokenizer no longer takes Reader, as this was a leftover
+from before it was reusable. See the org.apache.lucene.analysis package
+documentation for more details.
{noformat}
I'm running full documentation-lint checks now, when it passes ill commit.
Thanks Benson!
> Documentation for modified token / analysis pipeline
>
>
> Key: LUCENE-5392
> URL: https://issues.apache.org/jira/browse/LUCENE-5392
> Project: Lucene - Core
> Issue Type: Bug
>Affects Versions: 5.0
>Reporter: Benson Margulies
>
> The changes to the tokenizer and analyzer need to be reflected in the package
> overview for core analysis.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5392) Documentation for modified token / analysis pipeline
[ https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867824#comment-13867824 ] Uwe Schindler commented on LUCENE-5392: --- Thanks for the updates. The code examples get out of date very easy, because we cannot check the automatically. > Documentation for modified token / analysis pipeline > > > Key: LUCENE-5392 > URL: https://issues.apache.org/jira/browse/LUCENE-5392 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 5.0 >Reporter: Benson Margulies > > The changes to the tokenizer and analyzer need to be reflected in the package > overview for core analysis. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-5392) Documentation for modified token / analysis pipeline
[ https://issues.apache.org/jira/browse/LUCENE-5392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867801#comment-13867801 ] Benson Margulies commented on LUCENE-5392: -- https://github.com/apache/lucene-solr/pull/17 [~rcmuir] and [~thetaphi] 'Look out below', here's a bunch of work on the analysis doc. > Documentation for modified token / analysis pipeline > > > Key: LUCENE-5392 > URL: https://issues.apache.org/jira/browse/LUCENE-5392 > Project: Lucene - Core > Issue Type: Bug >Affects Versions: 5.0 >Reporter: Benson Margulies > > The changes to the tokenizer and analyzer need to be reflected in the package > overview for core analysis. -- This message was sent by Atlassian JIRA (v6.1.5#6160) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
