[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229537#comment-14229537
]
Michael McCandless commented on LUCENE-6004:
Egads, it's completely wrong! I think I screwed up resolving the conflicts in
CHANGES when I backported (the other changed files look correct). I'll fix ...
thanks for catching this Rob!
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Fix For: 4.10.3, 5.0, Trunk
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229538#comment-14229538
]
ASF subversion and git services commented on LUCENE-6004:
-
Commit 1642646 from [~mikemccand] in branch 'dev/branches/lucene_solr_4_10'
[ https://svn.apache.org/r1642646 ]
LUCENE-6004: fix CHANGES entry
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Fix For: 4.10.3, 5.0, Trunk
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14229251#comment-14229251
]
Robert Muir commented on LUCENE-6004:
-
I'm confused about the CHANGES.txt entry here, it seems to refer to another
issue?
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Fix For: 4.10.3, 5.0, Trunk
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212712#comment-14212712
]
Michael McCandless commented on LUCENE-6004:
Thanks Christian and jane, I think this makes sense ... I'll commit shortly.
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212926#comment-14212926
]
ASF subversion and git services commented on LUCENE-6004:
-
Commit 1639798 from [~mikemccand] in branch 'dev/trunk'
[ https://svn.apache.org/r1639798 ]
LUCENE-6004: don't highlight LookupResult.key from AnalyzingInfixSuggester
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14212933#comment-14212933
]
ASF subversion and git services commented on LUCENE-6004:
-
Commit 1639799 from [~mikemccand] in branch 'dev/branches/branch_5x'
[ https://svn.apache.org/r1639799 ]
LUCENE-6004: don't highlight LookupResult.key from AnalyzingInfixSuggester
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6004) Highlighting AnalyzingInfixSuggester skips non-highlighted key
[
https://issues.apache.org/jira/browse/LUCENE-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14213034#comment-14213034
]
ASF subversion and git services commented on LUCENE-6004:
-
Commit 1639802 from [~mikemccand] in branch 'dev/branches/lucene_solr_4_10'
[ https://svn.apache.org/r1639802 ]
LUCENE-6004: don't highlight LookupResult.key from AnalyzingInfixSuggester
Highlighting AnalyzingInfixSuggester skips non-highlighted key
--
Key: LUCENE-6004
URL: https://issues.apache.org/jira/browse/LUCENE-6004
Project: Lucene - Core
Issue Type: Bug
Components: modules/other
Affects Versions: 4.10
Reporter: Christian Reuschling
Priority: Trivial
Labels: easyfix
Attachments: LUCENE-6004.patch
Original Estimate: 5m
Remaining Estimate: 5m
when setting 'doHighlight' to true at AnalyzingInfixSuggester.lookup(..),
both the key and the highlightKey inside the returned lookupresult are set to
the highlighted string. See at AnalyzingInfixSuggester.createResults, line
530:
if (doHighlight) {
Object highlightKey = highlight(text, matchedTokens, prefixToken);
result = new LookupResult(highlightKey.toString(), highlightKey,
score, payload, contexts);
} else {
result = new LookupResult(text, score, payload, contexts);
}
As I understand, the key should'nt be highlighted in any case, only the
highlightKey.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
