[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[ https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246817#comment-14246817 ] Adrien Grand commented on LUCENE-6104: -- +1 to the patch. Thanks for fixing the generics of the Accountable interface! simplify internals of Lucene50NormsProducer --- Key: LUCENE-6104 URL: https://issues.apache.org/jira/browse/LUCENE-6104 Project: Lucene - Core Issue Type: Improvement Reporter: Robert Muir Attachments: LUCENE-6104.patch, LUCENE-6104.patch This is tracking additional data structures, and has a lot of complexity, when we could just refactor the internal structure to be a bit cleaner. as a bonus, its less memory overhead, but a more thorough memory tree: it works like the docvalues one now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[
https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246873#comment-14246873
]
Uwe Schindler commented on LUCENE-6104:
---
+1. Thanks for removing generics bullshit :-) The last time I have seen those
Iterable docs I was really confused about the reason for the {{? extends}}.
Thanks for simply removing it!
simplify internals of Lucene50NormsProducer
---
Key: LUCENE-6104
URL: https://issues.apache.org/jira/browse/LUCENE-6104
Project: Lucene - Core
Issue Type: Improvement
Reporter: Robert Muir
Attachments: LUCENE-6104.patch, LUCENE-6104.patch
This is tracking additional data structures, and has a lot of complexity,
when we could just refactor the internal structure to be a bit cleaner.
as a bonus, its less memory overhead, but a more thorough memory tree: it
works like the docvalues one now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[ https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246920#comment-14246920 ] ASF subversion and git services commented on LUCENE-6104: - Commit 1645711 from [~rcmuir] in branch 'dev/trunk' [ https://svn.apache.org/r1645711 ] LUCENE-6104: simplify internals of Lucene50NormsProducer simplify internals of Lucene50NormsProducer --- Key: LUCENE-6104 URL: https://issues.apache.org/jira/browse/LUCENE-6104 Project: Lucene - Core Issue Type: Improvement Reporter: Robert Muir Attachments: LUCENE-6104.patch, LUCENE-6104.patch This is tracking additional data structures, and has a lot of complexity, when we could just refactor the internal structure to be a bit cleaner. as a bonus, its less memory overhead, but a more thorough memory tree: it works like the docvalues one now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[ https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14246988#comment-14246988 ] ASF subversion and git services commented on LUCENE-6104: - Commit 1645718 from [~rcmuir] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1645718 ] LUCENE-6104: simplify internals of Lucene50NormsProducer simplify internals of Lucene50NormsProducer --- Key: LUCENE-6104 URL: https://issues.apache.org/jira/browse/LUCENE-6104 Project: Lucene - Core Issue Type: Improvement Reporter: Robert Muir Fix For: 5.0, Trunk Attachments: LUCENE-6104.patch, LUCENE-6104.patch This is tracking additional data structures, and has a lot of complexity, when we could just refactor the internal structure to be a bit cleaner. as a bonus, its less memory overhead, but a more thorough memory tree: it works like the docvalues one now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[ https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240936#comment-14240936 ] Michael McCandless commented on LUCENE-6104: +1, I like this simplification. simplify internals of Lucene50NormsProducer --- Key: LUCENE-6104 URL: https://issues.apache.org/jira/browse/LUCENE-6104 Project: Lucene - Core Issue Type: Improvement Reporter: Robert Muir Attachments: LUCENE-6104.patch This is tracking additional data structures, and has a lot of complexity, when we could just refactor the internal structure to be a bit cleaner. as a bonus, its less memory overhead, but a more thorough memory tree: it works like the docvalues one now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[ https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14240961#comment-14240961 ] Michael McCandless commented on LUCENE-6104: +1 to new patch, even more simplifying! simplify internals of Lucene50NormsProducer --- Key: LUCENE-6104 URL: https://issues.apache.org/jira/browse/LUCENE-6104 Project: Lucene - Core Issue Type: Improvement Reporter: Robert Muir Attachments: LUCENE-6104.patch, LUCENE-6104.patch This is tracking additional data structures, and has a lot of complexity, when we could just refactor the internal structure to be a bit cleaner. as a bonus, its less memory overhead, but a more thorough memory tree: it works like the docvalues one now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6104) simplify internals of Lucene50NormsProducer
[
https://issues.apache.org/jira/browse/LUCENE-6104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14241612#comment-14241612
]
Ryan Ernst commented on LUCENE-6104:
+1
For consistency, can either uncompressed use {{RamUsageEstimator}} in
{{ramBytesUsed()}} or in the patched table can we just use {{decode.length}}?
simplify internals of Lucene50NormsProducer
---
Key: LUCENE-6104
URL: https://issues.apache.org/jira/browse/LUCENE-6104
Project: Lucene - Core
Issue Type: Improvement
Reporter: Robert Muir
Attachments: LUCENE-6104.patch, LUCENE-6104.patch
This is tracking additional data structures, and has a lot of complexity,
when we could just refactor the internal structure to be a bit cleaner.
as a bonus, its less memory overhead, but a more thorough memory tree: it
works like the docvalues one now.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
