[jira] [Commented] (LUCENE-6140) simplify inflater usage in deflate CompressionMode
[ https://issues.apache.org/jira/browse/LUCENE-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259671#comment-14259671 ] ASF subversion and git services commented on LUCENE-6140: - Commit 1648224 from [~rcmuir] in branch 'dev/trunk' [ https://svn.apache.org/r1648224 ] LUCENE-6140: simplify inflater usage in CompressionMode simplify inflater usage in deflate CompressionMode -- Key: LUCENE-6140 URL: https://issues.apache.org/jira/browse/LUCENE-6140 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-6140.patch This currently loops-n-grows the output byte[]. But we always decompress the whole block (we dont emit flushes or anything to allow otherwise) and ignore offset/length to the end, and we know how big the uncompressed size is up-front... we can just call inflate one time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6140) simplify inflater usage in deflate CompressionMode
[ https://issues.apache.org/jira/browse/LUCENE-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259673#comment-14259673 ] ASF subversion and git services commented on LUCENE-6140: - Commit 1648226 from [~rcmuir] in branch 'dev/branches/branch_5x' [ https://svn.apache.org/r1648226 ] LUCENE-6140: simplify inflater usage in CompressionMode simplify inflater usage in deflate CompressionMode -- Key: LUCENE-6140 URL: https://issues.apache.org/jira/browse/LUCENE-6140 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Fix For: 5.0, Trunk Attachments: LUCENE-6140.patch This currently loops-n-grows the output byte[]. But we always decompress the whole block (we dont emit flushes or anything to allow otherwise) and ignore offset/length to the end, and we know how big the uncompressed size is up-front... we can just call inflate one time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-6140) simplify inflater usage in deflate CompressionMode
[ https://issues.apache.org/jira/browse/LUCENE-6140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14259502#comment-14259502 ] Adrien Grand commented on LUCENE-6140: -- +1 good catch simplify inflater usage in deflate CompressionMode -- Key: LUCENE-6140 URL: https://issues.apache.org/jira/browse/LUCENE-6140 Project: Lucene - Core Issue Type: Task Reporter: Robert Muir Attachments: LUCENE-6140.patch This currently loops-n-grows the output byte[]. But we always decompress the whole block (we dont emit flushes or anything to allow otherwise) and ignore offset/length to the end, and we know how big the uncompressed size is up-front... we can just call inflate one time. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
