[jira] [Commented] (LUCENE-7102) LatLonPoint newDistanceSort fails with "sort missing first"
[ https://issues.apache.org/jira/browse/LUCENE-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193802#comment-15193802 ] ASF subversion and git services commented on LUCENE-7102: - Commit a6fe1c0b155ff464d0596289bb209eef99c269d3 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a6fe1c0 ] LUCENE-7102: LatLonPoint.newDistanceSort fails with "sort missing first" > LatLonPoint newDistanceSort fails with "sort missing first" > --- > > Key: LUCENE-7102 > URL: https://issues.apache.org/jira/browse/LUCENE-7102 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7102.patch > > > The distance sort comparator creates bounding boxes when the priority queue > is full, to speed up sorting. > But with missing values (which we don't test), they can be e.g. -Inf/+Inf and > we do the wrong thing (e.g. try to make illegal infinite bounding boxes). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7102) LatLonPoint newDistanceSort fails with "sort missing first"
[ https://issues.apache.org/jira/browse/LUCENE-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193793#comment-15193793 ] ASF subversion and git services commented on LUCENE-7102: - Commit 0f949c815343c853499d518e7d565d642d93ce63 in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0f949c8 ] LUCENE-7102: LatLonPoint.newDistanceSort fails with "sort missing first" > LatLonPoint newDistanceSort fails with "sort missing first" > --- > > Key: LUCENE-7102 > URL: https://issues.apache.org/jira/browse/LUCENE-7102 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7102.patch > > > The distance sort comparator creates bounding boxes when the priority queue > is full, to speed up sorting. > But with missing values (which we don't test), they can be e.g. -Inf/+Inf and > we do the wrong thing (e.g. try to make illegal infinite bounding boxes). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7102) LatLonPoint newDistanceSort fails with "sort missing first"
[ https://issues.apache.org/jira/browse/LUCENE-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193733#comment-15193733 ] Robert Muir commented on LUCENE-7102: - I thought about this too, but we can do this separately if we want? Either way, i don't think we should pass +/- infinite radius to the geo functions. > LatLonPoint newDistanceSort fails with "sort missing first" > --- > > Key: LUCENE-7102 > URL: https://issues.apache.org/jira/browse/LUCENE-7102 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7102.patch > > > The distance sort comparator creates bounding boxes when the priority queue > is full, to speed up sorting. > But with missing values (which we don't test), they can be e.g. -Inf/+Inf and > we do the wrong thing (e.g. try to make illegal infinite bounding boxes). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7102) LatLonPoint newDistanceSort fails with "sort missing first"
[ https://issues.apache.org/jira/browse/LUCENE-7102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193725#comment-15193725 ] Michael McCandless commented on LUCENE-7102: +1, nice catch. I'm not sure we should even allow "sort missing first"... > LatLonPoint newDistanceSort fails with "sort missing first" > --- > > Key: LUCENE-7102 > URL: https://issues.apache.org/jira/browse/LUCENE-7102 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7102.patch > > > The distance sort comparator creates bounding boxes when the priority queue > is full, to speed up sorting. > But with missing values (which we don't test), they can be e.g. -Inf/+Inf and > we do the wrong thing (e.g. try to make illegal infinite bounding boxes). -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
