[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246793#comment-15246793 ] ASF subversion and git services commented on LUCENE-7185: - Commit cc463bf4f28b07b05a125a6b7105a9997ec8e82e in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc463bf ] LUCENE-7185: fix buggy worst-case error and add test for absurd distances > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246781#comment-15246781 ] ASF subversion and git services commented on LUCENE-7185: - Commit b839325740f9487bf30c74b649993c7e400a2aaa in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b839325 ] LUCENE-7185: fix buggy worst-case error and add test for absurd distances > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245632#comment-15245632 ] ASF subversion and git services commented on LUCENE-7185: - Commit 045f2cad6f7808f11a4f0626ec497a077eac3220 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=045f2ca ] LUCENE-7185: handle underflow > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245630#comment-15245630 ] ASF subversion and git services commented on LUCENE-7185: - Commit cc099d8fc60a7693417754f9b3a3f51f0952f9a3 in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cc099d8 ] LUCENE-7185: handle underflow > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245249#comment-15245249 ] Michael McCandless commented on LUCENE-7185: +1, this is fabulous!! > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245183#comment-15245183 ] Dawid Weiss commented on LUCENE-7185: - Cool visualization. > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245124#comment-15245124 ] ASF subversion and git services commented on LUCENE-7185: - Commit 2138bc05365e362dd5aa8df4224fd853e981de2f in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2138bc0 ] LUCENE-7185: improve random test point/box generation for spatial tests > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245119#comment-15245119 ] ASF subversion and git services commented on LUCENE-7185: - Commit c135e9a7d6aedc317879a716716224b3b19c91a1 in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c135e9a ] LUCENE-7185: improve random test point/box generation for spatial tests > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15245089#comment-15245089 ] Robert Muir commented on LUCENE-7185: - Attached is some improvements to the polygon/box testing, really its just about the points we pick to test. I haven't yet improved the actual polygons being generated. Here is a visual of what random points and boxes look like with the old generator. You can see it essentially only targets vertices for points and boxes and so these are usually not very interesting. !oldRandom.png! Here is the new one: it tries better to find edge cases. Specifically we attack edges themselves, the bounding box, diagonals between vertices, and so on. I improved boxes as well, they definitely still could use work but should be more effective. !newRandom.png! I will beast the tests to try to reduce any noise. I think its ok given what our tests are doing (and the very simple stuff we are doing today with polys). > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_polygon.patch, > LUCENE-7185_sorting.patch, newRandom.png, oldRandom.png > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239342#comment-15239342 ] ASF subversion and git services commented on LUCENE-7185: - Commit acf0a57940ee8a625a3d5c48bfa170e5e758996b in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=acf0a57 ] LUCENE-7185: add proper tests for grid bugs found here, and fix related bugs still lurking > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15239341#comment-15239341 ] ASF subversion and git services commented on LUCENE-7185: - Commit cd673ebec93cbdf37d14b3984552cec4388cea0f in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cd673eb ] LUCENE-7185: add proper tests for grid bugs found here, and fix related bugs still lurking > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235192#comment-15235192 ] ASF subversion and git services commented on LUCENE-7185: - Commit b21218e79f2b431b3311a0a07dfbcdb7ae48f1ab in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b21218e ] LUCENE-7185: fix random number generation used for spatial tests. Note that GeoPoint tests are still on the old RNG as we haven't get made them happy. > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15235177#comment-15235177 ] ASF subversion and git services commented on LUCENE-7185: - Commit 901a3af301f81331459cddb87e4fbf1a4437303b in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=901a3af ] LUCENE-7185: fix random number generation used for spatial tests. Note that GeoPoint tests are still on the old RNG as we haven't get made them happy. > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230402#comment-15230402 ] ASF subversion and git services commented on LUCENE-7185: - Commit 01867a5b318d6509731feea118b3f82764310380 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=01867a5 ] LUCENE-7185: fix tie-breaker sort bug > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15230401#comment-15230401 ] ASF subversion and git services commented on LUCENE-7185: - Commit 05d62a357711d1e4e850a5d2fb7336bf0a7acf24 in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=05d62a3 ] LUCENE-7185: fix tie-breaker sort bug > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229925#comment-15229925 ] Michael McCandless commented on LUCENE-7185: +1 to the sorting patch! > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch, LUCENE-7185_sorting.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[
https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229825#comment-15229825
]
Dawid Weiss commented on LUCENE-7185:
-
{code}
+ // may trigger divide by zero
+ return 0.0;
{code}
Given that ((Double) +0.0).equals/compareTo(-0.0) equals false, even though
unboxed comparison obviously equals true, I'd add -0.0 to the list of surprises
as well.
> fix random number generation used for spatial tests
> ---
>
> Key: LUCENE-7185
> URL: https://issues.apache.org/jira/browse/LUCENE-7185
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Robert Muir
> Attachments: LUCENE-7185.patch
>
>
> The current method is not very good for testing.
> * It will only rarely or never return edge cases like -180/180/-90/90
> * It will only rarely return 0
> * There are many possible doubles within the ranges (-180..180/-90..90) it
> will never return
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229657#comment-15229657 ] ASF subversion and git services commented on LUCENE-7185: - Commit 6d537d2bad64a27927aa7c67c600dee97f79aa2b in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6d537d2 ] LUCENE-7185: fix edge case bugs in LatLonPoint bounding box query > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229655#comment-15229655 ] ASF subversion and git services commented on LUCENE-7185: - Commit e0c507a40012a1148da65b81d722bd9b29ec9d8e in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e0c507a ] LUCENE-7185: fix edge case bugs in LatLonPoint bounding box query > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229654#comment-15229654 ] ASF subversion and git services commented on LUCENE-7185: - Commit cebac848a999db0b341d717c8edd39ecc9184671 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cebac84 ] LUCENE-7185: fix edge case bug in test logic (min=max=180), don't leak Directory for edge cases! > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229653#comment-15229653 ] ASF subversion and git services commented on LUCENE-7185: - Commit 2965ac2ca18e2019fb9f03170b9bcf98162a9d21 in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2965ac2 ] LUCENE-7185: fix edge case bug in test logic (min=max=180), don't leak Directory for edge cases! > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229526#comment-15229526 ] Robert Muir commented on LUCENE-7185: - I'm gonna try to fight my way thru the various test fails, some are pretty crazy. by frequently choosing certain edge values it also means we find bugs or test bugs with tie-break handling in sorting, rectangles that really look more like lines/single points, you name it. > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229514#comment-15229514 ] ASF subversion and git services commented on LUCENE-7185: - Commit e75db9476764b9a6a426686a58e18f38a26883a5 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e75db94 ] LUCENE-7185: make an empty grid the simple way > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229511#comment-15229511 ] ASF subversion and git services commented on LUCENE-7185: - Commit b59ace99e45969a8d81be4639bfb2695681636eb in lucene-solr's branch refs/heads/master from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b59ace9 ] LUCENE-7185: make an empty grid the simple way > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7185) fix random number generation used for spatial tests
[ https://issues.apache.org/jira/browse/LUCENE-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15229115#comment-15229115 ] Michael McCandless commented on LUCENE-7185: +1, this is great :) > fix random number generation used for spatial tests > --- > > Key: LUCENE-7185 > URL: https://issues.apache.org/jira/browse/LUCENE-7185 > Project: Lucene - Core > Issue Type: Bug >Reporter: Robert Muir > Attachments: LUCENE-7185.patch > > > The current method is not very good for testing. > * It will only rarely or never return edge cases like -180/180/-90/90 > * It will only rarely return 0 > * There are many possible doubles within the ranges (-180..180/-90..90) it > will never return -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
