[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263924#comment-15263924 ] ASF subversion and git services commented on LUCENE-7264: - Commit f7b333f10583639ee3d0f2631fee41c577c60452 in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f7b333f ] LUCENE-7264: Fix test bug in TestReqExclBulkScorer. > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Fix For: master, 6.1 > > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263923#comment-15263923 ] ASF subversion and git services commented on LUCENE-7264: - Commit 14b42fe10ba64bb4468ea8ef298e54a751f16dd3 in lucene-solr's branch refs/heads/branch_6x from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=14b42fe ] LUCENE-7264: Fix test bug in TestReqExclBulkScorer. > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Fix For: master, 6.1 > > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263748#comment-15263748 ] ASF subversion and git services commented on LUCENE-7264: - Commit aa81ba8642a57181a4eaa017b52d0d3c3462544b in lucene-solr's branch refs/heads/master from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=aa81ba8 ] LUCENE-7264: Fewer conditionals in DocIdSetBuilder. > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Fix For: master, 6.1 > > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15263747#comment-15263747 ] ASF subversion and git services commented on LUCENE-7264: - Commit 95c360d053a35486aa12498c6fd319aef0377bb8 in lucene-solr's branch refs/heads/branch_6x from [~jpountz] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=95c360d ] LUCENE-7264: Fewer conditionals in DocIdSetBuilder. > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Fix For: master, 6.1 > > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262857#comment-15262857 ] Yonik Seeley commented on LUCENE-7264: -- Ah, thanks for that reference... need to update my mental models ;-) > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262831#comment-15262831 ] Adrien Grand commented on LUCENE-7264: -- I benchmarked it using IndexAndSearchOpenStreetMaps by temporarily using DocIdSetBuilder instead of MatchingPoints (I did not use luceneutil since its numeric range queries match too many docs). The QPS went from 33.4 (old DocIdSetBuilder.add) to 35.0 with this patch. In that case I think it works well since the base class is an abstract class and there are only two impls, [which the JVM can efficiently optimize|http://shipilev.net/blog/2015/black-magic-method-dispatch/#_two_types]. (For the record, most queries of the benchmark upgrade to a bitset so both impls are used.) > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7264) Fewer conditionals in DocIdSetBuilder.add
[ https://issues.apache.org/jira/browse/LUCENE-7264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262777#comment-15262777 ] Yonik Seeley commented on LUCENE-7264: -- One possible downside to this change is that it changes a predictable branch (that is handled at the CPU level) into a method call... which if it's not monomorphic can be decompiled at the point of the call and thus end up slower (method call vs predictable branch). Will be interesting to see the benchmark results. > Fewer conditionals in DocIdSetBuilder.add > - > > Key: LUCENE-7264 > URL: https://issues.apache.org/jira/browse/LUCENE-7264 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Adrien Grand >Assignee: Adrien Grand >Priority: Minor > Attachments: LUCENE-7264.patch > > > As reported in LUCENE-7254, DocIdSetBuilder.add has several conditionals that > slow down the construction of the DocIdSet. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
