[jira] [Commented] (LUCENE-7516) consider to remove DocSet.close()

2016-10-22 Thread Yonik Seeley (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15598033#comment-15598033
 ] 

Yonik Seeley commented on LUCENE-7516:
--

Yeah, might as well remove it.
Given the opposition to Unsafe, it seems unlikely we'll ever have an off-heap 
filter cache.

> consider to remove DocSet.close()
> -
>
> Key: LUCENE-7516
> URL: https://issues.apache.org/jira/browse/LUCENE-7516
> Project: Lucene - Core
>  Issue Type: Sub-task
>Reporter: Mikhail Khludnev
>Priority: Trivial
>
> [~romseygeek], I'd like to do the subj but I've found
> {code}
>   /** FUTURE: for off-heap */
>   @Override
>   public void close() throws IOException {
>   }
> {code}
> and want to sync up with [~ysee...@gmail.com]. If he confirm, let's nuke it 
> from master, keeping in 6x as well it's public method. it should be SOLR 
> ticket for sure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-7516) consider to remove DocSet.close()

2016-10-21 Thread David Smiley (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-7516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15595063#comment-15595063
 ] 

David Smiley commented on LUCENE-7516:
--

Presumably this is filed against Lucene and not Solr because it's a sub-task 
and this is a JIRA limitation?

> consider to remove DocSet.close()
> -
>
> Key: LUCENE-7516
> URL: https://issues.apache.org/jira/browse/LUCENE-7516
> Project: Lucene - Core
>  Issue Type: Sub-task
>Reporter: Mikhail Khludnev
>Priority: Trivial
>
> [~romseygeek], I'd like to do the subj but I've found
> {code}
>   /** FUTURE: for off-heap */
>   @Override
>   public void close() throws IOException {
>   }
> {code}
> and want to sync up with [~ysee...@gmail.com]. If he confirm, let's nuke it 
> from master, keeping in 6x as well it's public method. it should be SOLR 
> ticket for sure



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org