[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820463#comment-15820463 ] Dawid Weiss commented on LUCENE-7559: - Thanks David, looks good to me! > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 6.4 > > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820227#comment-15820227 ] ASF subversion and git services commented on LUCENE-7559: - Commit 4449710a3bcb790b5c33d6803ce97e1e57176043 in lucene-solr's branch refs/heads/branch_6x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4449710 ] LUCENE-7559: UH: Also expose OffsetsEnum, and test it's exposure (cherry picked from commit 7435ab1) > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 6.4 > > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820224#comment-15820224 ] ASF subversion and git services commented on LUCENE-7559: - Commit 7435ab18786a43f9004c44713446380711137b79 in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7435ab1 ] LUCENE-7559: UH: Also expose OffsetsEnum, and test it's exposure > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Fix For: 6.4 > > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674138#comment-15674138 ] ASF subversion and git services commented on LUCENE-7559: - Commit 06ee34c68225fd904b8909af44173574890d881e in lucene-solr's branch refs/heads/branch_6x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=06ee34c ] LUCENE-7559: fix indentation of entire file (cherry picked from commit cbc8392) > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674137#comment-15674137 ] ASF subversion and git services commented on LUCENE-7559: - Commit 23b8bb669359008d19fd19d744ba42ef8870d25c in lucene-solr's branch refs/heads/branch_6x from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=23b8bb6 ] LUCENE-7559: UnifiedHighlighter: Increase Passage visibility (cherry picked from commit c51e890) > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674131#comment-15674131 ] ASF subversion and git services commented on LUCENE-7559: - Commit cbc83929e70e78d84e15013aa9e60cc81a4a7a6d in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbc8392 ] LUCENE-7559: fix indentation of entire file > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7559) UnifiedHighlighter: Make Passage public for extensibility
[ https://issues.apache.org/jira/browse/LUCENE-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15674125#comment-15674125 ] ASF subversion and git services commented on LUCENE-7559: - Commit c51e89014ac74f164e3b6962abc5f0db56ee99bb in lucene-solr's branch refs/heads/master from [~dsmiley] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c51e890 ] LUCENE-7559: UnifiedHighlighter: Increase Passage visibility > UnifiedHighlighter: Make Passage public for extensibility > - > > Key: LUCENE-7559 > URL: https://issues.apache.org/jira/browse/LUCENE-7559 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Attachments: LUCENE-7559.patch > > > (UnifiedHighlighter) Passage.java has a variety of package-level fields and > methods that are accessed by FieldHighlighter.highlightOffsetsEnums (the > kernel of the UH). It should be possible for people to extend this method to > tweak the process of producing passages. That method is extensible but > Passage.java is too closed. Even if one were to write their own equivalent > to Passage.java, it would be impossible to then use PassageScorer or > PassageFormatter. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
