[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878289#comment-15878289 ] Jim Ferenczi commented on LUCENE-7699: -- Only 6.5 since the articulation points parsing is a breaking change (at least for boolean queries). > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878280#comment-15878280 ] Matt Weber commented on LUCENE-7699: Thanks [~jim.ferenczi]. I this going to make it into 6.4.2 or wait until 6.5? > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878200#comment-15878200 ] Jim Ferenczi commented on LUCENE-7699: -- Thanks [~mattweber] ! > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878199#comment-15878199 ] ASF subversion and git services commented on LUCENE-7699: - Commit 43317a33f5d782d982d562df23ffbcdfb8820204 in lucene-solr's branch refs/heads/branch_6x from [~jim.ferenczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=43317a3 ] LUCENE-7699: Query parsers now use span queries to produce more efficient phrase queries for multi-token synonyms. > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878151#comment-15878151 ] ASF subversion and git services commented on LUCENE-7699: - Commit 96e8f0a0afeb68e2d07ec1dda362894f0b94333d in lucene-solr's branch refs/heads/master from [~jim.ferenczi] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=96e8f0a ] LUCENE-7699: Query parsers now use span queries to produce more efficient phrase queries for multi-token synonyms. > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877879#comment-15877879 ] lujia commented on LUCENE-7699: --- ? > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877731#comment-15877731 ] Jim Ferenczi commented on LUCENE-7699: -- Thanks [~mattweber] The new patch looks great. I'll merge shortly > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch, LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[
https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876559#comment-15876559
]
Matt Weber commented on LUCENE-7699:
Remove {{GraphQuery}} in LUCENE-7702.
> Apply graph articulation points optimization to phrase graph queries
>
>
> Key: LUCENE-7699
> URL: https://issues.apache.org/jira/browse/LUCENE-7699
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Matt Weber
> Attachments: LUCENE-7699.patch, LUCENE-7699.patch
>
>
> Follow-up to LUCENE-7638 that applies the same articulation point logic to
> graph phrases using span queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[
https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876101#comment-15876101
]
Matt Weber commented on LUCENE-7699:
[~jim.ferenczi] That check was intended, but as you said, it is essentially
pointless. I will remove it. Yes, I think {{GraphQuery}} should go as well.
It was only needed when we needed to detect the graph to apply minimum should
match and phrase slop which is no longer the case. Should that be separate
issue?
> Apply graph articulation points optimization to phrase graph queries
>
>
> Key: LUCENE-7699
> URL: https://issues.apache.org/jira/browse/LUCENE-7699
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Matt Weber
> Attachments: LUCENE-7699.patch
>
>
> Follow-up to LUCENE-7638 that applies the same articulation point logic to
> graph phrases using span queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[
https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875734#comment-15875734
]
Michael McCandless commented on LUCENE-7699:
+1, thanks [~mattweber]; this also fixes an adversarial combinatoric explosion
case.
bq. On a different note I also wonder if we should keep the specialized
GraphQuery. IMO it's not useful anymore especially if we use span queries for
quoted query.
+1 to phase out {{GraphQuery}}, I think: really, the "graph-ness" of the
situation should only be a transient thing, that happened during query parsing,
and was quickly translated into the equivalent query structure?
> Apply graph articulation points optimization to phrase graph queries
>
>
> Key: LUCENE-7699
> URL: https://issues.apache.org/jira/browse/LUCENE-7699
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Matt Weber
> Attachments: LUCENE-7699.patch
>
>
> Follow-up to LUCENE-7638 that applies the same articulation point logic to
> graph phrases using span queries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875705#comment-15875705 ] Jim Ferenczi commented on LUCENE-7699: -- It looks good [~mattweber] In analyzeGraphPhrase you check getAutoGenerateMultiTermSynonymsPhraseQuery when a side path is built. Is it intended ? I don't understand what the non-quoted query built by createSpanQuery is supposed to represent. On a different note I also wonder if we should keep the specialized GraphQuery. IMO it's not useful anymore especially if we use span queries for quoted query. > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7699) Apply graph articulation points optimization to phrase graph queries
[ https://issues.apache.org/jira/browse/LUCENE-7699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875325#comment-15875325 ] Matt Weber commented on LUCENE-7699: [~jim.ferenczi] [~mikemccand] What do you think? > Apply graph articulation points optimization to phrase graph queries > > > Key: LUCENE-7699 > URL: https://issues.apache.org/jira/browse/LUCENE-7699 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Matt Weber > Attachments: LUCENE-7699.patch > > > Follow-up to LUCENE-7638 that applies the same articulation point logic to > graph phrases using span queries. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
