[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[ https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004242#comment-16004242 ] ASF subversion and git services commented on LUCENE-7741: - Commit fb24d451cc98120d5a70bd0e63a5b296ce69123c in lucene-solr's branch refs/heads/master from [~romseygeek] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fb24d45 ] LUCENE-7741: Add explain() to DoubleValuesSource > Add explain() to DoubleValues > - > > Key: LUCENE-7741 > URL: https://issues.apache.org/jira/browse/LUCENE-7741 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: LUCENE-7741.patch, LUCENE-7741.patch > > > As noted on LUCENE-7737, it would be nice to be able to get an explanation > for DoubleValues values, particularly for things like complex spatial > distance calculations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[ https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002991#comment-16002991 ] Adrien Grand commented on LUCENE-7741: -- +1 to the patch +1 to switching explanations to doubles, this could be a nice preliminary step to LUCENE-7517. > Add explain() to DoubleValues > - > > Key: LUCENE-7741 > URL: https://issues.apache.org/jira/browse/LUCENE-7741 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: LUCENE-7741.patch, LUCENE-7741.patch > > > As noted on LUCENE-7737, it would be nice to be able to get an explanation > for DoubleValues values, particularly for things like complex spatial > distance calculations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[ https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000394#comment-16000394 ] Alan Woodward commented on LUCENE-7741: --- One wrinkle here is that we have a lot of casting from double to float, in order to fit stuff into Explanation.value. Might be worth opening up another JIRA to change Explanations to use doubles instead? Scores will still be floats, but we use Explanation for more than just scores now. > Add explain() to DoubleValues > - > > Key: LUCENE-7741 > URL: https://issues.apache.org/jira/browse/LUCENE-7741 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: LUCENE-7741.patch, LUCENE-7741.patch > > > As noted on LUCENE-7737, it would be nice to be able to get an explanation > for DoubleValues values, particularly for things like complex spatial > distance calculations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[ https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998326#comment-15998326 ] Adrien Grand commented on LUCENE-7741: -- bq. What is "NB " in the comments? It means "Nota Bene", a latin phrase that means roughly "pay attention" (https://en.wikipedia.org/wiki/Nota_bene). > Add explain() to DoubleValues > - > > Key: LUCENE-7741 > URL: https://issues.apache.org/jira/browse/LUCENE-7741 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: LUCENE-7741.patch > > > As noted on LUCENE-7737, it would be nice to be able to get an explanation > for DoubleValues values, particularly for things like complex spatial > distance calculations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[
https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15998323#comment-15998323
]
Adrien Grand commented on LUCENE-7741:
--
Actually I'd rather like the explanation to be on the values source class. This
would be consistent with how we have this method on {{Weight}} rather than
{{Scorer}}. Why is it more invasive on {{DoubleValuesSource}} than on
{{DoubleValues}}?
> Add explain() to DoubleValues
> -
>
> Key: LUCENE-7741
> URL: https://issues.apache.org/jira/browse/LUCENE-7741
> Project: Lucene - Core
> Issue Type: Improvement
>Reporter: Alan Woodward
>Assignee: Alan Woodward
> Attachments: LUCENE-7741.patch
>
>
> As noted on LUCENE-7737, it would be nice to be able to get an explanation
> for DoubleValues values, particularly for things like complex spatial
> distance calculations.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7741) Add explain() to DoubleValues
[ https://issues.apache.org/jira/browse/LUCENE-7741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15989868#comment-15989868 ] David Smiley commented on LUCENE-7741: -- +1 looks great! * What is "NB " in the comments? * testExplanations tests nothing? Or was your intention just a lack of exceptions? > Add explain() to DoubleValues > - > > Key: LUCENE-7741 > URL: https://issues.apache.org/jira/browse/LUCENE-7741 > Project: Lucene - Core > Issue Type: Improvement >Reporter: Alan Woodward >Assignee: Alan Woodward > Attachments: LUCENE-7741.patch > > > As noted on LUCENE-7737, it would be nice to be able to get an explanation > for DoubleValues values, particularly for things like complex spatial > distance calculations. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
