[jira] [Commented] (LUCENE-7911) checkJavadocLinks.py doesn't allow links to new Ref Guide in javadocs
[
https://issues.apache.org/jira/browse/LUCENE-7911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191532#comment-16191532
]
ASF subversion and git services commented on LUCENE-7911:
-
Commit 4392500a3b19b2cf7111f2914daf6f23fce985d5 in lucene-solr's branch
refs/heads/master from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4392500 ]
LUCENE-7911: allow javadoc links containing 'lucene.apache.org/solr/guide/'
> checkJavadocLinks.py doesn't allow links to new Ref Guide in javadocs
> -
>
> Key: LUCENE-7911
> URL: https://issues.apache.org/jira/browse/LUCENE-7911
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Cassandra Targett
> Attachments: LUCENE-7911.patch
>
>
> In SOLR-11135 I'm fixing a number of URLs in source that point to the old
> Solr Reference Guide location
> (https://cwiki.apache.org/confluence/display/solr/...). The new base URL for
> the Ref Guide is {{https://lucene.apache.org/solr/guide...}} which is the
> same as the javadocs.
> Several of these references are in Java classes, but changing those to the
> new URLs causes precommit to fail because {{checkJavadocLinks.py}} doesn't
> allow links in javadocs to contain URLs starting with {{lucene.apache.org}}
> unless they are explicitly allowed.
> Fixing this may not be as simple as just allowing any URL starting with
> {{https://lucene.apache.org/solr/guide...}}. For javadocs we want to only use
> non-versioned urls, but someone could accidentally insert a versioned URL
> (say, for 7.0) that would be invalid in later releases.
> Since javadocs & ref guide are on the same server, perhaps some sort of
> relative link is preferable, but I honestly don't know enough about URL
> construction in javadocs to know what sorts of options are available.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-7911) checkJavadocLinks.py doesn't allow links to new Ref Guide in javadocs
[
https://issues.apache.org/jira/browse/LUCENE-7911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16191527#comment-16191527
]
ASF subversion and git services commented on LUCENE-7911:
-
Commit f9b30c12dd4544953529428f13b7a02a4df8bfac in lucene-solr's branch
refs/heads/branch_7x from [~steve_rowe]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f9b30c1 ]
LUCENE-7911: allow javadoc links containing 'lucene.apache.org/solr/guide/'
> checkJavadocLinks.py doesn't allow links to new Ref Guide in javadocs
> -
>
> Key: LUCENE-7911
> URL: https://issues.apache.org/jira/browse/LUCENE-7911
> Project: Lucene - Core
> Issue Type: Bug
>Reporter: Cassandra Targett
> Attachments: LUCENE-7911.patch
>
>
> In SOLR-11135 I'm fixing a number of URLs in source that point to the old
> Solr Reference Guide location
> (https://cwiki.apache.org/confluence/display/solr/...). The new base URL for
> the Ref Guide is {{https://lucene.apache.org/solr/guide...}} which is the
> same as the javadocs.
> Several of these references are in Java classes, but changing those to the
> new URLs causes precommit to fail because {{checkJavadocLinks.py}} doesn't
> allow links in javadocs to contain URLs starting with {{lucene.apache.org}}
> unless they are explicitly allowed.
> Fixing this may not be as simple as just allowing any URL starting with
> {{https://lucene.apache.org/solr/guide...}}. For javadocs we want to only use
> non-versioned urls, but someone could accidentally insert a versioned URL
> (say, for 7.0) that would be invalid in later releases.
> Since javadocs & ref guide are on the same server, perhaps some sort of
> relative link is preferable, but I honestly don't know enough about URL
> construction in javadocs to know what sorts of options are available.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
