[jira] [Commented] (LUCENE-8127) BooleanQuery with needsScores=false, rewriteNoScoring improvement

2018-02-12 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16361040#comment-16361040
 ] 

ASF subversion and git services commented on LUCENE-8127:
-

Commit 9d66dc27328816a845d4f448bf2efa33f289207e in lucene-solr's branch 
refs/heads/branch_7x from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9d66dc2 ]

LUCENE-8127: Speed up rewriteNoScoring when there are no MUST clauses.


> BooleanQuery with needsScores=false, rewriteNoScoring improvement
> -
>
> Key: LUCENE-8127
> URL: https://issues.apache.org/jira/browse/LUCENE-8127
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Michael Braun
>Priority: Minor
> Attachments: LUCENE-8127.patch
>
>
> In the case needsScores=false, createWeight calls rewriteNoScoring before 
> creating a new BooleanWeight. This in all cases creates a new BooleanQuery, 
> even when it's not necessary (aka there are no MUST clauses). 
> The rewriteNoScoring method could check for something as simple as if 
> (clauseSets.get(Occur.MUST).size() > 0)  before creating a brand new 
> BooleanQuery. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8127) BooleanQuery with needsScores=false, rewriteNoScoring improvement

2018-02-12 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/LUCENE-8127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16360795#comment-16360795
 ] 

ASF subversion and git services commented on LUCENE-8127:
-

Commit 7a383947653e8bce05ffdad7ea7d0620f9e08dac in lucene-solr's branch 
refs/heads/master from [~jpountz]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a38394 ]

LUCENE-8127: Speed up rewriteNoScoring when there are no MUST clauses.


> BooleanQuery with needsScores=false, rewriteNoScoring improvement
> -
>
> Key: LUCENE-8127
> URL: https://issues.apache.org/jira/browse/LUCENE-8127
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Michael Braun
>Priority: Minor
> Attachments: LUCENE-8127.patch
>
>
> In the case needsScores=false, createWeight calls rewriteNoScoring before 
> creating a new BooleanWeight. This in all cases creates a new BooleanQuery, 
> even when it's not necessary (aka there are no MUST clauses). 
> The rewriteNoScoring method could check for something as simple as if 
> (clauseSets.get(Occur.MUST).size() > 0)  before creating a brand new 
> BooleanQuery. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org