[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357269#comment-16357269
]
Adrien Grand commented on LUCENE-8156:
--
Thanks Uwe!
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Fix For: master (8.0), 7.3
>
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357257#comment-16357257
]
ASF subversion and git services commented on LUCENE-8156:
-
Commit f208fb867006932b575e3b6149163b7e81fec41e in lucene-solr's branch
refs/heads/branch_7x from [~thetaphi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f208fb8 ]
LUCENE-8156: Require users to not have ASM on the Ant classpath during build
(this is required by LUCENE-7966)
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Fix For: master (8.0)
>
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355857#comment-16355857
]
Uwe Schindler commented on LUCENE-8156:
---
I committed to master. I keep this open until LUCENE-7966 is backported, as it
is requiredto backport it, too.
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Fix For: master (8.0)
>
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355853#comment-16355853
]
ASF subversion and git services commented on LUCENE-8156:
-
Commit 466c1ef4dab4e6da932369a13f587410b6df3203 in lucene-solr's branch
refs/heads/master from [~thetaphi]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=466c1ef ]
LUCENE-8156: Require users to not have ASM on the Ant classpath during build
(this is required by LUCENE-7966)
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353541#comment-16353541
]
Adrien Grand commented on LUCENE-8156:
--
[~thetaphi] Requiring users to not have ASM on the Ant classpath sounds totally
reasonable to me if this issue can't be fixed easily. Thanks for adding this
test, this error message is definitely better, I had to do quite some digging
to understand what the problem was about. +1 to commit
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353533#comment-16353533
]
Uwe Schindler commented on LUCENE-8156:
---
BTW, Forbiddenapis would have same problem, but it works around the issue by
having a private shaded ASM in its own JAR.
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353526#comment-16353526
]
Uwe Schindler commented on LUCENE-8156:
---
Unfortunately no, there is no way: We had three people looking at it yesterday.
The includeAntRuntime stuff only works for classpaths of javac - becausethey
are outside and do not have to do anything with classloaders (the classpath
passed to javac is different).
Here the transformation of class files are done by ant's JVM, so it uses Ant's
classloader at thetop level. Ant has options to violate classloading by
inverting the parent search order (parentLast), but I did not get that running.
Another option would be to fork - but that did not work, as it would then
require a local installation of Groovy.
I can fix the typo, sure :)
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353164#comment-16353164
]
Robert Muir commented on LUCENE-8156:
-
Is there no way to avoid relying on what is in ant's classpath (e.g. like javac
includeAntRuntime=false)? If we can make the build robust, we should do it. A
clear error is one way to do that though. The patch has a typo for "correctly".
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353119#comment-16353119
]
Uwe Schindler commented on LUCENE-8156:
---
This is how it looks like on Policeman:
!image-2018-02-06-00-00-35-434.png!
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch, image-2018-02-06-00-00-35-434.png
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353117#comment-16353117
]
Uwe Schindler commented on LUCENE-8156:
---
In general, on Jenkins builds, I would never ever user the operating system's
default ANT. I'd configure Jenkins to use a specific version of ANT, so it
downloads and installs a clean version in the Jenkins build. This makes builds
reproducible. Apache Jenkins and Policeman are configured like this. It has no
dependency to possibly broken operating system packages.
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Assignee: Uwe Schindler
>Priority: Major
> Attachments: LUCENE-8156.patch
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352924#comment-16352924
]
Uwe Schindler commented on LUCENE-8156:
---
Here is how it bails out (I added this 12 year old ASM version to ~/.ant/lib):
{noformat}
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1\lucene\core>ant jar
Buildfile: C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr1\lucene\core\build.xml
BUILD FAILED
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1\lucene\core\build.xml:27:
The following error occurred while executing this line:
C:\Users\Uwe
Schindler\Projects\lucene\trunk-lusolr1\lucene\common-build.xml:69: Your
~/.ant/lib folder or the main classpath of Ant contains some version of ASM.
Please remove it, otherwise this build can't run correcty.
Total time: 0 seconds
C:\Users\Uwe Schindler\Projects\lucene\trunk-lusolr1\lucene\core>
{noformat}
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Priority: Major
> Attachments: LUCENE-8156.patch
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352915#comment-16352915
]
Uwe Schindler commented on LUCENE-8156:
---
Here is my proposed patch to bail out early with useful error message.
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Priority: Major
> Attachments: LUCENE-8156.patch
>
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8156) patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
[
https://issues.apache.org/jira/browse/LUCENE-8156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16352893#comment-16352893
]
Uwe Schindler commented on LUCENE-8156:
---
Hi Adrien,
I have the feeling we can't fix this. There are already bugs open and the
problem with "ant -f fetch.xml" is bringing many problems. It adds horrible
(more than 10 year old versions of several tools into ant's default classpath).
My question: Why does one install those outdated stuff? If it's a bug in the
installation we should the user tell how to fix it. We had a similar request
where somebody else's build was broken, because some crazy Linux Package
manager called "ant -f fetch.xml" during installation. We closed that as won't
fix (have to look it up).
My idea would be to fail early: If ANT finds asm's ClassReader or some other
bad class files on default class path when starting up, it bails out, telling
user to fix his classpath.
Why does ES's half-hourly Lucene tests use this? I'd cleanup the ant/lib folder!
> patch-mrjar-classes fails if an old version of ASM is on the Ant classpath
> --
>
> Key: LUCENE-8156
> URL: https://issues.apache.org/jira/browse/LUCENE-8156
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Adrien Grand
>Priority: Major
>
> If some optional tasks that depend on an old version of ASM are installed,
> patching fails with the following error:
> {{/home/jpountz/src/lucene-solr/lucene/common-build.xml:565:
> java.lang.IncompatibleClassChangeError: class
> org.objectweb.asm.commons.ClassRemapper has interface
> org.objectweb.asm.ClassVisitor as super class}}
> The reason is that ClassRemapper is loaded from the right place, but
> ClassVisitor, its parent class, is loaded from the parent classpath which may
> be a different version.
> It is easy to reproduce:
> - download and extract ant-1.10.1 (latest version)
> - run {{bin/ant -f fetch.xml -Ddest=system}}, this will add
> {{lib/asm-2.2.3.jar}} among other files
> - run {{ant clean test}} at the root of lucene-solr.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
