[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495389#comment-16495389
]
Matt Weber commented on LUCENE-8300:
Thank you [~romseygeek]!
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Fix For: 7.4
>
> Attachments: LUCENE-8300.patch, LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495287#comment-16495287
]
ASF subversion and git services commented on LUCENE-8300:
-
Commit e3d4c7e9b746f77482bec0b5bb82e94adde12da3 in lucene-solr's branch
refs/heads/master from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e3d4c7e ]
LUCENE-8300: Allow unordered intervals to exclude overlaps
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8300.patch, LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16495286#comment-16495286
]
ASF subversion and git services commented on LUCENE-8300:
-
Commit 083dc0811bd44fe434ecaaad892383d48a17d2a8 in lucene-solr's branch
refs/heads/branch_7x from [~romseygeek]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=083dc08 ]
LUCENE-8300: Allow unordered intervals to exclude overlaps
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8300.patch, LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494984#comment-16494984
]
Jim Ferenczi commented on LUCENE-8300:
--
The patch looks good, thanks [~romseygeek]. Non-overlapping and minimum
intervals confuses me since we don't return all intervals in the unordered
query but this is by design. +1 to push.
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8300.patch, LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494965#comment-16494965
]
Alan Woodward commented on LUCENE-8300:
---
Here's an updated patch. {{Intervals.unordered}} now takes a boolean
(defaulting to {{true}}) that says whether or not to allow overlaps.
[~jim.ferenczi] I think there's already a test that does what you ask?
Checking for {{porridge}} unordered with {{pease porridge hot}}
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8300.patch, LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (LUCENE-8300) Add unordered-distinct IntervalsSource
[
https://issues.apache.org/jira/browse/LUCENE-8300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468695#comment-16468695
]
Jim Ferenczi commented on LUCENE-8300:
--
distinct is a bit misleading because you check for overlaps here and not
distinct intervals so maybe something like unorderedNonOverlapping ? That's
verbose but more easy to understand ;).
Can you also add tests for other cases than just repeating the same term ? The
new source should be able to find unordered intervals that don't overlap from
Intervals.unordered(Intervals.phrase("the world cup"), Intervals.term("world"),
Intervals.term("cup")) which is different than just finding duplicates interval
of different sources.
> Add unordered-distinct IntervalsSource
> --
>
> Key: LUCENE-8300
> URL: https://issues.apache.org/jira/browse/LUCENE-8300
> Project: Lucene - Core
> Issue Type: New Feature
>Reporter: Alan Woodward
>Assignee: Alan Woodward
>Priority: Major
> Attachments: LUCENE-8300.patch
>
>
> [~mattweber] pointed out on LUCENE-8196 that {{Intervals.unordered()}}
> doesn't check to see if its subintervals overlap, which means that for
> example {{Intervals.unordered(Intervals.term("a"), Intervals.term("a"))}}
> would match a document with {{a}} appearing only once. This ticket will
> introduce a new function, {{Intervals.unordered_distinct()}}, that ensures
> that all subintervals within an unordered interval do not overlap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
