[jira] [Commented] (LUCENE-8699) Use fixed byte array in HeapPointWriter

2019-02-22 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774964#comment-16774964
 ] 

ASF subversion and git services commented on LUCENE-8699:
-

Commit 1dfc766afa63f246ef10ff2ab325db8ddec0cf9d in lucene-solr's branch 
refs/heads/branch_8x from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=1dfc766 ]

LUCENE-8699: Add lucene internal tag to PointValue interface
and fix some typos


> Use fixed byte array in HeapPointWriter
> ---
>
> Key: LUCENE-8699
> URL: https://issues.apache.org/jira/browse/LUCENE-8699
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Ignacio Vera
>Assignee: Ignacio Vera
>Priority: Major
> Fix For: 8.x, master (9.0)
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
>  
> {heapPointWriter} is always created with the same init size and max size. It 
> might make sense to change the implementation to use a byte array instead of 
> a growable structure as it has now. This seems to improve performance:
>  
> ||Approach||Index time (sec): Dev||Index Time (sec): Base||Index Time: 
> Diff||Force merge time (sec): Dev||Force Merge time (sec): Base||Force Merge 
> Time: Diff||Index size (GB): Dev||Index size (GB): Base||Index Size: 
> Diff||Reader heap (MB): Dev||Reader heap (MB): Base||Reader heap: Diff||
> |points|122.1s|147.0s|-17%|51.9s|70.5s|-26%|0.55|0.55|0%|1.57|1.57|0%|
> |shapes|211.1s|244.6s|-14%|121.1s|135.0s|-10%|1.29|1.29|0%|1.61|1.61|0%|
> |geo3d|154.2s|186.6s|-17%|63.4s|82.8s|-23%|0.75|0.75|0%|1.58|1.58|0%|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8699) Use fixed byte array in HeapPointWriter

2019-02-22 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774963#comment-16774963
 ] 

ASF subversion and git services commented on LUCENE-8699:
-

Commit 9b8a4a9e6e4aa640faa6a9e35fab2f61b126dc07 in lucene-solr's branch 
refs/heads/master from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=9b8a4a9 ]

LUCENE-8699: Add lucene internal tag to PointValue interface
and fix some typos


> Use fixed byte array in HeapPointWriter
> ---
>
> Key: LUCENE-8699
> URL: https://issues.apache.org/jira/browse/LUCENE-8699
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Ignacio Vera
>Assignee: Ignacio Vera
>Priority: Major
> Fix For: 8.x, master (9.0)
>
>  Time Spent: 2h
>  Remaining Estimate: 0h
>
>  
> {heapPointWriter} is always created with the same init size and max size. It 
> might make sense to change the implementation to use a byte array instead of 
> a growable structure as it has now. This seems to improve performance:
>  
> ||Approach||Index time (sec): Dev||Index Time (sec): Base||Index Time: 
> Diff||Force merge time (sec): Dev||Force Merge time (sec): Base||Force Merge 
> Time: Diff||Index size (GB): Dev||Index size (GB): Base||Index Size: 
> Diff||Reader heap (MB): Dev||Reader heap (MB): Base||Reader heap: Diff||
> |points|122.1s|147.0s|-17%|51.9s|70.5s|-26%|0.55|0.55|0%|1.57|1.57|0%|
> |shapes|211.1s|244.6s|-14%|121.1s|135.0s|-10%|1.29|1.29|0%|1.61|1.61|0%|
> |geo3d|154.2s|186.6s|-17%|63.4s|82.8s|-23%|0.75|0.75|0%|1.58|1.58|0%|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8699) Use fixed byte array in HeapPointWriter

2019-02-20 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772911#comment-16772911
 ] 

ASF subversion and git services commented on LUCENE-8699:
-

Commit 66d4840860230613881aa42cf5837478d156f6e6 in lucene-solr's branch 
refs/heads/branch_8x from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=66d4840 ]

LUCENE-8699: Change HeapPointWriter to use a single byte array instead to a list
  of byte arrays. In addition a new interface PointValue is added to abstract 
out
  the different formats between offline and on-heap writers.


> Use fixed byte array in HeapPointWriter
> ---
>
> Key: LUCENE-8699
> URL: https://issues.apache.org/jira/browse/LUCENE-8699
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Ignacio Vera
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
>  
> {heapPointWriter} is always created with the same init size and max size. It 
> might make sense to change the implementation to use a byte array instead of 
> a growable structure as it has now. This seems to improve performance:
>  
> ||Approach||Index time (sec): Dev||Index Time (sec): Base||Index Time: 
> Diff||Force merge time (sec): Dev||Force Merge time (sec): Base||Force Merge 
> Time: Diff||Index size (GB): Dev||Index size (GB): Base||Index Size: 
> Diff||Reader heap (MB): Dev||Reader heap (MB): Base||Reader heap: Diff||
> |points|122.1s|147.0s|-17%|51.9s|70.5s|-26%|0.55|0.55|0%|1.57|1.57|0%|
> |shapes|211.1s|244.6s|-14%|121.1s|135.0s|-10%|1.29|1.29|0%|1.61|1.61|0%|
> |geo3d|154.2s|186.6s|-17%|63.4s|82.8s|-23%|0.75|0.75|0%|1.58|1.58|0%|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org



[jira] [Commented] (LUCENE-8699) Use fixed byte array in HeapPointWriter

2019-02-20 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/LUCENE-8699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772910#comment-16772910
 ] 

ASF subversion and git services commented on LUCENE-8699:
-

Commit 3ef6e015dd127b356e4163eb48411be94fb2d50c in lucene-solr's branch 
refs/heads/master from Ignacio Vera
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3ef6e01 ]

LUCENE-8699: Change HeapPointWriter to use a single byte array instead to a list
  of byte arrays. In addition a new interface PointValue is added to abstract 
out
  the different formats between offline and on-heap writers.


> Use fixed byte array in HeapPointWriter
> ---
>
> Key: LUCENE-8699
> URL: https://issues.apache.org/jira/browse/LUCENE-8699
> Project: Lucene - Core
>  Issue Type: Improvement
>Reporter: Ignacio Vera
>Priority: Major
>  Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
>  
> {heapPointWriter} is always created with the same init size and max size. It 
> might make sense to change the implementation to use a byte array instead of 
> a growable structure as it has now. This seems to improve performance:
>  
> ||Approach||Index time (sec): Dev||Index Time (sec): Base||Index Time: 
> Diff||Force merge time (sec): Dev||Force Merge time (sec): Base||Force Merge 
> Time: Diff||Index size (GB): Dev||Index size (GB): Base||Index Size: 
> Diff||Reader heap (MB): Dev||Reader heap (MB): Base||Reader heap: Diff||
> |points|122.1s|147.0s|-17%|51.9s|70.5s|-26%|0.55|0.55|0%|1.57|1.57|0%|
> |shapes|211.1s|244.6s|-14%|121.1s|135.0s|-10%|1.29|1.29|0%|1.61|1.61|0%|
> |geo3d|154.2s|186.6s|-17%|63.4s|82.8s|-23%|0.75|0.75|0%|1.58|1.58|0%|



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org