[jira] [Commented] (SOLR-10874) FloatPayloadValueSource throws assertion error if debug=true
[ https://issues.apache.org/jira/browse/SOLR-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049777#comment-16049777 ] Michael Kosten commented on SOLR-10874: --- You're not seeing it in the wild because assertions aren't enabled. I tried running solr in the wild with assertions enabled (which I don't think anyone would do normally), but it failed due to another assertion, so I can't get it to the point of executing a query with the payload function. However, when you do run in in the wild, the explain output is wrong, it shows 0.0 for the results of the payload function. You can see it in your comment above for doc 1: "product of:\n 0.0 = payload(vals_dpf,one,const(0.0))=0.0". I traced what happens when debug is true. The floatVal is called 3 times sequentially for each doc in the explain output. > FloatPayloadValueSource throws assertion error if debug=true > > > Key: SOLR-10874 > URL: https://issues.apache.org/jira/browse/SOLR-10874 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: search >Affects Versions: 6.6 >Reporter: Michael Kosten >Assignee: Erik Hatcher >Priority: Minor > Fix For: master (7.0), 6.7, 6.6.1 > > Attachments: SOLR-10874.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > Using the new payload function will fail with an assertion error if the debug > parameter is included in the query. This is caused by the floatValue method > in FloatPayloadValueSource being called for the same doc id twice in a row. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10874) FloatPayloadValueSource throws assertion error if debug=true
[ https://issues.apache.org/jira/browse/SOLR-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049179#comment-16049179 ] Erik Hatcher commented on SOLR-10874: - bq. Maybe this scenario only happens in very specific circumstances? What are your circumstances outside of this test case? I'd just like to experience it in the wild - I'll get the fix committed, ideally before for a 6.6.1 or 6.7. I tried with a single doc indexed to see if it had to do with only one document, but still didn't fail to work as expected though the test case definitely fails - my bad. > FloatPayloadValueSource throws assertion error if debug=true > > > Key: SOLR-10874 > URL: https://issues.apache.org/jira/browse/SOLR-10874 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: search >Affects Versions: 6.6 >Reporter: Michael Kosten >Assignee: Erik Hatcher >Priority: Minor > Fix For: master (7.0), 6.7, 6.6.1 > > Attachments: SOLR-10874.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > Using the new payload function will fail with an assertion error if the debug > parameter is included in the query. This is caused by the floatValue method > in FloatPayloadValueSource being called for the same doc id twice in a row. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10874) FloatPayloadValueSource throws assertion error if debug=true
[ https://issues.apache.org/jira/browse/SOLR-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048069#comment-16048069 ] Michael Kosten commented on SOLR-10874: --- It's an assertion error in AssertingLeafReader, so if the code performs correctly if assertions are disabled, then perhaps the assertion is unnecessary? If you skip that assertion, then it fails an assertion in Lucene50PostingsReader. The crux is that the postings reader doesn't like nextPosition being called for a document more than the term frequency, which is what happens if floatVal in FloatPayloadValueSource is called sequentially for the same document. Maybe this scenario only happens in very specific circumstances? > FloatPayloadValueSource throws assertion error if debug=true > > > Key: SOLR-10874 > URL: https://issues.apache.org/jira/browse/SOLR-10874 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: search >Affects Versions: 6.6 >Reporter: Michael Kosten >Priority: Minor > Attachments: SOLR-10874.patch > > Original Estimate: 2h > Remaining Estimate: 2h > > Using the new payload function will fail with an assertion error if the debug > parameter is included in the query. This is caused by the floatValue method > in FloatPayloadValueSource being called for the same doc id twice in a row. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10874) FloatPayloadValueSource throws assertion error if debug=true
[
https://issues.apache.org/jira/browse/SOLR-10874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047913#comment-16047913
]
Erik Hatcher commented on SOLR-10874:
-
[~makos...@me.com] ouch! investigating through a test case, but I am not
seeing it outside the test case. I'm trying it like this:
[http://localhost:/solr/payloads/query?q=\{!func}payload(vals_dpf,one)=*,score=true=id:(1%202)]
{code}
{
"responseHeader":{
"status":0,
"QTime":4,
"params":{
"q":"{!func}payload(vals_dpf,one)",
"debug":"true",
"fl":"*,score",
"fq":"id:(1 2)"}},
"response":{"numFound":2,"start":0,"maxScore":1.0,"docs":[
{
"id":"1",
"vals_dpf":"one|1.0 two|2.0 three|3.0",
"_version_":1569489972428275712,
"score":1.0},
{
"id":"2",
"vals_dpf":"weighted|50.0 weighted|100.0",
"_version_":1569489972431421440,
"score":0.0}]
},
"debug":{
"rawquerystring":"{!func}payload(vals_dpf,one)",
"querystring":"{!func}payload(vals_dpf,one)",
"parsedquery":"FunctionQuery(payload(vals_dpf,one,const(0.0)))",
"parsedquery_toString":"payload(vals_dpf,one,const(0.0))",
"explain":{
"1":"\n1.0 = FunctionQuery(payload(vals_dpf,one,const(0.0))), product
of:\n 0.0 = payload(vals_dpf,one,const(0.0))=0.0\n 1.0 = boost\n 1.0 =
queryNorm\n",
"2":"\n0.0 = FunctionQuery(payload(vals_dpf,one,const(0.0))), product
of:\n 0.0 = payload(vals_dpf,one,const(0.0))=0.0\n 1.0 = boost\n 1.0 =
queryNorm\n"},
"QParser":"FunctionQParser",
"filter_queries":["id:(1 2)"],
"parsed_filter_queries":["id:1 id:2"],
"timing":{
"time":4.0,
"prepare":{
"time":2.0,
"query":{
"time":2.0},
"facet":{
"time":0.0},
"facet_module":{
"time":0.0},
"mlt":{
"time":0.0},
"highlight":{
"time":0.0},
"stats":{
"time":0.0},
"expand":{
"time":0.0},
"terms":{
"time":0.0},
"debug":{
"time":0.0}},
"process":{
"time":1.0,
"query":{
"time":0.0},
"facet":{
"time":0.0},
"facet_module":{
"time":0.0},
"mlt":{
"time":0.0},
"highlight":{
"time":0.0},
"stats":{
"time":0.0},
"expand":{
"time":0.0},
"terms":{
"time":0.0},
"debug":{
"time":1.0}
{code}
> FloatPayloadValueSource throws assertion error if debug=true
>
>
> Key: SOLR-10874
> URL: https://issues.apache.org/jira/browse/SOLR-10874
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: search
>Affects Versions: 6.6
>Reporter: Michael Kosten
>Priority: Minor
> Attachments: SOLR-10874.patch
>
> Original Estimate: 2h
> Remaining Estimate: 2h
>
> Using the new payload function will fail with an assertion error if the debug
> parameter is included in the query. This is caused by the floatValue method
> in FloatPayloadValueSource being called for the same doc id twice in a row.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
