[jira] [Commented] (SOLR-10933) LetStream variables are not evaluated in proper order
[ https://issues.apache.org/jira/browse/SOLR-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16386393#comment-16386393 ] Cassandra Targett commented on SOLR-10933: -- [~joel.bernstein], looks like you made some commits to this some months ago, can it be resolved? > LetStream variables are not evaluated in proper order > - > > Key: SOLR-10933 > URL: https://issues.apache.org/jira/browse/SOLR-10933 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: streaming expressions >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Major > Fix For: 6.7, 7.0 > > Attachments: SOLR-10933.patch > > > The LetStream is currently using a HashMap to hold its variable mappings. > This is problematic because the ordering of the variables will be lost as > they are evaluated. The test cases pass currently because single letter > variables in ascending order are used which by luck caused the variables to > be evaluated in order. > There is a very simple fix for this which is to use a LinkedHashMap to hold > the variables to ensure they are evaluated in the order that they are > received. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10933) LetStream variables are not evaluated in proper order
[ https://issues.apache.org/jira/browse/SOLR-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16058221#comment-16058221 ] Joel Bernstein commented on SOLR-10933: --- Wow, that is a complicated expression. Are you just experimenting with the syntax? > LetStream variables are not evaluated in proper order > - > > Key: SOLR-10933 > URL: https://issues.apache.org/jira/browse/SOLR-10933 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Joel Bernstein >Assignee: Joel Bernstein > Fix For: master (7.0), 6.7 > > Attachments: SOLR-10933.patch > > > The LetStream is currently using a HashMap to hold its variable mappings. > This is problematic because the ordering of the variables will be lost as > they are evaluated. The test cases pass currently because single letter > variables in ascending order are used which by luck caused the variables to > be evaluated in order. > There is a very simple fix for this which is to use a LinkedHashMap to hold > the variables to ensure they are evaluated in the order that they are > received. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10933) LetStream variables are not evaluated in proper order
[ https://issues.apache.org/jira/browse/SOLR-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057631#comment-16057631 ] Susheel Kumar commented on SOLR-10933: -- You saved my day, Joel. I was struggling on this bit and after noticing this issue, i changed my variables to single alphabet the problem disappeared. let(a=fetch(collection1,having(rollup(over=email, count(email), select(search(collection1, q=*:*, fl="id,business_email", sort="business_email asc"), id, business_email as email)), eq(count(email),1)), fl="id,business_email as email", on="email=business_email"), b=fetch(collection1,having(rollup(over=email, count(email), select(search(collection1, q=*:*, fl="id,personal_email", sort="personal_email asc"), id, personal_email as email)), eq(count(email),1)), fl="id,personal_email as email", on="email=personal_email"), c=hashJoin(get(a),hashed=get(b),on="email"), d=hashJoin(get(b),hashed=get(a),on="email"), e=select(get(a),id,email), get(e) ) > LetStream variables are not evaluated in proper order > - > > Key: SOLR-10933 > URL: https://issues.apache.org/jira/browse/SOLR-10933 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Joel Bernstein >Assignee: Joel Bernstein > Fix For: master (7.0), 6.7 > > Attachments: SOLR-10933.patch > > > The LetStream is currently using a HashMap to hold its variable mappings. > This is problematic because the ordering of the variables will be lost as > they are evaluated. The test cases pass currently because single letter > variables in ascending order are used which by luck caused the variables to > be evaluated in order. > There is a very simple fix for this which is to use a LinkedHashMap to hold > the variables to ensure they are evaluated in the order that they are > received. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10933) LetStream variables are not evaluated in proper order
[ https://issues.apache.org/jira/browse/SOLR-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057584#comment-16057584 ] ASF subversion and git services commented on SOLR-10933: Commit adfaf340e027ac73a672f6916f0e9be72cd9e3d1 in lucene-solr's branch refs/heads/branch_6x from [~joel.bernstein] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=adfaf34 ] SOLR-10933: LetStream variables are not evaluated in proper order > LetStream variables are not evaluated in proper order > - > > Key: SOLR-10933 > URL: https://issues.apache.org/jira/browse/SOLR-10933 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Joel Bernstein > Fix For: master (7.0) > > Attachments: SOLR-10933.patch > > > The LetStream is currently using a HashMap to hold its variable mappings. > This is problematic because the ordering of the variables will be lost as > they are evaluated. The test cases pass currently because single letter > variables in ascending order are used which by luck caused the variables to > be evaluated in order. > There is a very simple fix for this which is to use a LinkedHashMap to hold > the variables to ensure they are evaluated in the order that they are > received. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-10933) LetStream variables are not evaluated in proper order
[ https://issues.apache.org/jira/browse/SOLR-10933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16057579#comment-16057579 ] ASF subversion and git services commented on SOLR-10933: Commit eff583ee889e4098ff0f5debb3a05ec09b2e7b19 in lucene-solr's branch refs/heads/master from [~joel.bernstein] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eff583e ] SOLR-10933: LetStream variables are not evaluated in proper order > LetStream variables are not evaluated in proper order > - > > Key: SOLR-10933 > URL: https://issues.apache.org/jira/browse/SOLR-10933 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Joel Bernstein > Fix For: master (7.0) > > Attachments: SOLR-10933.patch > > > The LetStream is currently using a HashMap to hold its variable mappings. > This is problematic because the ordering of the variables will be lost as > they are evaluated. The test cases pass currently because single letter > variables in ascending order are used which by luck caused the variables to > be evaluated in order. > There is a very simple fix for this which is to use a LinkedHashMap to hold > the variables to ensure they are evaluated in the order that they are > received. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
