[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[
https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170894#comment-16170894
]
Yonik Seeley commented on SOLR-11363:
-
Hmmm, I disabled domain switches and set the number of fields and values to 1,
and things still fail.
This looks like something fundamentally broken with faceting on points.
Example:
{code}
java.lang.AssertionError:
{main(json.facet={facet_1+:+{+type:terms,+field:field_0_is,+limit:+2}+}),extra(q=(field_0_ss:0+OR+field_0_ss:0+OR+field_0_ss:1+OR+field_0_ss:0+OR+field_0_ss:1+OR+field_0_ss:1)&rows=0)}
===>
{responseHeader={zkConnected=true,status=0,QTime=454},response={numFound=109,start=0,maxScore=2.0918934,docs=[]},facets={count=109,facet_1={buckets=[{val=0,count=122},
{val=1,count=102}]}}} --> facet_1:
q=field_0_is:0+AND+(field_0_ss:0+OR+field_0_ss:0+OR+field_0_ss:1+OR+field_0_ss:0+OR+field_0_ss:1+OR+field_0_ss:1)&rows=0
Expected :122
Actual :82
{code}
> TestCloudJSONFacetJoinDomain fails with Points enabled
> --
>
> Key: SOLR-11363
> URL: https://issues.apache.org/jira/browse/SOLR-11363
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 7.0
>Reporter: Yonik Seeley
>
> As Hoss noted in SOLR-10939, this test still had points disabled, and
> enabling them causes tests to fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[ https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170902#comment-16170902 ] Hoss Man commented on SOLR-11363: - yonik: I assume you noticed the "count=122" even though "numFound=109" ? Is it possible the faceting code is double counting when a (single) doc contains the same value multiple times in a multi-valued points field? (Is there a non-randomized test covering this situation?) > TestCloudJSONFacetJoinDomain fails with Points enabled > -- > > Key: SOLR-11363 > URL: https://issues.apache.org/jira/browse/SOLR-11363 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.0 >Reporter: Yonik Seeley > > As Hoss noted in SOLR-10939, this test still had points disabled, and > enabling them causes tests to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[
https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170925#comment-16170925
]
Yonik Seeley commented on SOLR-11363:
-
OK, I boiled it down to a very simple case that fails (when added to
TestJsonFacets:
{code}
@Test
public void testRepeatedNumerics() throws Exception {
Client client = Client.localClient();
client.add(sdoc("id", "1", "cat_s", "A", "where_s", "NY", "num_d", "4",
"num_i", "2", "val_b", "true", "sparse_s", "one", "num_is","0", "num_is","0"),
null);
client.commit();
client.testJQ(params("q", "id:1"
, "json.facet", "{f1:{terms:num_is}}"
)
, "facets=={count:1, " +
"f1:{buckets:[{val:0, count:1}]}}"
);
}
{code}
The actual count being returned now is "2", which is incorrect... it should be
the number of documents containing 0, which is 1
> TestCloudJSONFacetJoinDomain fails with Points enabled
> --
>
> Key: SOLR-11363
> URL: https://issues.apache.org/jira/browse/SOLR-11363
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Affects Versions: 7.0
>Reporter: Yonik Seeley
>
> As Hoss noted in SOLR-10939, this test still had points disabled, and
> enabling them causes tests to fail.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[ https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170955#comment-16170955 ] Yonik Seeley commented on SOLR-11363: - Yep, that's it old string docvalue based numerics deduped multiple values 1,2,2,3 became 1,2,3 SortedNumericDocValues (which we now use for points) does not dedup, and the JSON Facet API does not account for duplicate values. > TestCloudJSONFacetJoinDomain fails with Points enabled > -- > > Key: SOLR-11363 > URL: https://issues.apache.org/jira/browse/SOLR-11363 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.0 >Reporter: Yonik Seeley > > As Hoss noted in SOLR-10939, this test still had points disabled, and > enabling them causes tests to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[ https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16170970#comment-16170970 ] Hoss Man commented on SOLR-11363: - linking to SOLR-10924 for posterity. > TestCloudJSONFacetJoinDomain fails with Points enabled > -- > > Key: SOLR-11363 > URL: https://issues.apache.org/jira/browse/SOLR-11363 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.0 >Reporter: Yonik Seeley > > As Hoss noted in SOLR-10939, this test still had points disabled, and > enabling them causes tests to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[ https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172066#comment-16172066 ] ASF subversion and git services commented on SOLR-11363: Commit 7cc9ee65633f653cb5ebe5c031db4d339b809466 in lucene-solr's branch refs/heads/master from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7cc9ee6 ] SOLR-11363: handle repeated values in points docvalues fields > TestCloudJSONFacetJoinDomain fails with Points enabled > -- > > Key: SOLR-11363 > URL: https://issues.apache.org/jira/browse/SOLR-11363 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.0 >Reporter: Yonik Seeley > Attachments: SOLR-11363.patch > > > As Hoss noted in SOLR-10939, this test still had points disabled, and > enabling them causes tests to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11363) TestCloudJSONFacetJoinDomain fails with Points enabled
[ https://issues.apache.org/jira/browse/SOLR-11363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172069#comment-16172069 ] ASF subversion and git services commented on SOLR-11363: Commit ee2a2763af789eeb6a33cf3e9f7cf969caa3c56b in lucene-solr's branch refs/heads/branch_7x from [~yo...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ee2a276 ] SOLR-11363: handle repeated values in points docvalues fields > TestCloudJSONFacetJoinDomain fails with Points enabled > -- > > Key: SOLR-11363 > URL: https://issues.apache.org/jira/browse/SOLR-11363 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) >Affects Versions: 7.0 >Reporter: Yonik Seeley > Attachments: SOLR-11363.patch > > > As Hoss noted in SOLR-10939, this test still had points disabled, and > enabling them causes tests to fail. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
