[jira] [Commented] (SOLR-11425) SolrClientBuilder does not allow infinite timeout (value 0)
[ https://issues.apache.org/jira/browse/SOLR-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195039#comment-16195039 ] Shawn Heisey commented on SOLR-11425: - I can understand the instinct that led the design to exclude a value of zero, and even though infinite timeouts can be problematic, I think the patch for this issue is a good change -- it's not our job to enforce a finite timeout. I do wonder if perhaps the javadoc should have a note about zero being an infinite timeout, which could result in client operations that never return. > SolrClientBuilder does not allow infinite timeout (value 0) > --- > > Key: SOLR-11425 > URL: https://issues.apache.org/jira/browse/SOLR-11425 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 7.0 >Reporter: Peter Szantai-Kis >Assignee: Mark Miller > Fix For: 7.1, master (8.0) > > Attachments: SOLR-11425.patch, SOLR-11425.patch > > > [org.apache.solr.client.solrj.impl.SolrClientBuilder#withConnectionTimeout|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java#L53] > does not allow to set the value of 0 which means infinite timeout, but > [RequestConfig|https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html#getConnectTimeout()] > where it will be used have the option to do so. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11425) SolrClientBuilder does not allow infinite timeout (value 0)
[ https://issues.apache.org/jira/browse/SOLR-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16192964#comment-16192964 ] ASF subversion and git services commented on SOLR-11425: Commit d94322c6f1ecd507bda4c334f6e15c6ca91ea704 in lucene-solr's branch refs/heads/branch_7x from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d94322c ] SOLR-11425: SolrClientBuilder does not allow infinite timeout (value 0). # Conflicts: # solr/CHANGES.txt > SolrClientBuilder does not allow infinite timeout (value 0) > --- > > Key: SOLR-11425 > URL: https://issues.apache.org/jira/browse/SOLR-11425 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 7.0 >Reporter: Peter Szantai-Kis >Assignee: Mark Miller > Attachments: SOLR-11425.patch, SOLR-11425.patch > > > [org.apache.solr.client.solrj.impl.SolrClientBuilder#withConnectionTimeout|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java#L53] > does not allow to set the value of 0 which means infinite timeout, but > [RequestConfig|https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html#getConnectTimeout()] > where it will be used have the option to do so. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11425) SolrClientBuilder does not allow infinite timeout (value 0)
[ https://issues.apache.org/jira/browse/SOLR-11425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16189839#comment-16189839 ] ASF subversion and git services commented on SOLR-11425: Commit fc429399ecd917bd2fd1902f8a47e32d9093a786 in lucene-solr's branch refs/heads/master from markrmiller [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc42939 ] SOLR-11425: SolrClientBuilder does not allow infinite timeout (value 0). > SolrClientBuilder does not allow infinite timeout (value 0) > --- > > Key: SOLR-11425 > URL: https://issues.apache.org/jira/browse/SOLR-11425 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: SolrJ >Affects Versions: 7.0 >Reporter: Peter Szantai-Kis >Assignee: Mark Miller > Attachments: SOLR-11425.patch, SOLR-11425.patch > > > [org.apache.solr.client.solrj.impl.SolrClientBuilder#withConnectionTimeout|https://github.com/apache/lucene-solr/blob/master/solr/solrj/src/java/org/apache/solr/client/solrj/impl/SolrClientBuilder.java#L53] > does not allow to set the value of 0 which means infinite timeout, but > [RequestConfig|https://hc.apache.org/httpcomponents-client-ga/httpclient/apidocs/org/apache/http/client/config/RequestConfig.html#getConnectTimeout()] > where it will be used have the option to do so. -- This message was sent by Atlassian JIRA (v6.4.14#64029) - To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org
