[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624348#comment-16624348
]
ASF subversion and git services commented on SOLR-11836:
Commit a9723cd25298459db6d659a42d1f7b6c6c507139 in lucene-solr's branch
refs/heads/branch_7x from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a9723cd ]
SOLR-11836: Move CHANGES entry to the 7.6 section
(cherry picked from commit 60569fb)
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Fix For: 7.6, master (8.0)
>
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16624345#comment-16624345
]
ASF subversion and git services commented on SOLR-11836:
Commit 60569fbe4e8e9f9f9d57da9bf2570f847a26965c in lucene-solr's branch
refs/heads/master from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=60569fb ]
SOLR-11836: Move CHANGES entry to the 7.6 section
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611347#comment-16611347
]
Joel Bernstein commented on SOLR-11836:
---
It's the FacetStream that causing the -1 to stop working returning results. We
can fix that as well.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611275#comment-16611275
]
Yonik Seeley commented on SOLR-11836:
-
limit:-1 should work fine for JSON Facets.
bq. Also when I sent -1 directly to the JSON facet API it didn't return
results. I'll need to dig into why.
Perhaps other code in the middle (i.e. before it gets to the JSON Facet code)
manipulates that value and messes it up?
TestJsonFacets randomly specifies limit:-1 so this should be well tested too:
https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/search/facet/TestJsonFacets.java#L935
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611272#comment-16611272
]
Joel Bernstein commented on SOLR-11836:
---
I believe the Integer.MAX_VALUE is safe to use based on a review of
*FacetFieldProcessor*.
I will test out this patch locally.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611165#comment-16611165
]
Joel Bernstein commented on SOLR-11836:
---
Also when I sent -1 directly to the JSON facet API it didn't return results.
I'll need to dig into why.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611163#comment-16611163
]
Joel Bernstein commented on SOLR-11836:
---
In that particular spot there are no array allocations made. It may be that in
the lower level facet collecting code that array allocations are made based on
limit. We could dig and see how the limit is being used and/or also ping Yonik
and see what he thinks.
[~ysee...@gmail.com], do you feel it's safe to be setting the facet bucket
limit to Integer.MAX_VALUE?
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611161#comment-16611161
]
Varun Thacker commented on SOLR-11836:
--
I think we need to modify the patch a little after Joe's comment. We shouldn't
use nteger.MAX_VALUE explicitly from FacetStream. We should just pass down -1
and then let JSON Facets deal with -1 as it does currently .
So essentially remove this
{code:java}
if (this.bucketSizeLimit == -1) {
this.bucketSizeLimit = Integer.MAX_VALUE;
}{code}
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611158#comment-16611158
]
Varun Thacker commented on SOLR-11836:
--
Hi Joel,
I checked FacetFieldMerger and saw this statement which is why I assumed doing
the same thing in FacetStream would be the right thing to do.
{code:java}
int lim = freq.limit >= 0 ? (int)freq.limit : Integer.MAX_VALUE;{code}
{quote}or example it's possible that the JSON API is pre-allocating one or more
arrays of that size.
{quote}
If this is happening perhaps we should create another Jira as this would affect
JSON Facet API users as well?
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611153#comment-16611153
]
Joel Bernstein commented on SOLR-11836:
---
I was just looking this over and testing some things out locally.
I tested just sending -1 to the JSON -f-acet API and it didn't return results.
It's also not a documented thing to do.
I see that the patch sets the limit to Integer.MAX_VALUE. It would be good to
understand how this effects the internal data structures used by the JSON facet
API. For example it's possible that the JSON API is pre-allocating one or more
arrays of that size. This would not be an unusual thing todo inside Solr. If
that's the case then setting limit to Integer.MAX_VALUE would be something that
we want to avoid.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611142#comment-16611142
]
ASF subversion and git services commented on SOLR-11836:
Commit 1c493552a23741c4c2319ca35e5018603853db46 in lucene-solr's branch
refs/heads/branch_7x from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1c49355 ]
SOLR-11836: add all contributors for the patch
(cherry picked from commit 2b553f0)
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611140#comment-16611140
]
ASF subversion and git services commented on SOLR-11836:
Commit 2b553f03bec74f65604334b5047a9ce68dd5d344 in lucene-solr's branch
refs/heads/master from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2b553f0 ]
SOLR-11836: add all contributors for the patch
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611050#comment-16611050
]
Varun Thacker commented on SOLR-11836:
--
Okay looks like the patch was provided by Amrit and not Alfonso. I'll fix the
CHAGES entry
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611049#comment-16611049
]
ASF subversion and git services commented on SOLR-11836:
Commit 019239c77d6e502c76a293da0c2367c85b5d7843 in lucene-solr's branch
refs/heads/branch_7x from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=019239c ]
SOLR-11836: FacetStream works with bucketSizeLimit of -1 which will fetch all
the buckets
(cherry picked from commit d35d206)
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611046#comment-16611046
]
ASF subversion and git services commented on SOLR-11836:
Commit d35d2063a817b4b4a6975115860624686afe8964 in lucene-solr's branch
refs/heads/master from [~varunthacker]
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d35d206 ]
SOLR-11836: FacetStream works with bucketSizeLimit of -1 which will fetch all
the buckets
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611011#comment-16611011
]
Varun Thacker commented on SOLR-11836:
--
Running tests and committing it to master and 7_x and then checking with the
RM to backport
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611004#comment-16611004
]
Varun Thacker commented on SOLR-11836:
--
Patch applies cleanly on master. Looks good to me!
We should just commit this and it can be part of 7.5 .
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16402564#comment-16402564
]
Amrit Sarkar commented on SOLR-11836:
-
[~joel.bernstein] will the fix / workaround be part of Solr 7.3? thank you in
advance.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
>Priority: Major
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322022#comment-16322022
]
Alfonso Muñoz-Pomer Fuentes commented on SOLR-11836:
Thanks all for such a quick action. I looked at the code and until this makes
it to a stable release I’ll use {{Integer.MAX_VALUE}} instead of -1.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
[jira] [Commented] (SOLR-11836) Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
[
https://issues.apache.org/jira/browse/SOLR-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320511#comment-16320511
]
Joel Bernstein commented on SOLR-11836:
---
I haven't looked at the patch yet, but it sounds like a good change. I'll try
to get this looked at before the next release.
> Use -1 in bucketSizeLimit to get all facets, analogous to the JSON facet API
>
>
> Key: SOLR-11836
> URL: https://issues.apache.org/jira/browse/SOLR-11836
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: streaming expressions
>Affects Versions: 7.2
>Reporter: Alfonso Muñoz-Pomer Fuentes
> Labels: facet, streaming
> Attachments: SOLR-11836.patch
>
>
> Currently, to retrieve all buckets using the streaming expressions facet
> function, the {{bucketSizeLimit}} parameter must have a high enough value so
> that all results will be included. Compare this with the JSON facet API,
> where you can use {{"limit": -1}} to achieve this. It would help if such a
> possibility existed.
> [Issue 11236|https://issues.apache.org/jira/browse/SOLR-11236] is related.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
-
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
